public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Andrew Fish <afish@apple.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH] ArmPkg: fix compilation error in ArmDmaLib
Date: Thu, 1 Dec 2016 17:07:12 +0000	[thread overview]
Message-ID: <20161201170712.GO27069@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu-EVrLgR7Vm1F0QC4fsaU6tzHNnBfE4csfJ0GQJ1mdVqA@mail.gmail.com>

On Thu, Dec 01, 2016 at 05:00:19PM +0000, Ard Biesheuvel wrote:
> On 1 December 2016 at 16:45, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer")
> > retained an explicit cast on the variable "Buffer" which became
> > incorrect with the other changes, leading to compilation failures
> > with some toolchains. Drop the cast.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Reported-by: Sudeep Holla <sudeep.holla@arm.com>
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Get back on holiday!

Thanks :)

Pushed as 018c3c0, thanks.

/
    Leif

> > ---
> >
> > Mike, Andrew - since Ard is on holiday and the fix is trivial,
> > could either of you give me a Reviewed-by: on this one?
> >
> >  ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> > index acc106b..f4ee9e4 100644
> > --- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> > +++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c
> > @@ -142,7 +142,7 @@ DmaMap (
> >          CopyMem (Buffer, HostAddress, *NumberOfBytes);
> >        }
> >
> > -      *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress ((UINTN)Buffer));
> > +      *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress (Buffer));
> >        Map->BufferAddress = Buffer;
> >      } else {
> >        Map->DoubleBuffer  = FALSE;
> > --
> > 2.10.2
> >


      reply	other threads:[~2016-12-01 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 16:45 [PATCH] ArmPkg: fix compilation error in ArmDmaLib Leif Lindholm
2016-12-01 16:46 ` Sudeep Holla
2016-12-01 17:00 ` Ard Biesheuvel
2016-12-01 17:07   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161201170712.GO27069@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox