From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7665181F18 for ; Thu, 1 Dec 2016 09:07:16 -0800 (PST) Received: by mail-wm0-x22c.google.com with SMTP id t79so253889647wmt.0 for ; Thu, 01 Dec 2016 09:07:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qmxp/NqBatMm74KnxhrGEcq3ICFFKQT/8zsfYzRwzUg=; b=TQdXlTlj89/TrV4gFxLGSW0aE0hu5jxb1y2GYYyRjsxn6bCosyEPmUYjmyftDNFNOL tNz6aNR/ZL+sIgGMKp9lRFetiGWK6jTQaX1+2oIyRNR2uOOeRH2nEkrrtBc0GHjuTKNw UBJwFluZD30LTgNao07/kK5EI+RddGyaUgk+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qmxp/NqBatMm74KnxhrGEcq3ICFFKQT/8zsfYzRwzUg=; b=YA35LPDYEDIwnopv+50hXJKqCyyFYcG8x9JFtdcsDiY1JXOA4hz6bqsCU3WHm+ovW0 R9AQGYtIPOjEuFECJLt9/8fZtVUkjtbcwuPzwMIiwzBrIFA4YIloQy+ywMiRukDKNwoP g+XRMKGs9xwnfwyI5byhQWP/X0ZnJcDbdEIXuP3tVh9YMwwMn1TL/0djJO9awL02cyQh bqdva+7l5Vuh9BIfJLTP+rc19NbcGMYrs5qL2iKd8Yi45ytbNsMoZ7DKBD06lTfo8o/Q /RpyRPxRYaOaccyAVdixS7ikhzhhgQeeJYSSPa2a6rDkx8OhUWhyI0AIdcWfjeIB+T1Z KiGA== X-Gm-Message-State: AKaTC00CsS2XK5huiYNeZ1jUyi/6dAoj8XYmkXBJuhwuGPeQleIhhL3idzYSEBPfNRUVnKUV X-Received: by 10.28.174.76 with SMTP id x73mr35473840wme.25.1480612034930; Thu, 01 Dec 2016 09:07:14 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q7sm1232502wjh.9.2016.12.01.09.07.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2016 09:07:14 -0800 (PST) Date: Thu, 1 Dec 2016 17:07:12 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Sudeep Holla , Andrew Fish , Michael D Kinney Message-ID: <20161201170712.GO27069@bivouac.eciton.net> References: <20161201164502.9470-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] ArmPkg: fix compilation error in ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 17:07:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 01, 2016 at 05:00:19PM +0000, Ard Biesheuvel wrote: > On 1 December 2016 at 16:45, Leif Lindholm wrote: > > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") > > retained an explicit cast on the variable "Buffer" which became > > incorrect with the other changes, leading to compilation failures > > with some toolchains. Drop the cast. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Reported-by: Sudeep Holla > > Signed-off-by: Leif Lindholm > > Reviewed-by: Ard Biesheuvel Get back on holiday! Thanks :) Pushed as 018c3c0, thanks. / Leif > > --- > > > > Mike, Andrew - since Ard is on holiday and the fix is trivial, > > could either of you give me a Reviewed-by: on this one? > > > > ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > > index acc106b..f4ee9e4 100644 > > --- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > > +++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > > @@ -142,7 +142,7 @@ DmaMap ( > > CopyMem (Buffer, HostAddress, *NumberOfBytes); > > } > > > > - *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress ((UINTN)Buffer)); > > + *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress (Buffer)); > > Map->BufferAddress = Buffer; > > } else { > > Map->DoubleBuffer = FALSE; > > -- > > 2.10.2 > >