public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: David Wei <david.wei@intel.com>, Mang Guo <mang.guo@intel.com>
Subject: [PATCH 3/3] Vlv2TbltDevicePkg/BootScriptSaveDxe: save 64-bit LoopTimes
Date: Thu,  1 Dec 2016 18:55:56 +0100	[thread overview]
Message-ID: <20161201175556.2479-4-lersek@redhat.com> (raw)
In-Reply-To: <20161201175556.2479-1-lersek@redhat.com>

The BootScriptMemPoll() helper function does the following:

- pop LoopTimes from the variable argument list as UINT64, then truncate
  it to UINTN,

- pass the truncated value to S3BootScriptSaveMemPoll() as last argument.

The truncation to UINTN is now superfluous, thanks to the patch titled
"MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit
LoopTimes".

Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c b/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
index af7b9680b643..4c6667df0c61 100644
--- a/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
+++ b/Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c
@@ -348,14 +348,14 @@ BootScriptMemPoll (
   UINT8                 *BitMask;
   UINT8                 *BitValue;
   UINTN                Duration;
-  UINTN                LoopTimes;
+  UINT64               LoopTimes;
 
   Width       = VA_ARG (Marker, S3_BOOT_SCRIPT_LIB_WIDTH);
   Address     = VA_ARG (Marker, UINT64);
   BitMask     = VA_ARG (Marker, UINT8 *);
   BitValue    = VA_ARG (Marker, UINT8 *);
   Duration    = (UINTN)VA_ARG (Marker, UINT64);
-  LoopTimes   = (UINTN)VA_ARG (Marker, UINT64);
+  LoopTimes   = VA_ARG (Marker, UINT64);
 
   return S3BootScriptSaveMemPoll (Width, Address, BitMask, BitValue, Duration, LoopTimes);
 }
-- 
2.9.2



  parent reply	other threads:[~2016-12-01 17:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 17:55 [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL Laszlo Ersek
2016-12-01 17:55 ` [PATCH 1/3] MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit LoopTimes Laszlo Ersek
2016-12-01 17:55 ` [PATCH 2/3] MdeModulePkg: S3SaveStateDxe, SmmS3SaveState: save " Laszlo Ersek
2016-12-01 17:55 ` Laszlo Ersek [this message]
2016-12-02  1:53 ` [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL Yao, Jiewen
2016-12-02  4:54   ` Zeng, Star
2016-12-02  9:46     ` Laszlo Ersek
2016-12-02 23:56       ` Yao, Jiewen
2016-12-03 18:33         ` Laszlo Ersek
2016-12-09 22:58           ` Yao, Jiewen
2016-12-16  1:00             ` Kinney, Michael D
2017-01-03 11:35               ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161201175556.2479-4-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox