Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs

[Leif Lindholm <leif.lindholm@linaro.org>]

On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote:
> For the future, I'd recommend adding Cc's for package owners to the
> associated patch commit message.

I guess what you're actually asking for is to have only the parts of
series I want your review on sent to you?

That's a fair point, but having Cc: tags of package maintainers in the
commit log is just noise. And we are indeed seeing a lot of those at
the moment.

This seems like an excellent time to bring back the idea of unifying
the */Contributions.txt and codifying some of this behaviour
better. (None of them mention Cc: - and they are in fact all
bit-identical.)

Rather than derailing this thread, how about I send out a patch that
does just that, and then we can discuss modifications to the document?

> Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Many thanks - I'll apply for your packages.

Regards,

Leif

> On 2016-12-01 07:53:19, Leif Lindholm wrote:
> > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> > kept for compatibility.
> > 
> > Nevertheless, new code should be using the MdeModulePkg versions, so
> > change all references in in-tree platforms.
> > 
> > Since the patches are individually independent, I plan to push them
> > myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing
> > 1 and 2 myself before the whole series is reviewed?
> > 
> > Changes from RFC:
> > - Broken down into per-package patches.
> > - Received Reviewed-by:s added.
> > 
> > Leif Lindholm (7):
> >   OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >   QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >   BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >   EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >   DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >   EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs
> >   Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
> > 
> >  BeagleBoardPkg/BeagleBoardPkg.dsc       | 4 ++--
> >  DuetPkg/DuetPkgIa32.dsc                 | 4 ++--
> >  DuetPkg/DuetPkgX64.dsc                  | 4 ++--
> >  EmbeddedPkg/EmbeddedPkg.dsc             | 2 +-
> >  EmulatorPkg/EmulatorPkg.dsc             | 4 ++--
> >  OvmfPkg/OvmfPkgIa32.dsc                 | 4 ++--
> >  OvmfPkg/OvmfPkgIa32X64.dsc              | 4 ++--
> >  OvmfPkg/OvmfPkgX64.dsc                  | 4 ++--
> >  QuarkSocPkg/QuarkSocPkg.dsc             | 2 +-
> >  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> >  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc   | 6 +++---
> >  Vlv2TbltDevicePkg/PlatformPkgX64.dsc    | 6 +++---
> >  12 files changed, 24 insertions(+), 24 deletions(-)
> > 
> > -- 
> > 2.10.2
> > 
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel