From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-x22e.google.com (mail-wj0-x22e.google.com [IPv6:2a00:1450:400c:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D20C81F1D for ; Fri, 2 Dec 2016 04:02:46 -0800 (PST) Received: by mail-wj0-x22e.google.com with SMTP id xy5so230111660wjc.0 for ; Fri, 02 Dec 2016 04:02:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sJNs+D4SEplFNow7FuM0LWRR/yNeg17ViPDJegRQHgo=; b=VWRKwI0ZhmgpMybUM8uHwxfoKzJ1dMxLJ71nkf/VV/dSia/LJJ416NXqTS/YzDgiF/ YndTMputX1Rfi1NYjUYYTiuj6QMTCYWXYkio8es2bBWsYaRLJ4V8DfFGuieARDBxIbUX 6HFEOW7fstnO5lvjaxzqzaJnJ+60CeqEjlwrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sJNs+D4SEplFNow7FuM0LWRR/yNeg17ViPDJegRQHgo=; b=AgEGXSkpQKsePx/T6oV+0V8S1//zh1NV1WCb/EGwTYsow3e/J3jG16JYQIXqtSVmOa 4LuyDKcxpIlx+LMuTEmWVLn8aH64+hB5+y2nIyEsMPwNopllRTfJtsLMNMHLb8Hc5PyV 2G/CXcsmcRygbbh+MXdU/YKUGrexEz7sYlozcN+4tx7P3hWG++530zm9ipd8Z99RZ85A L+j5vJf3DCzZVmRmxbFrdx5pd1vR0HXRhoAOGsFfZlFGrXwZdoktqMf5wkZI6HEhRPau MENVCAtbQtPIKLS4fDByKSTMsrzIdjUbLXbaw/BfccgzCgKxWm1bL264IEjVoDAa/24M bMaQ== X-Gm-Message-State: AKaTC02sU9hUa/QOAmOTqqlsvC7zCXVzQ8KgG6SHgEKqbHHyagXEXG6wCE/isDvyeSR/So8Z X-Received: by 10.194.205.73 with SMTP id le9mr38818595wjc.31.1480680164300; Fri, 02 Dec 2016 04:02:44 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m145sm2879314wma.3.2016.12.02.04.02.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Dec 2016 04:02:43 -0800 (PST) Date: Fri, 2 Dec 2016 12:02:41 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: Jordan Justen , edk2-devel@ml01.01.org, Ruiyu Ni , Ard Biesheuvel , Andrew Fish , Michael D Kinney , David Wei Message-ID: <20161202120241.GU27069@bivouac.eciton.net> References: <20161201155326.21716-1-leif.lindholm@linaro.org> <148062112294.26637.9118356424650979744@jljusten-ivb> <20161202112708.GT27069@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 12:02:46 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 02, 2016 at 12:53:45PM +0100, Laszlo Ersek wrote: > On 12/02/16 12:27, Leif Lindholm wrote: > > On Thu, Dec 01, 2016 at 11:38:42AM -0800, Jordan Justen wrote: > >> For the future, I'd recommend adding Cc's for package owners to the > >> associated patch commit message. > > > > I guess what you're actually asking for is to have only the parts of > > series I want your review on sent to you? > > > > That's a fair point, but having Cc: tags of package maintainers in the > > commit log is just noise. > > Strongly disagree, I fully *want* the commit log to capture the fact > that I CC'd X, Y and Z, and if the committed patch doesn't have feedback > tags from them, that's not my fault. And if it did capture that, I would agree - but it doesn't. It's in-band text which may or may not have had any effect on the transmission of email - depending on client version, configuration and developer workflow. Nevertheless, this is exactly the discussion I wanted on a different thread than this as stated below. > Independently, technically speaking, there's also no other way for > assigning different sets of CC's to different patches in a series, to my > knowledge. There are hacks around it (for example, you can mail out each > patch individually, setting the CC's per mailing, or else edit the CC > headers (not commit message tags) in the formatted patch email), but > none of those stick around when you rebase the work for v2 or v3, and > format and send out the series again. > > > And we are indeed seeing a lot of those at > > the moment. > > > > This seems like an excellent time to bring back the idea of unifying > > the */Contributions.txt and codifying some of this behaviour > > better. (None of them mention Cc: - and they are in fact all > > bit-identical.) > > Well, my personal guide mentions Cc: > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-18 And that's an extremely useful resource, but entirely unofficial. Let's change that. Regards, Leif > Thanks > Laszlo > > > Rather than derailing this thread, how about I send out a patch that > > does just that, and then we can discuss modifications to the document? > > > >> Series Reviewed-by: Jordan Justen > > > > Many thanks - I'll apply for your packages. > > > > Regards, > > > > Leif > > > >> On 2016-12-01 07:53:19, Leif Lindholm wrote: > >>> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > >>> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > >>> kept for compatibility. > >>> > >>> Nevertheless, new code should be using the MdeModulePkg versions, so > >>> change all references in in-tree platforms. > >>> > >>> Since the patches are individually independent, I plan to push them > >>> myself as Reviewed-by:s appear. Laszlo/Mike - Are you OK with me pusing > >>> 1 and 2 myself before the whole series is reviewed? > >>> > >>> Changes from RFC: > >>> - Broken down into per-package patches. > >>> - Received Reviewed-by:s added. > >>> > >>> Leif Lindholm (7): > >>> OvmfPkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> QuarkSocPkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> BeagleBoardPkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> EmbeddedPkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> DuetPkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> EmulatorPkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs > >>> > >>> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++-- > >>> DuetPkg/DuetPkgIa32.dsc | 4 ++-- > >>> DuetPkg/DuetPkgX64.dsc | 4 ++-- > >>> EmbeddedPkg/EmbeddedPkg.dsc | 2 +- > >>> EmulatorPkg/EmulatorPkg.dsc | 4 ++-- > >>> OvmfPkg/OvmfPkgIa32.dsc | 4 ++-- > >>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++-- > >>> OvmfPkg/OvmfPkgX64.dsc | 4 ++-- > >>> QuarkSocPkg/QuarkSocPkg.dsc | 2 +- > >>> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++-- > >>> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++--- > >>> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++--- > >>> 12 files changed, 24 insertions(+), 24 deletions(-) > >>> > >>> -- > >>> 2.10.2 > >>> > >>> _______________________________________________ > >>> edk2-devel mailing list > >>> edk2-devel@lists.01.org > >>> https://lists.01.org/mailman/listinfo/edk2-devel >