From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-x231.google.com (mail-wj0-x231.google.com [IPv6:2a00:1450:400c:c01::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C7CE781FE8 for ; Mon, 5 Dec 2016 02:30:50 -0800 (PST) Received: by mail-wj0-x231.google.com with SMTP id xy5so285868887wjc.0 for ; Mon, 05 Dec 2016 02:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bat9vCLiLIlc1ivlQgJyEoZeZmprRYHl8ncjvGe6x5o=; b=dRkB4ZIrvVL/D2QXlbIa0QYJqPvGilXhmRjDuVigcakqR3t6qtktF++NZHehdVa/Di Z56ZgclZngAgviNmuBqGTcbG5QOCxTCcxZ+UxuifZ+cC/v3mTMyDe16mWoISh9fakk3Q NMMaKRgc3Re93NaxgR+91tZvHeh3Ni3kYx7H0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bat9vCLiLIlc1ivlQgJyEoZeZmprRYHl8ncjvGe6x5o=; b=Cou+36kIHIMH381gUn27qE0laRQk1apZBIzvC4BKPgn7nx39Q7T+JCb9bmNdbayqAt aXOOn73AXz0p9rj2Fp58/kjtavFlx7XyM8dBjjlCcVk+0c8jHqTXQyZvekzLAVSobuHJ lP77HRKq2Z3v8cQL5FVku95YOPf6HX+wuJoCfsjjVrDVNELHr+nNZZwcdhR51L58PoDp vJOe0KiKfzb5SGq34j+9D65weSwmzufYq4cV6AnSvzRNIjQOaERvB4qa+yZ5XDI4HqNo tRfTIwR4nItWXjRnN3/qtkJlckfMxp49FuD50JARKYcYAHml9G5oq5n7vEjWOM17Xm9N B/Ew== X-Gm-Message-State: AKaTC02Ohdik4ORTvQwFgoPn/Olu9VjnYClozj66yFyOmg14H1dSiSjbxBF6SwUmubT+fd+H X-Received: by 10.194.137.15 with SMTP id qe15mr55140654wjb.16.1480933848969; Mon, 05 Dec 2016 02:30:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u18sm17337894wmd.1.2016.12.05.02.30.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2016 02:30:48 -0800 (PST) Date: Mon, 5 Dec 2016 10:30:46 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: edk2-devel-01 , Ard Biesheuvel Message-ID: <20161205103046.GH27069@bivouac.eciton.net> References: <20161202202059.5061-1-lersek@redhat.com> <20161202202059.5061-6-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20161202202059.5061-6-lersek@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v2 5/6] ArmVirtPkg/QemuFwCfgLib: rebase lib instance to updated lib class header X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 10:30:51 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 02, 2016 at 09:20:58PM +0100, Laszlo Ersek wrote: > Put the FW_CFG_F_DMA constant, introduced in the last patch, to use. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek Reviewed-by: Leif Lindholm > --- > > Notes: > v2: > - no need to include another header [Leif] > - scope is smaller now (only FW_CFG_F_DMA) > > ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c b/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c > index 6033a2a14c42..1b19893709fc 100644 > --- a/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c > +++ b/ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c > @@ -163,7 +163,7 @@ QemuFwCfgInitialize ( > > QemuFwCfgSelectItem (QemuFwCfgItemInterfaceVersion); > Features = QemuFwCfgRead32 (); > - if ((Features & BIT1) != 0) { > + if ((Features & FW_CFG_F_DMA) != 0) { > mFwCfgDmaAddress = FwCfgDmaAddress; > InternalQemuFwCfgReadBytes = DmaReadBytes; > } > -- > 2.9.2 > >