From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Wei, David" <david.wei@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Guo, Mang" <mang.guo@intel.com>
Subject: Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
Date: Tue, 6 Dec 2016 09:22:11 +0000 [thread overview]
Message-ID: <20161206092211.GR27069@bivouac.eciton.net> (raw)
In-Reply-To: <89954A0B46707A448411A627AD4EEE34663B0AA2@SHSMSX101.ccr.corp.intel.com>
Many thanks.
Pushed as 46d4b18.
Regards,
Leif
On Tue, Dec 06, 2016 at 06:28:48AM +0000, Wei, David wrote:
> It looks good.
>
> Reviewed-by: David Wei <david.wei@intel.com>
>
> Thanks,
> David Wei
>
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Tuesday, December 06, 2016 1:33 AM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>
> Subject: Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs
>
> Hi David, Mang - any comments?
>
> All the other parts of the series have now been pushed.
>
> Regards,
>
> Leif
>
> On Thu, Dec 01, 2016 at 03:53:26PM +0000, Leif Lindholm wrote:
> > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> > kept for compatibility.
> >
> > Since the libraries are identical, move Vlv2TbltDevicePkg to use the
> > MdeModulePkg versions instead.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> > 3 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> > index 6da2a8a..80d75d1 100644
> > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> > @@ -1064,7 +1064,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> > <LibraryClasses>
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > }
> >
> > @@ -1121,7 +1121,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> > !endif
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > index 5b5523f..44ec378 100644
> > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> > @@ -332,7 +332,7 @@
> > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> > !else
> > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> > !endif
> >
> > @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> > <LibraryClasses>
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > }
> >
> > @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> > !endif
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > index 54d2b81..40568f6 100644
> > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> > @@ -332,7 +332,7 @@
> > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
> > !else
> > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf
> > !endif
> >
> > @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {
> > <LibraryClasses>
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > }
> >
> > @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf
> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
> > !endif
> > !if $(LZMA_ENABLE) == TRUE
> > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> > !endif
> > !if $(TARGET) != RELEASE
> > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > --
> > 2.10.2
> >
next prev parent reply other threads:[~2016-12-06 9:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 15:53 [PATCH 0/7] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-12-01 15:53 ` [PATCH 1/7] OvmfPkg: Remove " Leif Lindholm
2016-12-01 18:24 ` Laszlo Ersek
2016-12-01 15:53 ` [PATCH 2/7] QuarkSocPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 3/7] BeagleBoardPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 4/7] EmbeddedPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 5/7] DuetPkg: " Leif Lindholm
2016-12-02 2:01 ` Ni, Ruiyu
2016-12-01 15:53 ` [PATCH 6/7] EmulatorPkg: " Leif Lindholm
2016-12-01 15:53 ` [PATCH 7/7] Vlv2TbltDevicePkg: " Leif Lindholm
2016-12-05 17:32 ` Leif Lindholm
2016-12-06 6:28 ` Wei, David
2016-12-06 9:22 ` Leif Lindholm [this message]
2016-12-01 18:14 ` [PATCH 0/7] Various: Remove EDK2 " Kinney, Michael D
2016-12-01 19:38 ` Jordan Justen
2016-12-02 11:27 ` Leif Lindholm
2016-12-02 11:53 ` Laszlo Ersek
2016-12-02 12:02 ` Leif Lindholm
2016-12-02 16:13 ` Leif Lindholm
2016-12-05 15:38 ` Ard Biesheuvel
2016-12-05 16:02 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206092211.GR27069@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox