From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-x231.google.com (mail-wj0-x231.google.com [IPv6:2a00:1450:400c:c01::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF11F81FDC for ; Tue, 6 Dec 2016 01:22:15 -0800 (PST) Received: by mail-wj0-x231.google.com with SMTP id v7so312409472wjy.2 for ; Tue, 06 Dec 2016 01:22:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6QrlIJMVDEM7Zq1PAyjLvpwvV/g422sxGAGLOYwmgJs=; b=Qvo02YTf1xFExSav1NOSrreoXroQE+EYazScRMlCeGwO2WDoH6m230qIdaYsjtuLvn SnuCQzUK4NvrBPDv7tCV6QQdFROtI0/qanT7SZjC6v/BLRs9In15GHexlkHGMoYRZ0Ka Zqd1fl/hTnNQyf/Qtuyrdr0EKo06DZUkPxsc4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6QrlIJMVDEM7Zq1PAyjLvpwvV/g422sxGAGLOYwmgJs=; b=EFOe2pnFgIr3MsoK7UMX2CJLriFMLiHAu4VnvYkFtVXpd7hrlQxFnJZeTC5XE6jtAn NaVZrWpg7vqKt4xivqR3Ov8VrXl73El8bzB7vhcgUY6GF0qbNrecK+Quuyt8R5e1tLaz Nk0XyoDsVxZ0d3NXyPTvRh/wgZ9pSof1kOXzyBletIyE9DrbFlT+9z5/dPBrXC47tfv+ 7eV78JpbbiGjvJi3tyHAEf+KonzTVV6bFS61X9ObUKyECbytfF31i8cphz3P/eDD+oM2 8LChbhxaxC+m8+mJcFtRjKOsKtwJ3Xie8Gs6oTUMb6rwpDcprMxonVz8eEpXwiS0gD2f v3NQ== X-Gm-Message-State: AKaTC01QmoTfT3uthvO3zmqza2lDPMlsJ/KKr1GgVmLvURmUxC8bznHK4GuwO4X5I8ktQjPN X-Received: by 10.195.30.165 with SMTP id kf5mr52862084wjd.41.1481016133791; Tue, 06 Dec 2016 01:22:13 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 191sm2979040wmr.11.2016.12.06.01.22.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 01:22:13 -0800 (PST) Date: Tue, 6 Dec 2016 09:22:11 +0000 From: Leif Lindholm To: "Wei, David" Cc: "edk2-devel@lists.01.org" , "Guo, Mang" Message-ID: <20161206092211.GR27069@bivouac.eciton.net> References: <20161201155326.21716-1-leif.lindholm@linaro.org> <20161201155326.21716-8-leif.lindholm@linaro.org> <20161205173259.GQ27069@bivouac.eciton.net> <89954A0B46707A448411A627AD4EEE34663B0AA2@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <89954A0B46707A448411A627AD4EEE34663B0AA2@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 09:22:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Many thanks. Pushed as 46d4b18. Regards, Leif On Tue, Dec 06, 2016 at 06:28:48AM +0000, Wei, David wrote: > It looks good. > > Reviewed-by: David Wei > > Thanks, > David Wei > > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Tuesday, December 06, 2016 1:33 AM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Guo, Mang > Subject: Re: [PATCH 7/7] Vlv2TbltDevicePkg: Remove use of IntelFrameworkModulePkg legacy libs > > Hi David, Mang - any comments? > > All the other parts of the series have now been pushed. > > Regards, > > Leif > > On Thu, Dec 01, 2016 at 03:53:26PM +0000, Leif Lindholm wrote: > > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > > kept for compatibility. > > > > Since the libraries are identical, move Vlv2TbltDevicePkg to use the > > MdeModulePkg versions instead. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Leif Lindholm > > --- > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++-- > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++--- > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++--- > > 3 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > index 6da2a8a..80d75d1 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > @@ -1064,7 +1064,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { > > > > !if $(LZMA_ENABLE) == TRUE > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > !endif > > } > > > > @@ -1121,7 +1121,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf > > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf > > !endif > > !if $(LZMA_ENABLE) == TRUE > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > !endif > > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > index 5b5523f..44ec378 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > @@ -332,7 +332,7 @@ > > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > > !else > > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf > > !endif > > > > @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { > > > > !if $(LZMA_ENABLE) == TRUE > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > !endif > > } > > > > @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf > > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf > > !endif > > !if $(LZMA_ENABLE) == TRUE > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > !endif > > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > index 54d2b81..40568f6 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > @@ -332,7 +332,7 @@ > > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > > !else > > - DebugLib|IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > > SerialPortLib|$(PLATFORM_PACKAGE)/Library/SerialPortLib/SerialPortLib.inf > > !endif > > > > @@ -1058,7 +1058,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { > > > > !if $(LZMA_ENABLE) == TRUE > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > !endif > > } > > > > @@ -1115,7 +1115,7 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf > > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf > > !endif > > !if $(LZMA_ENABLE) == TRUE > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > > !endif > > !if $(TARGET) != RELEASE > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > -- > > 2.10.2 > >