* Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus
2016-12-07 3:40 [PATCH] ShellPkg: Assign the correct value to ShellStatus Gary Lin
@ 2016-12-07 3:45 ` Zhang, Lubo
2016-12-07 7:48 ` Ye, Ting
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Zhang, Lubo @ 2016-12-07 3:45 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org; +Cc: Ye, Ting, Fu, Siyuan, Wu, Jiaxin
Reviewed-by: Zhang Lubo <lubo.zhang@intel.com>
-----Original Message-----
From: Gary Lin [mailto:glin@suse.com]
Sent: Wednesday, December 07, 2016 11:41 AM
To: edk2-devel@lists.01.org
Cc: Zhang, Lubo <lubo.zhang@intel.com>; Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [PATCH] ShellPkg: Assign the correct value to ShellStatus
Since the type of ShellStatus is SHELL_STATUS, we should use SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
---
ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
index fb308cc3b6..d71688ed66 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
@@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
if (StrCmp (VarArg->Arg, L"host") == 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle, Status);
- ShellStatus = EFI_INVALID_PARAMETER;
+ ShellStatus = SHELL_INVALID_PARAMETER;
goto ON_EXIT;
} else if (StrCmp (VarArg->Arg, L"gw") == 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle, Status);
- ShellStatus = EFI_INVALID_PARAMETER;
+ ShellStatus = SHELL_INVALID_PARAMETER;
goto ON_EXIT;
} else if (StrCmp (VarArg->Arg, L"dns") == 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle, Status);
- ShellStatus = EFI_INVALID_PARAMETER;
+ ShellStatus = SHELL_INVALID_PARAMETER;
goto ON_EXIT;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus
2016-12-07 3:40 [PATCH] ShellPkg: Assign the correct value to ShellStatus Gary Lin
2016-12-07 3:45 ` Zhang, Lubo
@ 2016-12-07 7:48 ` Ye, Ting
2016-12-07 9:20 ` Fu, Siyuan
2016-12-08 0:56 ` Wu, Jiaxin
3 siblings, 0 replies; 6+ messages in thread
From: Ye, Ting @ 2016-12-07 7:48 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org; +Cc: Zhang, Lubo, Fu, Siyuan, Wu, Jiaxin
Reviewed-by: Ye Ting <ting.ye@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gary Lin
Sent: Wednesday, December 7, 2016 11:41 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus
Since the type of ShellStatus is SHELL_STATUS, we should use SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
---
ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
index fb308cc3b6..d71688ed66 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
@@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
if (StrCmp (VarArg->Arg, L"host") == 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle, Status);
- ShellStatus = EFI_INVALID_PARAMETER;
+ ShellStatus = SHELL_INVALID_PARAMETER;
goto ON_EXIT;
} else if (StrCmp (VarArg->Arg, L"gw") == 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle, Status);
- ShellStatus = EFI_INVALID_PARAMETER;
+ ShellStatus = SHELL_INVALID_PARAMETER;
goto ON_EXIT;
} else if (StrCmp (VarArg->Arg, L"dns") == 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle, Status);
- ShellStatus = EFI_INVALID_PARAMETER;
+ ShellStatus = SHELL_INVALID_PARAMETER;
goto ON_EXIT;
}
--
2.11.0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus
2016-12-07 3:40 [PATCH] ShellPkg: Assign the correct value to ShellStatus Gary Lin
2016-12-07 3:45 ` Zhang, Lubo
2016-12-07 7:48 ` Ye, Ting
@ 2016-12-07 9:20 ` Fu, Siyuan
2016-12-07 17:01 ` Carsey, Jaben
2016-12-08 0:56 ` Wu, Jiaxin
3 siblings, 1 reply; 6+ messages in thread
From: Fu, Siyuan @ 2016-12-07 9:20 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org; +Cc: Ye, Ting, Zhang, Lubo, Wu, Jiaxin
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Gary Lin
> Sent: Wednesday, December 7, 2016 11:41 AM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus
>
> Since the type of ShellStatus is SHELL_STATUS, we should use
> SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> Cc: Zhang Lubo <lubo.zhang@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> index fb308cc3b6..d71688ed66 100644
> --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
>
> if (StrCmp (VarArg->Arg, L"host") == 0) {
> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle, Status);
> - ShellStatus = EFI_INVALID_PARAMETER;
> + ShellStatus = SHELL_INVALID_PARAMETER;
> goto ON_EXIT;
> } else if (StrCmp (VarArg->Arg, L"gw") == 0) {
> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle, Status);
> - ShellStatus = EFI_INVALID_PARAMETER;
> + ShellStatus = SHELL_INVALID_PARAMETER;
> goto ON_EXIT;
> } else if (StrCmp (VarArg->Arg, L"dns") == 0) {
> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle, Status);
> - ShellStatus = EFI_INVALID_PARAMETER;
> + ShellStatus = SHELL_INVALID_PARAMETER;
> goto ON_EXIT;
> }
>
> --
> 2.11.0
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus
2016-12-07 9:20 ` Fu, Siyuan
@ 2016-12-07 17:01 ` Carsey, Jaben
0 siblings, 0 replies; 6+ messages in thread
From: Carsey, Jaben @ 2016-12-07 17:01 UTC (permalink / raw)
To: Fu, Siyuan, Gary Lin, edk2-devel@lists.01.org
Cc: Ye, Ting, Zhang, Lubo, Wu, Jiaxin, Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu,
> Siyuan
> Sent: Wednesday, December 07, 2016 1:20 AM
> To: Gary Lin <glin@suse.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>; Wu,
> Jiaxin <jiaxin.wu@intel.com>
> Subject: Re: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus
> Importance: High
>
> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Gary Lin
> > Sent: Wednesday, December 7, 2016 11:41 AM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting.ye@intel.com>; Zhang, Lubo <lubo.zhang@intel.com>;
> Fu,
> > Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> > Subject: [edk2] [PATCH] ShellPkg: Assign the correct value to ShellStatus
> >
> > Since the type of ShellStatus is SHELL_STATUS, we should use
> > SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Gary Lin <glin@suse.com>
> > Cc: Zhang Lubo <lubo.zhang@intel.com>
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > index fb308cc3b6..d71688ed66 100644
> > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> > @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
> >
> > if (StrCmp (VarArg->Arg, L"host") == 0) {
> > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> > (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle,
> Status);
> > - ShellStatus = EFI_INVALID_PARAMETER;
> > + ShellStatus = SHELL_INVALID_PARAMETER;
> > goto ON_EXIT;
> > } else if (StrCmp (VarArg->Arg, L"gw") == 0) {
> > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> > (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle,
> Status);
> > - ShellStatus = EFI_INVALID_PARAMETER;
> > + ShellStatus = SHELL_INVALID_PARAMETER;
> > goto ON_EXIT;
> > } else if (StrCmp (VarArg->Arg, L"dns") == 0) {
> > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> > (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle,
> Status);
> > - ShellStatus = EFI_INVALID_PARAMETER;
> > + ShellStatus = SHELL_INVALID_PARAMETER;
> > goto ON_EXIT;
> > }
> >
> > --
> > 2.11.0
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ShellPkg: Assign the correct value to ShellStatus
2016-12-07 3:40 [PATCH] ShellPkg: Assign the correct value to ShellStatus Gary Lin
` (2 preceding siblings ...)
2016-12-07 9:20 ` Fu, Siyuan
@ 2016-12-08 0:56 ` Wu, Jiaxin
3 siblings, 0 replies; 6+ messages in thread
From: Wu, Jiaxin @ 2016-12-08 0:56 UTC (permalink / raw)
To: Gary Lin, edk2-devel@lists.01.org; +Cc: Zhang, Lubo, Ye, Ting, Fu, Siyuan
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
> -----Original Message-----
> From: Gary Lin [mailto:glin@suse.com]
> Sent: Wednesday, December 7, 2016 11:41 AM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Lubo <lubo.zhang@intel.com>; Ye, Ting <ting.ye@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH] ShellPkg: Assign the correct value to ShellStatus
>
> Since the type of ShellStatus is SHELL_STATUS, we should use
> SHELL_INVALID_PARAMETER instead of EFI_INVALID_PARAMETER.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> Cc: Zhang Lubo <lubo.zhang@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
> ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> index fb308cc3b6..d71688ed66 100644
> --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c
> @@ -1319,15 +1319,15 @@ IfConfig6SetInterfaceInfo (
>
> if (StrCmp (VarArg->Arg, L"host") == 0) {
> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_IP_CONFIG), gShellNetwork2HiiHandle,
> Status);
> - ShellStatus = EFI_INVALID_PARAMETER;
> + ShellStatus = SHELL_INVALID_PARAMETER;
> goto ON_EXIT;
> } else if (StrCmp (VarArg->Arg, L"gw") == 0) {
> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_GW_CONFIG), gShellNetwork2HiiHandle,
> Status);
> - ShellStatus = EFI_INVALID_PARAMETER;
> + ShellStatus = SHELL_INVALID_PARAMETER;
> goto ON_EXIT;
> } else if (StrCmp (VarArg->Arg, L"dns") == 0) {
> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_IFCONFIG6_ERR_INVALID_DNS_CONFIG), gShellNetwork2HiiHandle,
> Status);
> - ShellStatus = EFI_INVALID_PARAMETER;
> + ShellStatus = SHELL_INVALID_PARAMETER;
> goto ON_EXIT;
> }
>
> --
> 2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread