public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ruiyu Ni <ruiyu.ni@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Feng Tian <feng.tian@intel.com>
Subject: [PATCH 5/8] MdeModulePkg/TerminalDxe: Refine SetTerminalDevicePath
Date: Tue, 10 Jan 2017 16:39:01 +0800	[thread overview]
Message-ID: <20170110083904.34104-6-ruiyu.ni@intel.com> (raw)
In-Reply-To: <20170110083904.34104-1-ruiyu.ni@intel.com>

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
---
 .../Universal/Console/TerminalDxe/Terminal.c       | 41 ++--------------------
 1 file changed, 3 insertions(+), 38 deletions(-)

diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
index 4b0c00d..7197f59 100644
--- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
@@ -1577,46 +1577,11 @@ SetTerminalDevicePath (
 {
   VENDOR_DEVICE_PATH  Node;
 
-  *TerminalDevicePath = NULL;
+  ASSERT (TerminalType < ARRAY_SIZE (mTerminalType));
   Node.Header.Type    = MESSAGING_DEVICE_PATH;
   Node.Header.SubType = MSG_VENDOR_DP;
-
-  //
-  // Generate terminal device path node according to terminal type.
-  //
-  switch (TerminalType) {
-
-  case TerminalTypePcAnsi:
-    CopyGuid (&Node.Guid, &gEfiPcAnsiGuid);
-    break;
-
-  case TerminalTypeVt100:
-    CopyGuid (&Node.Guid, &gEfiVT100Guid);
-    break;
-
-  case TerminalTypeVt100Plus:
-    CopyGuid (&Node.Guid, &gEfiVT100PlusGuid);
-    break;
-
-  case TerminalTypeVtUtf8:
-    CopyGuid (&Node.Guid, &gEfiVTUTF8Guid);
-    break;
-
-  case TerminalTypeTtyTerm:
-    CopyGuid (&Node.Guid, &gEfiTtyTermGuid);
-    break;
-
-  default:
-    return EFI_UNSUPPORTED;
-  }
-
-  //
-  // Get VENDOR_DEVCIE_PATH size and put into Node.Header
-  //
-  SetDevicePathNodeLength (
-    &Node.Header,
-    sizeof (VENDOR_DEVICE_PATH)
-    );
+  SetDevicePathNodeLength (&Node, sizeof (VENDOR_DEVICE_PATH));
+  CopyGuid (&Node.Guid, mTerminalType[TerminalType]);
 
   //
   // Append the terminal node onto parent device path
-- 
2.9.0.windows.1



  parent reply	other threads:[~2017-01-10  8:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  8:38 [PATCH 0/8] Fix TerminalDxe driver model bug Ruiyu Ni
2017-01-10  8:38 ` [PATCH 1/8] MdeModulePkg/TerminalDxe: Replace macro with enum for terminal types Ruiyu Ni
2017-01-11  7:32   ` Tian, Feng
2017-01-10  8:38 ` [PATCH 2/8] MdeModulePkg/TerminalDxe: Add TerminalTypeFromGuid internal function Ruiyu Ni
2017-01-10  8:38 ` [PATCH 3/8] MdeModulePkg/TerminalDxe: Separate controller name init logic Ruiyu Ni
2017-01-10  8:39 ` [PATCH 4/8] MdeModulePkg/TerminalDxe: Refine InitializeTerminalConsoleTextMode Ruiyu Ni
2017-01-12 10:41   ` Laszlo Ersek
2017-01-12 15:39     ` Ni, Ruiyu
2017-01-10  8:39 ` Ruiyu Ni [this message]
2017-01-10  8:39 ` [PATCH 6/8] MdeModulePkg/TerminalDxe: Separate state machine start/stop logic Ruiyu Ni
2017-01-10  8:39 ` [PATCH 7/8] MdeModulePkg/TerminalDxe: Remove unnecessary NULL pointer check Ruiyu Ni
2017-01-10  8:39 ` [PATCH 8/8] MdeModulePkg/TerminalDxe: Fix driver model bug Ruiyu Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110083904.34104-6-ruiyu.ni@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox