From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59B75817B5 for ; Tue, 10 Jan 2017 07:58:25 -0800 (PST) X-IronPort-AV: E=Sophos;i="5.33,344,1477958400"; d="scan'208";a="398968730" Date: Tue, 10 Jan 2017 15:58:23 +0000 From: Anthony PERARD To: Laszlo Ersek CC: , Message-ID: <20170110155823.GD1903@perard.uk.xensource.com> References: <20161208153340.2285-1-anthony.perard@citrix.com> <20161208153340.2285-4-anthony.perard@citrix.com> <0ec7949b-924f-edec-5d0c-fad0976cf572@redhat.com> MIME-Version: 1.0 In-Reply-To: <0ec7949b-924f-edec-5d0c-fad0976cf572@redhat.com> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [PATCH RFC 03/14] OvmfPkg/XenOvmf.dsc: Introduce XenResetVector X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 15:58:25 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Jan 04, 2017 at 08:49:15PM +0100, Laszlo Ersek wrote: > > diff --git a/OvmfPkg/XenResetVector/Ia32/PageTables64.asm b/OvmfPkg/XenResetVector/Ia32/PageTables64.asm > > new file mode 100644 > > index 0000000..b5a4cf8 > > --- /dev/null > > +++ b/OvmfPkg/XenResetVector/Ia32/PageTables64.asm > > @@ -0,0 +1,93 @@ > > +;------------------------------------------------------------------------------ > > +; @file > > +; Sets the CR3 register for 64-bit paging > > +; > > +; Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved.
> > +; This program and the accompanying materials > > +; are licensed and made available under the terms and conditions of the BSD License > > +; which accompanies this distribution. The full text of the license may be found at > > +; http://opensource.org/licenses/bsd-license.php > > +; > > +; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > +; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > +; > > +;------------------------------------------------------------------------------ > > + > > +BITS 32 > > + > > +%define PAGE_PRESENT 0x01 > > +%define PAGE_READ_WRITE 0x02 > > +%define PAGE_USER_SUPERVISOR 0x04 > > +%define PAGE_WRITE_THROUGH 0x08 > > +%define PAGE_CACHE_DISABLE 0x010 > > +%define PAGE_ACCESSED 0x020 > > +%define PAGE_DIRTY 0x040 > > +%define PAGE_PAT 0x080 > > +%define PAGE_GLOBAL 0x0100 > > +%define PAGE_2M_MBO 0x080 > > +%define PAGE_2M_PAT 0x01000 > > + > > +%define PAGE_2M_PDE_ATTR (PAGE_2M_MBO + \ > > + PAGE_ACCESSED + \ > > + PAGE_DIRTY + \ > > + PAGE_READ_WRITE + \ > > + PAGE_PRESENT) > > + > > +%define PAGE_PDP_ATTR (PAGE_ACCESSED + \ > > + PAGE_READ_WRITE + \ > > + PAGE_PRESENT) > > + > > + > > +; > > +; Modified: EAX, ECX > > +; > > +SetCr3ForPageTables64: > > + > > + ; > > + ; For OVMF, build some initial page tables at 0x800000-0x806000. > > (6) Are you intentionally undoing, in the copy, commit 73d66c5871cc? If > so, why? No, I just need to use --find-copies-harder to find out about recent changes. > For now I suspect that you originally created this patch before commit > 73d66c5871cc came into existence. If that's the case, then please rebase > (re-copy and customize) this patch to the most recent ResetVector state, > including commit 73d66c5871cc. I don't think I've customize this file, this could be a link, or I could try to have the build system use the original file from OvmfPkg/ResetVector. Thanks, -- Anthony PERARD