From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A96481D8E for ; Mon, 16 Jan 2017 10:09:44 -0800 (PST) Received: by mail-wm0-x22e.google.com with SMTP id r126so169477961wmr.0 for ; Mon, 16 Jan 2017 10:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xEwtdmL9aXvyXy/otFcC5yWveQ4Y8zSHcazGMT+RC5w=; b=kTHQN5PtAngpxj0mQJLzpAcgVjmzVXFH9O1vEpB/vhd73orlQUTj4sJiTAwMsGaXAY G11wb2gNxzjk+zkVp/EZbEVb/EasfnxTTUMTTdVvs5KRAUnNkmaKMOwJjisb3kjkLS+Q ItrFtoGSbnAbqwpiiVl+2dXInKJBAxy6UuLqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xEwtdmL9aXvyXy/otFcC5yWveQ4Y8zSHcazGMT+RC5w=; b=Ncrd2/GsDhsldX19s9bb9q2BZ22XkJVCLGFLYg6MZSQ0YTDHvijCZkWmyT7fnmTFw0 7M/PLQ11rXMt6/DbC2Ml+1QEPPRCbOMym8HQFakauiOSPVSe6a8NXelyPE0iOhpE+I4u DBUuCCneVU1Pn3jAQlSmqjs+eRkoqdKY3j1zxthx0T5AzR+8duJQj93s5+LoVO2rBhBp bLFCkJFJsdSrtuotH/eLlAs2Ee0tj+miGQIn6DabD+J7LdPH4K54wxrITe8wKtT7JvCQ tbPOa4VOLf/Nv+HCExS5t53B7EBh4mn6qJcUHm2hsaF16NPan4eHrvRVYYeYG8ScRlbA Bmog== X-Gm-Message-State: AIkVDXLA4xLx+dJVNM7O5rNVNPbaW/pwBSeEE6y1cXw0L9P1ujIgohmPMXrH8Q9qlXcmQndg X-Received: by 10.223.151.138 with SMTP id s10mr24593999wrb.65.1484590183167; Mon, 16 Jan 2017 10:09:43 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w18sm30393199wme.9.2017.01.16.10.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jan 2017 10:09:42 -0800 (PST) Date: Mon, 16 Jan 2017 18:09:40 +0000 From: Leif Lindholm To: Michael Zimmermann Cc: edk2-devel@lists.01.org Message-ID: <20170116180940.GO25883@bivouac.eciton.net> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] ArmPlatformPkg: MemoryInitPei: fix wrong check for system memory X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 18:09:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Michael, Could you provide a message body explaining the error that this patch fixes so that I don't sprain my brain trying to figure it out? On Thu, Jan 12, 2017 at 04:46:57PM +0100, Michael Zimmermann wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Zimmermann > --- > ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c > b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c > index 2feb11f21d..8f6781212e 100644 > --- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c > +++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c > @@ -103,7 +103,7 @@ MemoryPeim ( > while ((NextHob.Raw = GetNextHob (EFI_HOB_TYPE_RESOURCE_DESCRIPTOR, > NextHob.Raw)) != NULL) { > if ((NextHob.ResourceDescriptor->ResourceType == > EFI_RESOURCE_SYSTEM_MEMORY) && > (PcdGet64 (PcdSystemMemoryBase) >= > NextHob.ResourceDescriptor->PhysicalStart) && > - (NextHob.ResourceDescriptor->PhysicalStart + > NextHob.ResourceDescriptor->ResourceLength <= PcdGet64 > (PcdSystemMemoryBase) + PcdGet64 (PcdSystemMemorySize))) It looks like the patch got corrupted on submission (lines wrapped). Could you resend it please? > + (NextHob.ResourceDescriptor->PhysicalStart + > NextHob.ResourceDescriptor->ResourceLength >= PcdGet64 > (PcdSystemMemoryBase) + PcdGet64 (PcdSystemMemorySize))) > { > Found = TRUE; > break; > -- > 2.11.0 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel