From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D561E81E76 for ; Wed, 18 Jan 2017 22:56:51 -0800 (PST) Received: from nwb-ext-pat.microfocus.com ([10.120.13.103]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Thu, 19 Jan 2017 07:56:49 +0100 Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.202]) by nwb-ext-pat.microfocus.com with ESMTP (TLS encrypted); Thu, 19 Jan 2017 06:56:20 +0000 Date: Thu, 19 Jan 2017 14:56:13 +0800 From: Gary Lin To: Jiaxin Wu Cc: edk2-devel@lists.01.org, Ruiyu Ni , Ye Ting , Justen Jordan L , Kinney Michael D , Fu Siyuan , Laszlo Ersek Message-ID: <20170119065613.vfefknemnwdf5h3u@GaryWorkstation> References: <1484803083-147376-1-git-send-email-jiaxin.wu@intel.com> <1484803083-147376-4-git-send-email-jiaxin.wu@intel.com> MIME-Version: 1.0 In-Reply-To: <1484803083-147376-4-git-send-email-jiaxin.wu@intel.com> User-Agent: Mutt/1.6.2 (2016-07-01) Subject: Re: [PATCH 3/3] OvmfPkg: Allow HTTP connections if HTTP Boot enabled X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 06:56:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 19, 2017 at 01:18:03PM +0800, Jiaxin Wu wrote: > Overwrite the value of PcdAllowHttpConnections to allow HTTP > connections if HTTP Boot enabled (-D HTTP_BOOT_ENABLE). > When setting PcdAllowHttpConnections to FALSE, I got this with OVMF: HttpBootCheckUriScheme: HTTP is disabled. HttpBootDhcp4ExtractUriInfo: Access Denied. It works as expected :-) Reviewed-by and Tested-by Gary Lin > Cc: Laszlo Ersek > Cc: Justen Jordan L > Cc: Gary Lin > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Ruiyu Ni > Cc: Kinney Michael D > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Wu Jiaxin > --- > OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- > OvmfPkg/OvmfPkgIa32X64.dsc | 6 +++++- > OvmfPkg/OvmfPkgX64.dsc | 6 +++++- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index e060602..2c38578 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -394,10 +394,14 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > + !if $(HTTP_BOOT_ENABLE) == TRUE > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > + !endif > + > # DEBUG_INIT 0x00000001 // Initialization > # DEBUG_WARN 0x00000002 // Warnings > # DEBUG_LOAD 0x00000004 // Load events > # DEBUG_FS 0x00000008 // EFI File system > # DEBUG_POOL 0x00000010 // Alloc & Free (pool) > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 0e24e7a..2760533 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -440,10 +440,14 @@ > !ifdef $(SOURCE_DEBUG_ENABLE) > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 > !endif > > [PcdsFixedAtBuild.X64] > +!if $(HTTP_BOOT_ENABLE) == TRUE > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > +!endif > + > !ifndef $(USE_OLD_SHELL) > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > !endif > > !if $(SMM_REQUIRE) == TRUE > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 108f7d5..56fddc3 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -1,9 +1,9 @@ > ## @file > # EFI/Framework Open Virtual Machine Firmware (OVMF) platform > # > -# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -399,10 +399,14 @@ > > gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0 > > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > > + !if $(HTTP_BOOT_ENABLE) == TRUE > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > + !endif > + > # DEBUG_INIT 0x00000001 // Initialization > # DEBUG_WARN 0x00000002 // Warnings > # DEBUG_LOAD 0x00000004 // Load events > # DEBUG_FS 0x00000008 // EFI File system > # DEBUG_POOL 0x00000010 // Alloc & Free (pool) > -- > 1.9.5.msysgit.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >