From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4A9E81FEA for ; Mon, 13 Feb 2017 09:15:52 -0800 (PST) Received: by mail-wr0-x231.google.com with SMTP id k90so154665611wrc.3 for ; Mon, 13 Feb 2017 09:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uEsHGag0y3MaW7RcaO3tvyKSOV7A3beJXMW45aDMOTs=; b=f2W9hkN92FbuNMfXhnAB710EjqsM848rqqeicM/EJ31Wp96kPHHCzT+KIPos7cRUrX e2VEyDK9AiN0OsT5WUVghGmLFKfs7jnEfHQGPWMuzzLEP8521C5q44P6kksXms96yF3j hGKDYE2GmSnja3RRXPdtDx9mfbCEG1/uR4sgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uEsHGag0y3MaW7RcaO3tvyKSOV7A3beJXMW45aDMOTs=; b=mycAln9mAFfMu6xdmTMeQwqmo6TjsestjH0vc8iVmlOT7G6uglaLsP6hpjfoQAL1yW sGW0ZaMxfMBV9TYrJu5V3FFqU2nQsdDW+I5lApjE/824WQre0XuceDC9rWm/A+7dB6Pq 7q32QsnoPWIvdsWZ2YLKUXhVxmtFaEwC2xwuKkIycRAM+b8hNVGswNJbv05lHPPEQJfz zX/HCOVjVeZnypBQlIf+Yol/kriRvG0F50sSNvtzSO2Ag4cmzhoPwBPcfnSVHecSDkww FlPLPsFjZwNpTh5L5NOQM1abunevUeO/fN2vaBnpignR97Y9IeSa8xgyq5JMnSWTGsix sjPA== X-Gm-Message-State: AMke39kl4bbcQ5gIiV4Qp1ysEc9emYVTIaMuvXW1CELCARrTRW48IZqyu7Jqt46ThRsAEV+5 X-Received: by 10.223.151.205 with SMTP id t13mr20982061wrb.9.1487006151242; Mon, 13 Feb 2017 09:15:51 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v102sm14638912wrb.11.2017.02.13.09.15.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Feb 2017 09:15:50 -0800 (PST) Date: Mon, 13 Feb 2017 17:15:48 +0000 From: Leif Lindholm To: Evan Lloyd Cc: "edk2-devel@ml01.01.org" , "ryan.harkin@linaro.org" , "ard.biesheuvel@linaro.org" Message-ID: <20170213171548.GD16034@bivouac.eciton.net> References: <20170209192623.262044-1-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/4] HardwareInterrupt2 protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 17:15:53 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Evan, No, this is all fine - you've submitted his originals as "From: Ard Biesheuvel", which retains him as original author of 1-3. It's completely up to Ard whether he wants to get involved or not at this point. The v1 of the series was sent out by you, so I expect any v2 to come from you as well :) This may be a slightly unusual situation for the edk2-devel mailing list, but it's just business as usual on many Linux kernel lists. Regards, Leif On Mon, Feb 13, 2017 at 03:51:58PM +0000, Evan Lloyd wrote: > I'd like to make something clear here. We found a problem and > solicited opinion. Ard very helpfully proposed a solution, complete > with a rapid response example patch. > However, it was code he wrote quickly to propose a solution - and I > imagine he didn't expect it to go directly into the code line. We > submitted his patches as sent, because we felt we should not take > credit for his excellent work. So any problems here are our fault, > not Ard's - and he didn't get to review things before submission. > I'll tidy things up, and try again. > > Evan > > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >evan.lloyd@arm.com > >Sent: 09 February 2017 19:26 > >To: edk2-devel@ml01.01.org > >Cc: ryan.harkin@linaro.org; Leif Lindholm; ard.biesheuvel@linaro.org > >Subject: [edk2] [PATCH 0/4] HardwareInterrupt2 protocol > > > >From: Evan Lloyd > > > >This series of patches corrects a problem detected on the ARM Juno > >platform that is actually generic (at least to ARM GIC platforms). > >The HardwareInterrupt protocol had no means of handling characteristics > >like Edge/Level triggered and polarity. > > > >A new HardwareInterrupt2 protocol (provided by Ard) is added, > >and code changed to utilise the new capabilities. > > > >The code is available for examination on Github at: > > https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v1 > > > >Ard Biesheuvel (3): > > EmbeddedPkg: introduce HardwareInterrupt2 protocol > > ArmPkg/ArmGicDxe: expose HardwareInterrupt2 protocol > > ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type > > > >Girish Pathak (1): > > ArmPkg:Provide GetTriggerType/SetTriggerType functions > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 1 + > > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 4 +- > > ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 2 + > > ArmPkg/Include/Library/ArmGicLib.h | 4 + > > EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 181 > >++++++++++++++++++++ > > ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 2 + > > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 181 > >+++++++++++++++++++- > > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 178 > >++++++++++++++++++- > > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 27 +-- > > 10 files changed, 567 insertions(+), 14 deletions(-) > > create mode 100644 > >EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h > > > >-- > >Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.