public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint
@ 2017-02-23 12:42 Anthony PERARD
  2017-02-23 12:57 ` Gao, Liming
  0 siblings, 1 reply; 3+ messages in thread
From: Anthony PERARD @ 2017-02-23 12:42 UTC (permalink / raw)
  To: edk2-devel; +Cc: Laszlo Ersek, Jordan Justen, Anthony PERARD

... because this function use VA_COPY.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 OvmfPkg/XenBusDxe/XenStore.h | 1 +
 OvmfPkg/XenBusDxe/XenStore.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/OvmfPkg/XenBusDxe/XenStore.h b/OvmfPkg/XenBusDxe/XenStore.h
index c9d4c6509a..33bb647f66 100644
--- a/OvmfPkg/XenBusDxe/XenStore.h
+++ b/OvmfPkg/XenBusDxe/XenStore.h
@@ -209,6 +209,7 @@ XenStoreSPrint (
            indicating the type of write failure.
 **/
 XENSTORE_STATUS
+EFIAPI
 XenStoreVSPrint (
   IN CONST XENSTORE_TRANSACTION *Transaction,
   IN CONST CHAR8           *DirectoryPath,
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
index 76b6e297ef..6812e1078c 100644
--- a/OvmfPkg/XenBusDxe/XenStore.c
+++ b/OvmfPkg/XenBusDxe/XenStore.c
@@ -1304,6 +1304,7 @@ XenStoreTransactionEnd (
 }
 
 XENSTORE_STATUS
+EFIAPI
 XenStoreVSPrint (
   IN CONST XENSTORE_TRANSACTION *Transaction,
   IN CONST CHAR8           *DirectoryPath,
-- 
Anthony PERARD



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint
  2017-02-23 12:42 [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint Anthony PERARD
@ 2017-02-23 12:57 ` Gao, Liming
  2017-02-23 16:10   ` Laszlo Ersek
  0 siblings, 1 reply; 3+ messages in thread
From: Gao, Liming @ 2017-02-23 12:57 UTC (permalink / raw)
  To: Anthony PERARD, edk2-devel@lists.01.org; +Cc: Justen, Jordan L, Laszlo Ersek

Reviewed-by: Liming Gao <liming.gao@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Anthony PERARD
Sent: Thursday, February 23, 2017 8:42 PM
To: edk2-devel@lists.01.org
Cc: Anthony PERARD <anthony.perard@citrix.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [edk2] [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint

... because this function use VA_COPY.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 OvmfPkg/XenBusDxe/XenStore.h | 1 +
 OvmfPkg/XenBusDxe/XenStore.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/OvmfPkg/XenBusDxe/XenStore.h b/OvmfPkg/XenBusDxe/XenStore.h
index c9d4c6509a..33bb647f66 100644
--- a/OvmfPkg/XenBusDxe/XenStore.h
+++ b/OvmfPkg/XenBusDxe/XenStore.h
@@ -209,6 +209,7 @@ XenStoreSPrint (
            indicating the type of write failure.
 **/
 XENSTORE_STATUS
+EFIAPI
 XenStoreVSPrint (
   IN CONST XENSTORE_TRANSACTION *Transaction,
   IN CONST CHAR8           *DirectoryPath,
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
index 76b6e297ef..6812e1078c 100644
--- a/OvmfPkg/XenBusDxe/XenStore.c
+++ b/OvmfPkg/XenBusDxe/XenStore.c
@@ -1304,6 +1304,7 @@ XenStoreTransactionEnd (
 }
 
 XENSTORE_STATUS
+EFIAPI
 XenStoreVSPrint (
   IN CONST XENSTORE_TRANSACTION *Transaction,
   IN CONST CHAR8           *DirectoryPath,
-- 
Anthony PERARD

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint
  2017-02-23 12:57 ` Gao, Liming
@ 2017-02-23 16:10   ` Laszlo Ersek
  0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2017-02-23 16:10 UTC (permalink / raw)
  To: Gao, Liming, Anthony PERARD; +Cc: edk2-devel@lists.01.org, Justen, Jordan L

On 02/23/17 13:57, Gao, Liming wrote:
> Reviewed-by: Liming Gao <liming.gao@intel.com>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Committed & pushed as c5c9e7e298ed.

Thanks!
Laszlo

> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Anthony PERARD
> Sent: Thursday, February 23, 2017 8:42 PM
> To: edk2-devel@lists.01.org
> Cc: Anthony PERARD <anthony.perard@citrix.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2] [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint
> 
> ... because this function use VA_COPY.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  OvmfPkg/XenBusDxe/XenStore.h | 1 +
>  OvmfPkg/XenBusDxe/XenStore.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/OvmfPkg/XenBusDxe/XenStore.h b/OvmfPkg/XenBusDxe/XenStore.h
> index c9d4c6509a..33bb647f66 100644
> --- a/OvmfPkg/XenBusDxe/XenStore.h
> +++ b/OvmfPkg/XenBusDxe/XenStore.h
> @@ -209,6 +209,7 @@ XenStoreSPrint (
>             indicating the type of write failure.
>  **/
>  XENSTORE_STATUS
> +EFIAPI
>  XenStoreVSPrint (
>    IN CONST XENSTORE_TRANSACTION *Transaction,
>    IN CONST CHAR8           *DirectoryPath,
> diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
> index 76b6e297ef..6812e1078c 100644
> --- a/OvmfPkg/XenBusDxe/XenStore.c
> +++ b/OvmfPkg/XenBusDxe/XenStore.c
> @@ -1304,6 +1304,7 @@ XenStoreTransactionEnd (
>  }
>  
>  XENSTORE_STATUS
> +EFIAPI
>  XenStoreVSPrint (
>    IN CONST XENSTORE_TRANSACTION *Transaction,
>    IN CONST CHAR8           *DirectoryPath,
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-23 16:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-23 12:42 [PATCH] OvmfPkg/XenBusDxe: Use EFIAPI for XenStoreVSPrint Anthony PERARD
2017-02-23 12:57 ` Gao, Liming
2017-02-23 16:10   ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox