public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, lersek@redhat.com
Subject: Re: [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD
Date: Mon, 27 Feb 2017 15:44:01 +0000	[thread overview]
Message-ID: <20170227154401.GG16034@bivouac.eciton.net> (raw)
In-Reply-To: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org>

On Fri, Feb 24, 2017 at 06:40:25PM +0000, Ard Biesheuvel wrote:
> This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with
> any remaining references to it in various platform .DSC files. It is
> no longer used now that we removed the virtual uncached pages protocol
> and the associated DebugUncachedMemoryAllocationLib library instance.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  ArmPkg/ArmPkg.dec                 | 1 -
>  ArmVirtPkg/ArmVirtQemu.dsc        | 5 -----
>  ArmVirtPkg/ArmVirtQemuKernel.dsc  | 5 -----
>  BeagleBoardPkg/BeagleBoardPkg.dsc | 5 -----
>  Omap35xxPkg/Omap35xxPkg.dsc       | 5 -----
>  5 files changed, 21 deletions(-)
> 
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index 4fd7a5be5158..c4b4da2f95bb 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -84,7 +84,6 @@ [PcdsFixedAtBuild.common]
>    # Using a FeaturePcd make a '(BOOLEAN) casting for its value which is not understood by the preprocessor.
>    gArmTokenSpaceGuid.PcdVFPEnabled|0|UINT32|0x00000024
>  
> -  gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000080000000|UINT64|0x00000002
>    # This PCD will free the unallocated buffers if their size reach this threshold.
>    # We set the default value to 512MB.
>    gArmTokenSpaceGuid.PcdArmFreeUncachedMemorySizeThreshold|0x20000000|UINT64|0x00000003
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 8fe3c3816961..00cdd7c20201 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common]
>    # Size of the region used by UEFI in permanent memory (Reserved 64MB)
>    gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
>  
> -  #
> -  # ARM Pcds
> -  #
> -  gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000
> -
>    ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec)
>    gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE
>  
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index aa40374745af..8354b13ddb1a 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common]
>    # Size of the region used by UEFI in permanent memory (Reserved 64MB)
>    gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
>  
> -  #
> -  # ARM Pcds
> -  #
> -  gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000
> -
>    ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec)
>    gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE
>  
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index a71a01ac7723..87879c33fcd9 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -368,11 +368,6 @@ [PcdsFixedAtBuild.common]
>    # Shell.
>    gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>  
> -  #
> -  # ARM Pcds
> -  #
> -  gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000
> -
>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10
>  
>    # GUID of the UEFI Shell
> diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc
> index ad7d9898c330..fc94ca7ed129 100644
> --- a/Omap35xxPkg/Omap35xxPkg.dsc
> +++ b/Omap35xxPkg/Omap35xxPkg.dsc
> @@ -162,11 +162,6 @@ [PcdsFixedAtBuild.common]
>    # OMAP Interrupt Controller
>    gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000
>  
> -  #
> -  # ARM Pcds
> -  #
> -  gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000
> -
>  ################################################################################
>  #
>  # Components Section - list of all EDK II Modules needed by this Platform
> -- 
> 2.7.4
> 


  parent reply	other threads:[~2017-02-27 15:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 18:40 [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD Ard Biesheuvel
2017-02-24 23:18 ` Laszlo Ersek
2017-02-27 15:44 ` Leif Lindholm [this message]
2017-02-27 16:18   ` Ard Biesheuvel
2017-02-27 16:25     ` Laszlo Ersek
2017-02-27 16:39       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227154401.GG16034@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox