From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 061BF82005 for ; Mon, 27 Feb 2017 07:44:05 -0800 (PST) Received: by mail-wm0-x236.google.com with SMTP id v77so65814103wmv.0 for ; Mon, 27 Feb 2017 07:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KFIiUskhsCC7wGg9D7aKnBJY9wwlujBnK2fHR+QZWtY=; b=SkXUe+A8zg0rUkfLsdWDr1dxqY3otbqNQ4BKXGgASpgj/Wy3gQoeivX+iEph0BxfPs kp5r+X26fqZGuL22hygaLAUfttW/LnrkfJOyr36HNnAh+5a8c4lFyN+opJ/JpnFDkXao if5M1hvI5CAaO6qhVU4n86e43oDzhaxsseEuc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KFIiUskhsCC7wGg9D7aKnBJY9wwlujBnK2fHR+QZWtY=; b=W7t42IYrPphffoV5rYTggT+iAH4TwvAn4lFxQqpurk5esBAu300beSTEnQvpu6OEel SHlCk0j7JKKMGsmATc5npaJ+HKDU56RHBMrQeBNbijFHk0SCSqcE4GsRaXLRtvQy9F6u 68QspNZvlYpv6rPUBoqyM3pJtpGvwQBfJ4vWEwThL55CwRsdIIPon80rF9Jbfn7MLycg A+EefRpZfEuCK2mZkgG8knREVzADDMyzX+zTVSD0iaDRZ/kI6a5QefRKsYh2dwpwIzot Sj+b6S4ttPydY9AZZoExUOrqXOVMXIxGa0AcyJK1mO41y7b4uBiwRFOARxfv9Pxyniq+ XkVw== X-Gm-Message-State: AMke39nv+Bim9A4WVIZfd2mGhc9ErxrWWMgpWNyeixoyVCGcTnbSue5r5sbpEQClkDz9xuyf X-Received: by 10.28.113.200 with SMTP id d69mr9882479wmi.10.1488210243576; Mon, 27 Feb 2017 07:44:03 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 36sm22767280wrk.57.2017.02.27.07.44.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2017 07:44:02 -0800 (PST) Date: Mon, 27 Feb 2017 15:44:01 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org, lersek@redhat.com Message-ID: <20170227154401.GG16034@bivouac.eciton.net> References: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <1487961625-16786-1-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 15:44:05 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 24, 2017 at 06:40:25PM +0000, Ard Biesheuvel wrote: > This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with > any remaining references to it in various platform .DSC files. It is > no longer used now that we removed the virtual uncached pages protocol > and the associated DebugUncachedMemoryAllocationLib library instance. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dec | 1 - > ArmVirtPkg/ArmVirtQemu.dsc | 5 ----- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > BeagleBoardPkg/BeagleBoardPkg.dsc | 5 ----- > Omap35xxPkg/Omap35xxPkg.dsc | 5 ----- > 5 files changed, 21 deletions(-) > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > index 4fd7a5be5158..c4b4da2f95bb 100644 > --- a/ArmPkg/ArmPkg.dec > +++ b/ArmPkg/ArmPkg.dec > @@ -84,7 +84,6 @@ [PcdsFixedAtBuild.common] > # Using a FeaturePcd make a '(BOOLEAN) casting for its value which is not understood by the preprocessor. > gArmTokenSpaceGuid.PcdVFPEnabled|0|UINT32|0x00000024 > > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000080000000|UINT64|0x00000002 > # This PCD will free the unallocated buffers if their size reach this threshold. > # We set the default value to 512MB. > gArmTokenSpaceGuid.PcdArmFreeUncachedMemorySizeThreshold|0x20000000|UINT64|0x00000003 > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 8fe3c3816961..00cdd7c20201 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common] > # Size of the region used by UEFI in permanent memory (Reserved 64MB) > gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec) > gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index aa40374745af..8354b13ddb1a 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -113,11 +113,6 @@ [PcdsFixedAtBuild.common] > # Size of the region used by UEFI in permanent memory (Reserved 64MB) > gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec) > gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index a71a01ac7723..87879c33fcd9 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -368,11 +368,6 @@ [PcdsFixedAtBuild.common] > # Shell. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 > > # GUID of the UEFI Shell > diff --git a/Omap35xxPkg/Omap35xxPkg.dsc b/Omap35xxPkg/Omap35xxPkg.dsc > index ad7d9898c330..fc94ca7ed129 100644 > --- a/Omap35xxPkg/Omap35xxPkg.dsc > +++ b/Omap35xxPkg/Omap35xxPkg.dsc > @@ -162,11 +162,6 @@ [PcdsFixedAtBuild.common] > # OMAP Interrupt Controller > gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress|0x48200000 > > - # > - # ARM Pcds > - # > - gArmTokenSpaceGuid.PcdArmUncachedMemoryMask|0x0000000040000000 > - > ################################################################################ > # > # Components Section - list of all EDK II Modules needed by this Platform > -- > 2.7.4 >