public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH 2/3] ArmPkg/UncachedMemoryAllocationLib: use CWG value to align pool allocations
Date: Tue, 7 Mar 2017 16:49:10 +0000	[thread overview]
Message-ID: <20170307164910.GV16034@bivouac.eciton.net> (raw)
In-Reply-To: <1488283992-32104-2-git-send-email-ard.biesheuvel@linaro.org>

On Tue, Feb 28, 2017 at 12:13:11PM +0000, Ard Biesheuvel wrote:
> Uncached pool allocations are aligned to the data cache line length under
> the assumption that this is sufficient to prevent cache maintenance from
> corrupting adjacent allocations. However, the value to use in such cases
> is architecturally called the Cache Writeback Granule (CWG), which is
> essentially the maximum Dcache line length rather than the minimum.
> 
> Note that this is mostly a cosmetical fix, given that the pool allocation
> is turned into a page allocation later, and rounded up accordingly.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c b/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> index cd13a7da92e0..0d8abad23433 100644
> --- a/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> +++ b/ArmPkg/Library/UncachedMemoryAllocationLib/UncachedMemoryAllocationLib.c
> @@ -545,7 +545,7 @@ UncachedInternalAllocatePool (
>    IN UINTN            AllocationSize
>    )
>  {
> -  UINTN CacheLineLength = ArmDataCacheLineLength ();
> +  UINTN CacheLineLength = ArmCacheWritebackGranule ();
>    return UncachedInternalAllocateAlignedPool (MemoryType, AllocationSize, CacheLineLength);
>  }
>  
> -- 
> 2.7.4
> 


  reply	other threads:[~2017-03-07 16:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 12:13 [PATCH 1/3] ArmPkg/UncachedMemoryAllocationLib: restore mapping attributes after free Ard Biesheuvel
2017-02-28 12:13 ` [PATCH 2/3] ArmPkg/UncachedMemoryAllocationLib: use CWG value to align pool allocations Ard Biesheuvel
2017-03-07 16:49   ` Leif Lindholm [this message]
2017-02-28 12:13 ` [PATCH 3/3] ArmPkg/UncachedMemoryAllocationLib: map uncached allocations non-executable Ard Biesheuvel
2017-03-07 16:49   ` Leif Lindholm
2017-03-07 16:42 ` [PATCH 1/3] ArmPkg/UncachedMemoryAllocationLib: restore mapping attributes after free Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170307164910.GV16034@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox