From: Leif Lindholm <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent
Date: Sat, 11 Mar 2017 10:26:40 +0000 [thread overview]
Message-ID: <20170311102640.GK16034@bivouac.eciton.net> (raw)
In-Reply-To: <5bdc3cc1-b292-8da3-f858-83c752016941@redhat.com>
On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
> >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I
> >> think the above check should be reworked to look for the FADT
> >> (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE) with code lifted
> >> from these helper functions. No driver outside of
> >> QemuFwCfgAcpiPlatformDxe will install the FADT. And, the FADT will
> >> always be part of QEMU's ACPI payload, if it generates one.
> >
> > OK, that would get things working again, I suppose. But do we want
> > neutered ACPI tables to be exposed at all, even if there is a DT in
> > that case to boot from?
>
> I think the neutered ACPI tables (on -no-acpi) should be fine. The
> upstream Linux guest will prefer DT if it is present;
Yes, but we've already determined that this situation is suboptimal,
which was what triggered this changeset to begin with.
/
Leif
next prev parent reply other threads:[~2017-03-11 10:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 16:03 [PATCH 0/3] ArmVirtQemu: make DT vs ACPI support mutually exclusive Ard Biesheuvel
2017-03-09 16:03 ` [PATCH 1/3] ArmVirtPkg/ArmVirtPL031FdtClientLib: unconditionally disable DT node Ard Biesheuvel
2017-03-09 16:25 ` Leif Lindholm
2017-03-09 16:51 ` Laszlo Ersek
2017-03-09 16:04 ` [PATCH 2/3] ArmVirtPkg/FdtClientDxe: install DT configuration table at ReadyToBoot Ard Biesheuvel
2017-03-09 16:31 ` Leif Lindholm
2017-03-09 16:55 ` Laszlo Ersek
2017-03-09 16:04 ` [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent Ard Biesheuvel
2017-03-09 16:33 ` Leif Lindholm
2017-03-09 17:07 ` Laszlo Ersek
2017-03-11 5:55 ` Laszlo Ersek
2017-03-11 6:57 ` Ard Biesheuvel
2017-03-11 7:38 ` Laszlo Ersek
2017-03-11 10:26 ` Leif Lindholm [this message]
2017-03-13 10:23 ` Ard Biesheuvel
2017-03-13 14:53 ` Laszlo Ersek
2017-03-13 14:59 ` Ard Biesheuvel
2017-03-13 20:39 ` Laszlo Ersek
2017-03-13 20:55 ` Laszlo Ersek
2017-03-13 20:55 ` Ard Biesheuvel
2017-03-11 7:21 ` Laszlo Ersek
2017-03-11 7:30 ` Ard Biesheuvel
2017-03-11 7:41 ` Laszlo Ersek
2017-03-11 9:19 ` Ard Biesheuvel
2017-03-11 10:06 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170311102640.GK16034@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox