From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 203D88030A for ; Sat, 11 Mar 2017 02:26:44 -0800 (PST) Received: by mail-wm0-x22c.google.com with SMTP id n11so10866013wma.1 for ; Sat, 11 Mar 2017 02:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2cDjf/wQnG+oM1ogycn3Dguxxvjrw75kVmsVLWnpJi4=; b=K0kmdgAUk+KbOmPsS8Sz3wJdmm5la1o/qDSCxkKrieLUcB33qUcmLv9KUFEnwdLp4k gnSGbGnzRTMUFBJ1jZt0ar9RyCXWq6SOGK3YC15WStGMoDT/zkEKgZtPP1beZU4uAxBG FkdcShFYZRr11b67+Ys9ohukcuUVOZXpEGKQs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2cDjf/wQnG+oM1ogycn3Dguxxvjrw75kVmsVLWnpJi4=; b=fJxupfeOuhJEqrp9H/GcJeHyCovn1h0jAeQxzIEavlUqv/oV0EVjtzIzkG6Rof1z8i Q3v5Dk2QJNvA6vaZ245Bn3VuFYVa2+Qky63s8XO5eONOHKLFYHrdcpwFhvlS2tYB+gSA TkQeuYju9SkAzoMmz8EeKlIRYhpmtEdEMcH2vgMpnnt53l4S+vb33K2NuNsPsjXfmiqp xtMRqWtp0JJCiygiJ5y6aOvTqTxys7DD3hV+LDbyq2Dm7R7pOPgxvr7KyLix6KOAdJTF el4JXLgAurbUTL3X8H6WJYZdlHP5iVxWuaBckN/Q7M5EmaF6tQQNHtJ6RjkukqsyaEWl 0Zaw== X-Gm-Message-State: AFeK/H0zc/yWm01EFycYd1LkH5nX8P3wO1kaAMxEQGu9lipUP/VgtM/h14XQA+UE86Syj7Vo X-Received: by 10.28.91.82 with SMTP id p79mr2479700wmb.130.1489228002615; Sat, 11 Mar 2017 02:26:42 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e6sm16832151wrc.30.2017.03.11.02.26.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 02:26:41 -0800 (PST) Date: Sat, 11 Mar 2017 10:26:40 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , Andrew Jones Message-ID: <20170311102640.GK16034@bivouac.eciton.net> References: <1489075441-23745-1-git-send-email-ard.biesheuvel@linaro.org> <1489075441-23745-4-git-send-email-ard.biesheuvel@linaro.org> <19f70c3d-4220-957b-24cd-bd2d41e45909@redhat.com> <5bdc3cc1-b292-8da3-f858-83c752016941@redhat.com> MIME-Version: 1.0 In-Reply-To: <5bdc3cc1-b292-8da3-f858-83c752016941@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 3/3] ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 10:26:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote: > >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I > >> think the above check should be reworked to look for the FADT > >> (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE) with code lifted > >> from these helper functions. No driver outside of > >> QemuFwCfgAcpiPlatformDxe will install the FADT. And, the FADT will > >> always be part of QEMU's ACPI payload, if it generates one. > > > > OK, that would get things working again, I suppose. But do we want > > neutered ACPI tables to be exposed at all, even if there is a DT in > > that case to boot from? > > I think the neutered ACPI tables (on -no-acpi) should be fine. The > upstream Linux guest will prefer DT if it is present; Yes, but we've already determined that this situation is suboptimal, which was what triggered this changeset to begin with. / Leif