From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 44429803D1 for ; Wed, 22 Mar 2017 06:22:25 -0700 (PDT) Received: by mail-wr0-x230.google.com with SMTP id g10so129624061wrg.2 for ; Wed, 22 Mar 2017 06:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EpIdnpAZLGsl29ukBvcADI0X4JM7pKqCjLYlBl6udbQ=; b=kHIMIq1H1kpIql86rYFuFrACmNpfra18mlPS06XzA69jMdDl9ANLNF7Np33Wc43rFN tg0tbtyGTl8yvLp/SSFU1mNObuMSEPRKvI4/B5hfp56us6mb4eK47SY+ryVNjJ4oZeBE OIZVFff6KqZxA3hzVM7tgvj3OoA8XdnbzMU+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EpIdnpAZLGsl29ukBvcADI0X4JM7pKqCjLYlBl6udbQ=; b=LoiQyb0509lAr2Krv6iFKwKx6UUPXEK0aAKDsWR4ruUWLcg6CpjAnuopysBYjlD9jh yhn+eikEW3J0uxVS6W+nK29CJJYyxwCKc7d/mJIOuZpoBcjVhzB0B5X3jGPCEI5HCt/4 eg2xeS+JtGqRU9A2IOoeBe7NuQ1FrsVQd4RMrNonjjFIehuaJyq8dDgyjP+Bx3TNagoN 7iD+N8ENBaq5QZxYNPWy5y4Me85yxW2cFDbOyghGG1FqLqB72l+9BWu8RE2e8IFIvplD arom/1t3/XB1alo9eQc5Q1ApEOmVeWiqsMESt71kkTmP1eOGjUkweGqzh8aSc7dE1qu6 4TFQ== X-Gm-Message-State: AFeK/H1ah4pRGQJ1xeZv590xmSxzpOUX6VBz1g4pKE1R+7ra2dcocLqrI9Zg0MoSxmmJJ0j9 X-Received: by 10.223.178.239 with SMTP id g102mr34108381wrd.126.1490188943865; Wed, 22 Mar 2017 06:22:23 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u41sm1838501wrc.24.2017.03.22.06.22.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 06:22:22 -0700 (PDT) Date: Wed, 22 Mar 2017 13:22:21 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Ryan Harkin Message-ID: <20170322132221.GA16034@bivouac.eciton.net> References: <1490042145-19509-1-git-send-email-ard.biesheuvel@linaro.org> <1490042145-19509-3-git-send-email-ard.biesheuvel@linaro.org> <20170322125308.GT16034@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 2/3] ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 13:22:25 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 22, 2017 at 01:16:26PM +0000, Ard Biesheuvel wrote: > On 22 March 2017 at 12:53, Leif Lindholm wrote: > > On Mon, Mar 20, 2017 at 08:35:44PM +0000, Ard Biesheuvel wrote: > >> Instead of indirecting the reference to the Shell binary via a PCD > >> that is defined in IntelFrameworkModulePkg, and which invariably > >> gets set to the same value by all users of this library, move the > >> reference into the code, and drop the reference to the PCD entirely. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Ard Biesheuvel > >> --- > >> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 7 +++++-- > >> ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 - > >> 2 files changed, 5 insertions(+), 3 deletions(-) > >> > >> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > >> index cc5a4d1ff9b3..d479c28775fb 100644 > >> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > >> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c > >> @@ -33,6 +33,9 @@ > >> > >> #define DP_NODE_LEN(Type) { (UINT8)sizeof (Type), (UINT8)(sizeof (Type) >> 8) } > >> > >> +STATIC CONST EFI_GUID mUefiShellFileGuid = { > >> + 0x7C04A583, 0x9E3E, 0x4f1c, { 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } > >> +}; > > > > Surely this ought to be defined in a shared header file rather than > > replicated across the tree? (And yes, used in QuarkPlatformPkg as > > well.) > > > > Otherwise, looks like a good change. > > > > Yes, it would make the most sense to add this to the [Guid] section of > ShellPkg itself. I will propose it as a separate series, and replace > the quark reference as well Since I'm about to go offline - with that change implemented: Reviewed-by: Leif Lindholm