public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jeff Fan <jeff.fan@intel.com>
To: edk2-devel@lists.01.org
Cc: Feng Tian <feng.tian@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>
Subject: [PATCH 2/5] UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type
Date: Mon, 27 Mar 2017 11:02:01 +0800	[thread overview]
Message-ID: <20170327030204.13572-3-jeff.fan@intel.com> (raw)
In-Reply-To: <20170327030204.13572-1-jeff.fan@intel.com>

Using one specific name for global variable to save MP services protocol
pointer.

Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
 .../Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index c49f556..74c658a 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -19,7 +19,7 @@
 #include "RegisterCpuFeatures.h"
 
 CPU_FEATURES_DATA          mCpuFeaturesData = {0};
-static EFI_MP_SERVICES_PROTOCOL   *mMpServices = NULL;
+EFI_MP_SERVICES_PROTOCOL   *mCpuFeaturesMpServices = NULL;
 
 /**
   Worker function to get CPU_FEATURES_DATA pointer.
@@ -46,20 +46,20 @@ GetMpProtocol (
 {
   EFI_STATUS             Status;
 
-  if (mMpServices == NULL) {
+  if (mCpuFeaturesMpServices == NULL) {
     //
     // Get MP Services Protocol
     //
     Status = gBS->LocateProtocol (
                   &gEfiMpServiceProtocolGuid,
                   NULL,
-                  (VOID **)&mMpServices
+                  (VOID **)&mCpuFeaturesMpServices
                   );
     ASSERT_EFI_ERROR (Status);
   }
 
-  ASSERT (mMpServices != NULL);
-  return mMpServices;
+  ASSERT (mCpuFeaturesMpServices != NULL);
+  return mCpuFeaturesMpServices;
 }
 
 /**
-- 
2.9.3.windows.2



  parent reply	other threads:[~2017-03-27  3:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
2017-03-27  3:02 ` [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues Jeff Fan
2017-03-27  3:02 ` Jeff Fan [this message]
2017-03-27  3:02 ` [PATCH 3/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments Jeff Fan
2017-03-27  3:02 ` [PATCH 4/5] UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value Jeff Fan
2017-03-27  3:02 ` [PATCH 5/5] UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file Jeff Fan
2017-03-27  3:04 ` [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Tian, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327030204.13572-3-jeff.fan@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox