* [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues.
@ 2017-03-27 3:01 Jeff Fan
2017-03-27 3:02 ` [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues Jeff Fan
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Jeff Fan @ 2017-03-27 3:01 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Michael Kinney
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Jeff Fan (5):
UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues
UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type
UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments
UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value
UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file
UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf | 4 +-
UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf | 2 +-
.../Include/Library/RegisterCpuFeaturesLib.h | 60 +++++++++++----------
.../CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 8 +--
.../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
.../DxeRegisterCpuFeaturesLib.c | 12 ++---
.../PeiRegisterCpuFeaturesLib.c | 2 +-
.../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +-
.../RegisterCpuFeaturesLib.c | 62 +++++++++++-----------
UefiCpuPkg/UefiCpuPkg.dec | 12 ++---
UefiCpuPkg/UefiCpuPkg.uni | 31 +++++++++++
11 files changed, 116 insertions(+), 81 deletions(-)
--
2.9.3.windows.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
@ 2017-03-27 3:02 ` Jeff Fan
2017-03-27 3:02 ` [PATCH 2/5] UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type Jeff Fan
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jeff Fan @ 2017-03-27 3:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Michael Kinney
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
.../Include/Library/RegisterCpuFeaturesLib.h | 60 +++++++++++----------
.../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
.../DxeRegisterCpuFeaturesLib.c | 2 +-
.../PeiRegisterCpuFeaturesLib.c | 2 +-
.../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +-
.../RegisterCpuFeaturesLib.c | 62 +++++++++++-----------
6 files changed, 67 insertions(+), 63 deletions(-)
diff --git a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
index 3fb8209..81a1f4b 100644
--- a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
+++ b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
@@ -257,35 +257,37 @@ RETURN_STATUS
/**
Registers a CPU Feature.
- @param GetConfigDataFunc CPU feature get configuration data function. This
- is an optional parameter that may be NULL. If NULL,
- then the most recently registered function for the
- CPU feature is used. If no functions are registered
- for a CPU feature, then the CPU configuration data
- for the registered feature is NULL.
- @param SupportFunc CPU feature support function. This is an optional
- parameter that may be NULL. If NULL, then the most
- recently registered function for the CPU feature is
- used. If no functions are registered for a CPU
- feature, then the CPU feature is assumed to be
- supported by all CPUs.
- @param InitializeFunc CPU feature initialize function. This is an optional
- parameter that may be NULL. If NULL, then the most
- recently registered function for the CPU feature is
- used. If no functions are registered for a CPU
- feature, then the CPU feature initialization is
- skipped.
- @param ... Variable argument list of UINT32 CPU feature value.
- Values with no modifiers are the features provided
- by the registered functions.
- Values with CPU_FEATURE_BEFORE modifier are features
- that must be initialized after the features provided
- by the registered functions are used.
- Values with CPU_FEATURE_AFTER modifier are features
- that must be initialized before the features provided
- by the registered functions are used.
- The last argument in this variable argument list must
- always be CPU_FEATURE_END.
+ @param[in] FeatureName A Null-terminated Ascii string indicates CPU feature
+ name.
+ @param[in] GetConfigDataFunc CPU feature get configuration data function. This
+ is an optional parameter that may be NULL. If NULL,
+ then the most recently registered function for the
+ CPU feature is used. If no functions are registered
+ for a CPU feature, then the CPU configuration data
+ for the registered feature is NULL.
+ @param[in] SupportFunc CPU feature support function. This is an optional
+ parameter that may be NULL. If NULL, then the most
+ recently registered function for the CPU feature is
+ used. If no functions are registered for a CPU
+ feature, then the CPU feature is assumed to be
+ supported by all CPUs.
+ @param[in] InitializeFunc CPU feature initialize function. This is an optional
+ parameter that may be NULL. If NULL, then the most
+ recently registered function for the CPU feature is
+ used. If no functions are registered for a CPU
+ feature, then the CPU feature initialization is
+ skipped.
+ @param[in] ... Variable argument list of UINT32 CPU feature value.
+ Values with no modifiers are the features provided
+ by the registered functions.
+ Values with CPU_FEATURE_BEFORE modifier are features
+ that must be initialized after the features provided
+ by the registered functions are used.
+ Values with CPU_FEATURE_AFTER modifier are features
+ that must be initialized before the features provided
+ by the registered functions are used.
+ The last argument in this variable argument list must
+ always be CPU_FEATURE_END.
@retval RETURN_SUCCESS The CPU feature was successfully registered.
@retval RETURN_OUT_OF_RESOURCES There are not enough resources to register
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
index cd689af..e0fe38c 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
@@ -18,7 +18,7 @@
Worker function to save PcdCpuFeaturesCapability.
@param[in] SupportedFeatureMask The pointer to CPU feature bits mask buffer
-*/
+**/
VOID
SetCapabilityPcd (
IN UINT8 *SupportedFeatureMask
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index b5a1de7..c49f556 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -168,7 +168,7 @@ SwitchNewBsp (
/**
Worker function to retrieve the number of logical processor in the platform.
- @param[out] NumberOfProcessors Pointer to the total number of logical
+ @param[out] NumberOfCpus Pointer to the total number of logical
processors in the system, including the BSP
and disabled APs.
@param[out] NumberOfEnabledProcessors Pointer to the number of enabled logical
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index 12a516a..8fde742 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -219,7 +219,7 @@ SwitchNewBsp (
/**
Worker function to retrieve the number of logical processor in the platform.
- @param[out] NumberOfProcessors Pointer to the total number of logical
+ @param[out] NumberOfCpus Pointer to the total number of logical
processors in the system, including the BSP
and disabled APs.
@param[out] NumberOfEnabledProcessors Pointer to the number of enabled logical
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
index 2b136b6..11f8eb7 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h
@@ -147,7 +147,7 @@ StartupAPsWorker (
/**
Worker function to retrieve the number of logical processor in the platform.
- @param[out] NumberOfProcessors Pointer to the total number of logical
+ @param[out] NumberOfCpus Pointer to the total number of logical
processors in the system, including the BSP
and disabled APs.
@param[out] NumberOfEnabledProcessors Pointer to the number of enabled logical
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
index 3fec2e6..7ef0155 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
@@ -240,7 +240,7 @@ CheckCpuFeaturesDependency (
/**
Worker function to register CPU Feature.
- @param[in] CpuFeature Pointer to CPU feature entry
+ @param[in] CpuFeature Pointer to CPU feature entry
@retval RETURN_SUCCESS The CPU feature was successfully registered.
@retval RETURN_OUT_OF_RESOURCES There are not enough resources to register
@@ -372,35 +372,37 @@ SetCpuFeaturesBitMask (
/**
Registers a CPU Feature.
- @param GetConfigDataFunc CPU feature get configuration data function. This
- is an optional parameter that may be NULL. If NULL,
- then the most recently registered function for the
- CPU feature is used. If no functions are registered
- for a CPU feature, then the CPU configuration data
- for the registered feature is NULL.
- @param SupportFunc CPU feature support function. This is an optional
- parameter that may be NULL. If NULL, then the most
- recently registered function for the CPU feature is
- used. If no functions are registered for a CPU
- feature, then the CPU feature is assumed to be
- supported by all CPUs.
- @param InitializeFunc CPU feature initialize function. This is an optional
- parameter that may be NULL. If NULL, then the most
- recently registered function for the CPU feature is
- used. If no functions are registered for a CPU
- feature, then the CPU feature initialization is
- skipped.
- @param ... Variable argument list of UINT32 CPU feature value.
- Values with no modifiers are the features provided
- by the registered functions.
- Values with CPU_FEATURE_BEFORE modifier are features
- that must be initialized after the features provided
- by the registered functions are used.
- Values with CPU_FEATURE_AFTER modifier are features
- that must be initialized before the features provided
- by the registered functions are used.
- The last argument in this variable argument list must
- always be CPU_FEATURE_END.
+ @param[in] FeatureName A Null-terminated Ascii string indicates CPU feature
+ name.
+ @param[in] GetConfigDataFunc CPU feature get configuration data function. This
+ is an optional parameter that may be NULL. If NULL,
+ then the most recently registered function for the
+ CPU feature is used. If no functions are registered
+ for a CPU feature, then the CPU configuration data
+ for the registered feature is NULL.
+ @param[in] SupportFunc CPU feature support function. This is an optional
+ parameter that may be NULL. If NULL, then the most
+ recently registered function for the CPU feature is
+ used. If no functions are registered for a CPU
+ feature, then the CPU feature is assumed to be
+ supported by all CPUs.
+ @param[in] InitializeFunc CPU feature initialize function. This is an optional
+ parameter that may be NULL. If NULL, then the most
+ recently registered function for the CPU feature is
+ used. If no functions are registered for a CPU
+ feature, then the CPU feature initialization is
+ skipped.
+ @param[in] ... Variable argument list of UINT32 CPU feature value.
+ Values with no modifiers are the features provided
+ by the registered functions.
+ Values with CPU_FEATURE_BEFORE modifier are features
+ that must be initialized after the features provided
+ by the registered functions are used.
+ Values with CPU_FEATURE_AFTER modifier are features
+ that must be initialized before the features provided
+ by the registered functions are used.
+ The last argument in this variable argument list must
+ always be CPU_FEATURE_END.
@retval RETURN_SUCCESS The CPU feature was successfully registered.
@retval RETURN_OUT_OF_RESOURCES There are not enough resources to register
--
2.9.3.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/5] UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
2017-03-27 3:02 ` [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues Jeff Fan
@ 2017-03-27 3:02 ` Jeff Fan
2017-03-27 3:02 ` [PATCH 3/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments Jeff Fan
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jeff Fan @ 2017-03-27 3:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Michael Kinney
Using one specific name for global variable to save MP services protocol
pointer.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
.../Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
index c49f556..74c658a 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c
@@ -19,7 +19,7 @@
#include "RegisterCpuFeatures.h"
CPU_FEATURES_DATA mCpuFeaturesData = {0};
-static EFI_MP_SERVICES_PROTOCOL *mMpServices = NULL;
+EFI_MP_SERVICES_PROTOCOL *mCpuFeaturesMpServices = NULL;
/**
Worker function to get CPU_FEATURES_DATA pointer.
@@ -46,20 +46,20 @@ GetMpProtocol (
{
EFI_STATUS Status;
- if (mMpServices == NULL) {
+ if (mCpuFeaturesMpServices == NULL) {
//
// Get MP Services Protocol
//
Status = gBS->LocateProtocol (
&gEfiMpServiceProtocolGuid,
NULL,
- (VOID **)&mMpServices
+ (VOID **)&mCpuFeaturesMpServices
);
ASSERT_EFI_ERROR (Status);
}
- ASSERT (mMpServices != NULL);
- return mMpServices;
+ ASSERT (mCpuFeaturesMpServices != NULL);
+ return mCpuFeaturesMpServices;
}
/**
--
2.9.3.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
2017-03-27 3:02 ` [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues Jeff Fan
2017-03-27 3:02 ` [PATCH 2/5] UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type Jeff Fan
@ 2017-03-27 3:02 ` Jeff Fan
2017-03-27 3:02 ` [PATCH 4/5] UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value Jeff Fan
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jeff Fan @ 2017-03-27 3:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Michael Kinney
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf | 4 ++--
UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf | 2 +-
UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf b/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf
index 5a3e4f0..dee44e6 100644
--- a/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf
+++ b/UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf
@@ -38,10 +38,10 @@
CpuFeaturesDxe.c
[Guids]
- gEdkiiCpuFeaturesInitDoneGuid ## PRODUCES
+ gEdkiiCpuFeaturesInitDoneGuid ## PRODUCES ## UNDEFINED # protocol GUID installed
[Protocols]
- gEfiSmmConfigurationProtocolGuid ## SOMETIME_CONSUMES
+ gEfiSmmConfigurationProtocolGuid ## NOTIFY
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitAfterSmmRelocation ## CONSUMES
diff --git a/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf b/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf
index e306bb2..2fb84b1 100644
--- a/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf
+++ b/UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf
@@ -37,7 +37,7 @@
CpuFeaturesPei.c
[Guids]
- gEdkiiCpuFeaturesInitDoneGuid ## PRODUCES
+ gEdkiiCpuFeaturesInitDoneGuid ## PRODUCES ## UNDEFINED # PPI GUID installed
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitOnS3Resume ## CONSUMES
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
index 7287d4e..056b776 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
@@ -62,7 +62,7 @@
LocalApicLib
[Pcd]
- gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport # CONSUMES
- gUefiCpuPkgTokenSpaceGuid.PcdCpuClockModulationDutyCycle # SOMETIME_CONSUMES
- gUefiCpuPkgTokenSpaceGuid.PcdIsPowerOnReset # SOMETIME_CONSUMES
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport ## CONSUMES
+ gUefiCpuPkgTokenSpaceGuid.PcdCpuClockModulationDutyCycle ## SOMETIMES_CONSUMES
+ gUefiCpuPkgTokenSpaceGuid.PcdIsPowerOnReset ## SOMETIMES_CONSUMES
--
2.9.3.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/5] UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
` (2 preceding siblings ...)
2017-03-27 3:02 ` [PATCH 3/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments Jeff Fan
@ 2017-03-27 3:02 ` Jeff Fan
2017-03-27 3:02 ` [PATCH 5/5] UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file Jeff Fan
2017-03-27 3:04 ` [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Tian, Feng
5 siblings, 0 replies; 7+ messages in thread
From: Jeff Fan @ 2017-03-27 3:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Michael Kinney
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
index 056b776..4358196 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf
@@ -19,7 +19,7 @@
INF_VERSION = 0x00010005
BASE_NAME = CpuCommonFeaturesLib
MODULE_UNI_FILE = CpuCommonFeaturesLib.uni
- FILE_GUID = 387A2490-81FC-4E7C-8E0A-3E58C30FCD0B
+ FILE_GUID = 6D69F79F-9535-4893-9DD7-93929898252C
MODULE_TYPE = BASE
VERSION_STRING = 1.0
LIBRARY_CLASS = NULL
--
2.9.3.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/5] UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
` (3 preceding siblings ...)
2017-03-27 3:02 ` [PATCH 4/5] UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value Jeff Fan
@ 2017-03-27 3:02 ` Jeff Fan
2017-03-27 3:04 ` [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Tian, Feng
5 siblings, 0 replies; 7+ messages in thread
From: Jeff Fan @ 2017-03-27 3:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Feng Tian, Michael Kinney
Correct PCD declaration comments and add new PCDs in UNI file.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
UefiCpuPkg/UefiCpuPkg.dec | 12 ++++++------
UefiCpuPkg/UefiCpuPkg.uni | 31 +++++++++++++++++++++++++++++++
2 files changed, 37 insertions(+), 6 deletions(-)
diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
index 4a679bd..e87f103 100644
--- a/UefiCpuPkg/UefiCpuPkg.dec
+++ b/UefiCpuPkg/UefiCpuPkg.dec
@@ -192,16 +192,16 @@
# @Prompt MSEG size.
gUefiCpuPkgTokenSpaceGuid.PcdCpuMsegSize|0x200000|UINT32|0x32132112
- ## Specifies the supported CPU features bit in array
- # @Prompt Supported CPU features
+ ## Specifies the supported CPU features bit in array.
+ # @Prompt Supported CPU features.
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSupport|{0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF}|VOID*|0x00000016
- ## Specifies if CPU features will be initialized after SMM relocation
- # @Prompt if CPU features will be initialized after SMM relocation
+ ## Specifies if CPU features will be initialized after SMM relocation.
+ # @Prompt If CPU features will be initialized after SMM relocation.
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitAfterSmmRelocation|FALSE|BOOLEAN|0x0000001C
- ## Specifies if CPU features will be initialized during S3 resume
- # @Prompt if CPU features will be initialized during S3 resume
+ ## Specifies if CPU features will be initialized during S3 resume.
+ # @Prompt If CPU features will be initialized during S3 resume.
gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitOnS3Resume|FALSE|BOOLEAN|0x0000001D
[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni
index f4dd339..cd0ecab 100644
--- a/UefiCpuPkg/UefiCpuPkg.uni
+++ b/UefiCpuPkg/UefiCpuPkg.uni
@@ -163,3 +163,34 @@
#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuMsegSize_HELP #language en-US "Specifies buffer size in bytes of MSEG. The value should be a multiple of 4KB."
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSupport_PROMPT #language en-US "Supported CPU features."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSupport_HELP #language en-US "Specifies the supported CPU features bit in array."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitAfterSmmRelocation_PROMPT #language en-US "If CPU features will be initialized after SMM relocation."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitAfterSmmRelocation_HELP #language en-US "Specifies if CPU features will be initialized after SMM relocation."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitOnS3Resume_PROMPT #language en-US "If CPU features will be initialized during S3 resume."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesInitOnS3Resume_HELP #language en-US "Specifies if CPU features will be initialized during S3 resume."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesUserConfiguration_PROMPT #language en-US "User settings for enabling/disabling processor features."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesUserConfiguration_HELP #language en-US "Specifies user's desired settings for enabling/disabling processor features."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuClockModulationDutyCycle_PROMPT #language en-US "The encoded values for target duty cycle modulation."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuClockModulationDutyCycle_HELP #language en-US "Specifies the On-demand clock modulation duty cycle when ACPI feature is enabled."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_PROMPT #language en-US "Current boot is a power-on reset."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdIsPowerOnReset_HELP #language en-US "Indicates if the current boot is a power-on reset."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_PROMPT #language en-US "Processor feature capabilities."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesCapability_HELP #language en-US "Indicates processor feature capabilities, each bit corresponding to a specific feature."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSetting_PROMPT #language en-US "Actual processor feature settings."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuFeaturesSetting_HELP #language en-US "Specifies actual settings for processor features, each bit corresponding to a specific feature."
--
2.9.3.windows.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues.
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
` (4 preceding siblings ...)
2017-03-27 3:02 ` [PATCH 5/5] UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file Jeff Fan
@ 2017-03-27 3:04 ` Tian, Feng
5 siblings, 0 replies; 7+ messages in thread
From: Tian, Feng @ 2017-03-27 3:04 UTC (permalink / raw)
To: Fan, Jeff, edk2-devel@lists.01.org; +Cc: Kinney, Michael D, Tian, Feng
Series Reviewed-by: Feng Tian <feng.tian@intel.com>
Thanks
Feng
-----Original Message-----
From: Fan, Jeff
Sent: Monday, March 27, 2017 11:02 AM
To: edk2-devel@lists.01.org
Cc: Tian, Feng <feng.tian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues.
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Jeff Fan (5):
UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues
UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type
UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments
UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value
UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file
UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf | 4 +-
UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf | 2 +-
.../Include/Library/RegisterCpuFeaturesLib.h | 60 +++++++++++----------
.../CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf | 8 +-- .../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
.../DxeRegisterCpuFeaturesLib.c | 12 ++---
.../PeiRegisterCpuFeaturesLib.c | 2 +-
.../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +-
.../RegisterCpuFeaturesLib.c | 62 +++++++++++-----------
UefiCpuPkg/UefiCpuPkg.dec | 12 ++---
UefiCpuPkg/UefiCpuPkg.uni | 31 +++++++++++
11 files changed, 116 insertions(+), 81 deletions(-)
--
2.9.3.windows.2
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-27 3:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-27 3:01 [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Jeff Fan
2017-03-27 3:02 ` [PATCH 1/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix the function header issues Jeff Fan
2017-03-27 3:02 ` [PATCH 2/5] UefiCpuPkg/RegisterCpuFeaturesLib: Remove static type Jeff Fan
2017-03-27 3:02 ` [PATCH 3/5] UefiCpuPkg/RegisterCpuFeaturesLib: Fix meta data comments Jeff Fan
2017-03-27 3:02 ` [PATCH 4/5] UefiCpuPkg/CpuCommonFeaturesLib: Generate new INF GUID value Jeff Fan
2017-03-27 3:02 ` [PATCH 5/5] UefiCpuPkg: Add new PCDs PROMPT/HELP string in UNI file Jeff Fan
2017-03-27 3:04 ` [PATCH 0/5] [UefiCpuPkg/CpuFeatures] Fix some comments and meta data issues Tian, Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox