Re: [PATCH v2 09/11] CryptoPkg: Update HMAC Wrapper with opaque HMAC_CTX object.

[Gary Lin <glin@suse.com>]

On Thu, Mar 23, 2017 at 07:37:08PM +0100, Laszlo Ersek wrote:
> On 03/23/17 14:19, Qin Long wrote:
> > OpenSSL-1.1.xx makes most data structures opaque.
> > This patch updated HMAC Wrapper implementation with opaque
> > HMAC_CTX object.
> > The HmacXXGetContextSize() is marked as deprecated, and updated
> > to use the fixed HMAC_CTX size, which is just kept for compatibility.
> > New APIs (HmacXXNew(), HmacXXFree()) were added  as the recommended
> > HMAC_CTX usage interfaces for HMAC-XXXX operations.
> > 
> > Cc: Ting Ye <ting.ye@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Gary Lin <glin@suse.com>
> > Cc: Ronald Cron <ronald.cron@arm.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Qin Long <qin.long@intel.com>
> > ---
> >  CryptoPkg/Include/Library/BaseCryptLib.h           | 93 +++++++++++++++++++++-
> >  CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 77 +++++++++++++++---
> >  .../Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c   | 40 +++++++++-
> >  .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c      | 75 +++++++++++++++--
> >  .../Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c  | 40 +++++++++-
> >  .../Library/BaseCryptLib/Hmac/CryptHmacSha256.c    | 75 +++++++++++++++--
> >  .../BaseCryptLib/Hmac/CryptHmacSha256Null.c        | 40 +++++++++-
> >  7 files changed, 411 insertions(+), 29 deletions(-)
> 
> I think the code modified in this patch is exercised as part of Secure
> Boot image verification (SHA1, SHA256), so:
> 
Actually, Secure Boot has nothing to do with HMAC, and the current HMAC
user is only CryptoPkg/Application/Cryptest/HmacVerify.c
The hash functions come from CryptoPkg/Library/BaseCryptLib/Hash/.

Gary Lin

> Tested-by: Laszlo Ersek <lersek@redhat.com>
> 
> (Tested as described in
> <http://mid.mail-archive.com/4410fa53-b0e4-d64a-7b95-8a430a4c7b06@redhat.com>.)
> 
> Thanks!
> Laszlo
>