public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution
@ 2017-03-31  9:46 Ard Biesheuvel
  2017-03-31 10:11 ` Laszlo Ersek
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-03-31  9:46 UTC (permalink / raw)
  To: edk2-devel, leif.lindholm; +Cc: lersek, Ard Biesheuvel

Recent changes to the PlatformBootManagerLib implementation in ArmPkg
require its users to define a resolution for BootLogoLib. So add this
missing resolution to Beagle.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
index 96c7d91cee73..90d6af444df0 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -131,6 +131,7 @@ [LibraryClasses.common]
 
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
   CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
 
   # UiApp dependencies
-- 
2.9.3



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution
  2017-03-31  9:46 [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution Ard Biesheuvel
@ 2017-03-31 10:11 ` Laszlo Ersek
  2017-03-31 10:44   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2017-03-31 10:11 UTC (permalink / raw)
  To: Ard Biesheuvel, edk2-devel, leif.lindholm

On 03/31/17 11:46, Ard Biesheuvel wrote:
> Recent changes to the PlatformBootManagerLib implementation in ArmPkg
> require its users to define a resolution for BootLogoLib. So add this
> missing resolution to Beagle.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 96c7d91cee73..90d6af444df0 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -131,6 +131,7 @@ [LibraryClasses.common]
>  
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>    PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
>    CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
>  
>    # UiApp dependencies
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution
  2017-03-31 10:11 ` Laszlo Ersek
@ 2017-03-31 10:44   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-03-31 10:44 UTC (permalink / raw)
  To: Laszlo Ersek; +Cc: edk2-devel@lists.01.org, Leif Lindholm

On 31 March 2017 at 11:11, Laszlo Ersek <lersek@redhat.com> wrote:
> On 03/31/17 11:46, Ard Biesheuvel wrote:
>> Recent changes to the PlatformBootManagerLib implementation in ArmPkg
>> require its users to define a resolution for BootLogoLib. So add this
>> missing resolution to Beagle.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
>> index 96c7d91cee73..90d6af444df0 100644
>> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
>> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
>> @@ -131,6 +131,7 @@ [LibraryClasses.common]
>>
>>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>>    PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>> +  BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
>>    CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
>>
>>    # UiApp dependencies
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks, pushed as d180dea0a81f


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-31 10:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-31  9:46 [PATCH] BeagleBoardPkg: add missing BootLogoLib resolution Ard Biesheuvel
2017-03-31 10:11 ` Laszlo Ersek
2017-03-31 10:44   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox