public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org, leif.lindholm@linaro.org,
	ryan.harkin@linaro.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v2 9/9] ArmPlatformPkg/ArmJunoDxe: remove FDT handling
Date: Fri, 31 Mar 2017 15:14:34 +0100	[thread overview]
Message-ID: <20170331141434.20810-10-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20170331141434.20810-1-ard.biesheuvel@linaro.org>

Change ArmJunoDxe to be compatible with the new DtPlatformDxe driver,
which simply selects one of three embedded DTB binaries based on the
current hardware. It also introduces a config screen in the UEFI setup
menu that allows either ACPI or DT to be selected (but not both)

For this module, it simply means we remove all FDT handling, given that
this is now the job of another module.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c   | 26 +-------------------
 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf |  1 -
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
index 2b3cca944cf1..84e820fe07a0 100644
--- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
+++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
@@ -16,7 +16,6 @@
 #include <ArmPlatform.h>
 
 #include <IndustryStandard/Pci.h>
-#include <Protocol/DevicePathFromText.h>
 #include <Protocol/PciIo.h>
 #include <Protocol/PciRootBridgeIo.h>
 
@@ -414,9 +413,6 @@ ArmJunoEntryPoint (
 {
   EFI_STATUS            Status;
   EFI_PHYSICAL_ADDRESS  HypBase;
-  CHAR16                *TextDevicePath;
-  UINTN                 TextDevicePathSize;
-  VOID                  *Buffer;
   UINT32                JunoRevision;
   EFI_EVENT             EndOfDxeEvent;
 
@@ -530,25 +526,5 @@ ArmJunoEntryPoint (
         );
   }
 
-  //
-  // Set up the device path to the FDT.
-  //
-  TextDevicePath = (CHAR16*)FixedPcdGetPtr (PcdJunoFdtDevicePath);
-  if (TextDevicePath != NULL) {
-    TextDevicePathSize = StrSize (TextDevicePath);
-    Buffer = PcdSetPtr (PcdFdtDevicePaths, &TextDevicePathSize, TextDevicePath);
-    Status = (Buffer != NULL) ? EFI_SUCCESS : EFI_BUFFER_TOO_SMALL;
-  } else {
-    Status = EFI_NOT_FOUND;
-  }
-
-  if (EFI_ERROR (Status)) {
-    DEBUG (
-      (EFI_D_ERROR,
-      "ArmJunoDxe: Setting of FDT device path in PcdFdtDevicePaths failed - %r\n", Status)
-      );
-    return Status;
-  }
-
-  return Status;
+  return EFI_SUCCESS;
 }
diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
index 6719d0adcc87..4330a861cd96 100644
--- a/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
+++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
@@ -82,7 +82,6 @@ [FixedPcd]
   gArmTokenSpaceGuid.PcdPciBusMax
 
 [Pcd]
-  gEmbeddedTokenSpaceGuid.PcdFdtDevicePaths
   gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration
 
 [Depex]
-- 
2.9.3



      parent reply	other threads:[~2017-03-31 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 14:14 [PATCH v2 0/9] ArmPlatformgPkg spring cleaning -- now includes Juno Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 1/9] ArmPlatformPkg/ArmShellCmdRunAxf: remove BdsLib dependency Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 2/9] ArmPlatformPkg/ArmVExpressDxe: remove ARM support Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 3/9] ArmPlatformPkg/ArmVExpressDxe: remove unused cruft from ArmHwDxe Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 4/9] ArmPlatformPkg/ArmVExpressDxe: remove FDT handling Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 5/9] ArmPlatformPkg/ArmJunoDxe: use the generic non-discoverable device support Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 6/9] ArmPlatformPkg/ArmJunoPkg: remove PCI host bridge driver Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 7/9] ArmPlatformPkg/ArmJunoDxe: remove BdsLib dependency Ard Biesheuvel
2017-03-31 14:14 ` [PATCH v2 8/9] ArmPlatformPkg/ArmJunoDxe: simplify ACPI table installation Ard Biesheuvel
2017-03-31 14:14 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331141434.20810-10-ard.biesheuvel@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox