From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x229.google.com (mail-wr0-x229.google.com [IPv6:2a00:1450:400c:c0c::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 36A7221A04830 for ; Wed, 5 Apr 2017 08:38:06 -0700 (PDT) Received: by mail-wr0-x229.google.com with SMTP id t20so20407913wra.1 for ; Wed, 05 Apr 2017 08:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CI4jyEkmdkublQKSCgSyyQZmX2t7yFpWwzIEHQ2yKtc=; b=KswJ9VHVUG1zcbHMW+5sok2wVAu6FyH2iTAgZcFJ49qMRAY/RYPoGyyTVvti4datUc g2NWG0xJVRyQmricV/zfQr4iZ8CqPkYdwCMCkTQlY2PrvMnZmuKTQ5P/xYzChbI7EZAn 4YkeyZpPi83Imd/XONRJUqMAjgrlVzuKoGZ4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CI4jyEkmdkublQKSCgSyyQZmX2t7yFpWwzIEHQ2yKtc=; b=Em4mYlh7whkOFBHvEBEvNVOCbZ277Kn6boXynVOIDSUCQmAiTBqhzzNjQaulRM9jaw t/Xiq/h+uqrf6mlmUFT2NVDwrxVOXP8d1Q/4IN16u5UyqID5AtnwUAI0qkAo3wpLui8a +Ww+28URUkqYu/Z5jRZ6NkA+PTm58vpeCmpNNympba/70tBIp640ysIFrXF5tbufxpjL 3j8n+9ruHVxL0WTohQjimdnSrzEkiNLfTVko4YWzHcQnLJdqjL/njUN6D+qJsxvjD1hp DyEmNAopt3yoLllYXFZAKTeigdXHCIeSADDmhejQByAYKYMNAJjTKu5VrpCsV8dhExem XEJw== X-Gm-Message-State: AFeK/H3BM8XNjdW1vSHuAzoUNPg3ZdALmA8Nh1S2WSjZdU48sASuefCq AdVsHGia+3gH+Oyi X-Received: by 10.28.230.84 with SMTP id d81mr9714805wmh.117.1491406684695; Wed, 05 Apr 2017 08:38:04 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 198sm22841691wmn.30.2017.04.05.08.38.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 08:38:03 -0700 (PDT) Date: Wed, 5 Apr 2017 16:38:02 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , "Zeng, Star" Message-ID: <20170405153802.GQ25239@bivouac.eciton.net> References: <20170405093806.6779-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] MdeModulePkg: move PlatformHasAcpiGuid from EmbeddedPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 15:38:06 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 05, 2017 at 11:01:05AM +0100, Ard Biesheuvel wrote: > On 5 April 2017 at 10:49, Laszlo Ersek wrote: > > On 04/05/17 11:38, Ard Biesheuvel wrote: > >> Given the agreement on the edk2-devel regarding the fact that the > >> notion whether or not a 'platform has ACPI' is a universal one, move > >> the PlatformHasAcpi GUID to MdeModulePkg. > >> > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Ard Biesheuvel > >> Reviewed-by: "Zeng, Star" > >> --- > >> ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 1 + > >> ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf | 1 + > >> EmbeddedPkg/EmbeddedPkg.dec | 3 --- > >> EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf | 1 + > >> {EmbeddedPkg => MdeModulePkg}/Include/Guid/PlatformHasAcpi.h | 0 > >> MdeModulePkg/MdeModulePkg.dec | 3 +++ > >> 6 files changed, 6 insertions(+), 3 deletions(-) > >> > >> diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > >> index 08025f0c3722..5351e741aa41 100644 > >> --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > >> +++ b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > >> @@ -27,6 +27,7 @@ [Sources] > >> [Packages] > >> ArmVirtPkg/ArmVirtPkg.dec > >> EmbeddedPkg/EmbeddedPkg.dec > >> + MdeModulePkg/MdeModulePkg.dec > >> MdePkg/MdePkg.dec > >> OvmfPkg/OvmfPkg.dec > >> > >> diff --git a/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf b/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > >> index 2833075f65c9..26965c50c12b 100644 > >> --- a/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > >> +++ b/ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > >> @@ -26,6 +26,7 @@ [Sources] > >> > >> [Packages] > >> EmbeddedPkg/EmbeddedPkg.dec > >> + MdeModulePkg/MdeModulePkg.dec > >> MdePkg/MdePkg.dec > >> > >> [LibraryClasses] > >> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > >> index 0bed2736c8c3..a7e127085236 100644 > >> --- a/EmbeddedPkg/EmbeddedPkg.dec > >> +++ b/EmbeddedPkg/EmbeddedPkg.dec > >> @@ -57,9 +57,6 @@ [Guids.common] > >> gFdtHobGuid = { 0x16958446, 0x19B7, 0x480B, { 0xB0, 0x47, 0x74, 0x85, 0xAD, 0x3F, 0x71, 0x6D } } > >> gFdtVariableGuid = { 0x25a4fd4a, 0x9703, 0x4ba9, { 0xa1, 0x90, 0xb7, 0xc8, 0x4e, 0xfb, 0x3e, 0x57 } } > >> > >> - ## Include/Guid/PlatformHasAcpi.h > >> - gEdkiiPlatformHasAcpiGuid = { 0xf0966b41, 0xc23f, 0x41b9, { 0x96, 0x04, 0x0f, 0xf7, 0xe1, 0x11, 0x96, 0x5a } } > >> - > >> ## Include/Guid/PlatformHasDeviceTree.h > >> gEdkiiPlatformHasDeviceTreeGuid = { 0x7ebb920d, 0x1aaf, 0x46d9, { 0xb2, 0xaf, 0x54, 0x1e, 0x1d, 0xce, 0x14, 0x8b } } > >> > >> diff --git a/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf b/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf > >> index 6268293ca97b..be298ba67c40 100644 > >> --- a/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf > >> +++ b/EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf > >> @@ -34,6 +34,7 @@ [Sources] > >> > >> [Packages] > >> EmbeddedPkg/EmbeddedPkg.dec > > > > I think you can remove "EmbeddedPkg/EmbeddedPkg.dec" here. > > > > Ah yes. It didn't occur to me to remove the 'home' package here, but I > suppose this library doesn't depend on anything it provides. > > > ( > > > > I checked all the other INF files being modified as well; it seems that > > "EmbeddedPkg/EmbeddedPkg.dec" remains necessary in all other places. > > > > I also grepped all INF files for the GUID -- DtPlatformDxe.inf is > > another user, but it needs no modification. > > > > ) > > > > With that update (if it indeed works), > > > > Reviewed-by: Laszlo Ersek Seconded. (Reviewed-by: Leif Lindholm ) / Leif