public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib
Date: Thu, 13 Apr 2017 10:59:35 +0100	[thread overview]
Message-ID: <20170413095935.GE1657@bivouac.eciton.net> (raw)
In-Reply-To: <CAKv+Gu_hMG+Fy6XCoDP6LKzGWJMZrVp0hZKF_8eC=FrgOuo=RQ@mail.gmail.com>

On Thu, Apr 13, 2017 at 08:32:32AM +0100, Ard Biesheuvel wrote:
> On 12 April 2017 at 21:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > ARM ArmHvcLib looks like it was created from copy of ArmSmcLib which
> > looks like it was created from a copy of the AArch64 version.
> >
> > Both of these files include AsmMacroIoLibV8.h instead of
> > AsmMacroIoLib.h, although since they only use macros that are identical
> > between the two, there was no functional issue caused by this.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as d63ed30.

> > ---
> >  ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S | 2 +-
> >  ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> > index be4693796f..fef51e7521 100644
> > --- a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> > +++ b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> > @@ -12,7 +12,7 @@
> >  //
> >  //
> >
> > -#include <AsmMacroIoLibV8.h>
> > +#include <AsmMacroIoLib.h>
> >
> >  .arch_extension virt
> >
> > diff --git a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> > index afb2e9bc90..990e12ef75 100644
> > --- a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> > +++ b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> > @@ -11,7 +11,7 @@
> >  //
> >  //
> >
> > -#include <AsmMacroIoLibV8.h>
> > +#include <AsmMacroIoLib.h>
> >
> >  .arch_extension sec
> >
> > --
> > 2.11.0
> >


      reply	other threads:[~2017-04-13  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 20:22 [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib Leif Lindholm
2017-04-13  7:32 ` Ard Biesheuvel
2017-04-13  9:59   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170413095935.GE1657@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox