Re: [PATCH] EmbeddedPkg: import Lan91x Ethernet controller driver

[Leif Lindholm <leif.lindholm@linaro.org>]

On Wed, Apr 19, 2017 at 12:54:37PM +0100, Ard Biesheuvel wrote:
> On 19 April 2017 at 12:49, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > OpenPlatformPkg (https://git.linaro.org/uefi/OpenPlatformPkg.git) holds a
> > driver for the SMSC LAN91x, used (among other places) in several ARM Ltd.
> > software system models.
> >
> > Import it to EDK2 EmbeddedPkg in preparation for migrating those model
> > platforms to edk2-platforms.
> >
> > On the way, update the files to pass PatchCheck.py without warnings
> > (EFI_D_ -> DEBUG_ and purging tab characters).
> 
> Given that you're touching all DEBUG() statements anyway, perhaps you
> could add spaces before the '(' as well?

Ah, yes, good point. Done.

> Other than that, no comments. We'll revisit this when we turn it into
> a proper driver model driver.
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as 4395f82e7f.

/
    Leif