From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8845021A0483B for ; Wed, 19 Apr 2017 05:07:48 -0700 (PDT) Received: by mail-wm0-x230.google.com with SMTP id w64so78546440wma.0 for ; Wed, 19 Apr 2017 05:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MdbhRDTGkJyUVQHrYuZaK0Y3zhJxbZFhHRvUTy54GXE=; b=Mc+9CAIMgF/hVrkNxFoLKeJ4UCCMjXCIr7A+qdJbTP6025cE7QCilbk53l4xQjToOJ KwVogeH2KyjB26JCKx1sB2WNZWNa3qH5YYgY1TvWiGlfhgGJMRniD38OwIX0aswGYCS4 2sflTdj/Dgqc1F9ptEoaxd4vY9RC4egbV21LE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MdbhRDTGkJyUVQHrYuZaK0Y3zhJxbZFhHRvUTy54GXE=; b=szTECYL2wuL5Vo6yF82QGHCmPS7+ewKG6R2lswcV92aqTZY1jp8R5P8kgcO/cAfAOK vHDwUTANvLp1C/9G2+jyj27UDFFL64rufQDFhyQZZlk0b8HgJaDa3oWgvc6waluH6/wk p2Et/TkZhIOD6zUFJhJ5mryXpHBoGygPqsqpVkf9bP9iZXNCjfQz3LsCpa8EVx4+tE/m d39lGbIYwTwlsltz4SbOBYaHXpnV7IbfNoct7GIM2bbaXX9Z1IJAc5ahUkIMjbzKOWjB jPWjSHpH5UK5Uiq+03v0GnA10c+nNXUqFSQqr4uMXytUDnLq3nfheqyzNMi6qgEYifYx 6e4A== X-Gm-Message-State: AN3rC/7Y0ZjCcgt7nV18SPI4hjzhUeECxLhCYxXNi6KyfbAMe1y20YR4 FfR9eYnms5UBqPaj X-Received: by 10.28.94.9 with SMTP id s9mr17717873wmb.17.1492603666736; Wed, 19 Apr 2017 05:07:46 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 134sm18990029wmj.6.2017.04.19.05.07.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Apr 2017 05:07:45 -0700 (PDT) Date: Wed, 19 Apr 2017 13:07:44 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , "Kinney, Michael D" , Andrew Fish Message-ID: <20170419120744.GV1657@bivouac.eciton.net> References: <20170419114923.24981-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] EmbeddedPkg: import Lan91x Ethernet controller driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 12:07:49 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 19, 2017 at 12:54:37PM +0100, Ard Biesheuvel wrote: > On 19 April 2017 at 12:49, Leif Lindholm wrote: > > OpenPlatformPkg (https://git.linaro.org/uefi/OpenPlatformPkg.git) holds a > > driver for the SMSC LAN91x, used (among other places) in several ARM Ltd. > > software system models. > > > > Import it to EDK2 EmbeddedPkg in preparation for migrating those model > > platforms to edk2-platforms. > > > > On the way, update the files to pass PatchCheck.py without warnings > > (EFI_D_ -> DEBUG_ and purging tab characters). > > Given that you're touching all DEBUG() statements anyway, perhaps you > could add spaces before the '(' as well? Ah, yes, good point. Done. > Other than that, no comments. We'll revisit this when we turn it into > a proper driver model driver. > > Reviewed-by: Ard Biesheuvel Thanks! Pushed as 4395f82e7f. / Leif