* [PATCH] PeCoffGetEntryPointLib: Fix spelling issue
@ 2017-04-24 2:29 Jeff Fan
2017-04-24 2:29 ` Jeff Fan
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Fan @ 2017-04-24 2:29 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Feng Tian, Michael Kinney
*Serach* should be *Search*. This is an incompatible change of library API name.
But this API was introduced a couple of weeks ago, this fix should be low
impact.
To make sure build pass on each commit, I create one single patch across
packages updating for this typo fix.
https://bugzilla.tianocore.org/show_bug.cgi?id=503
Cc: Liming Gao <liming.gao@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Jeff Fan (1):
PeCoffGetEntryPointLib: Fix spelling issue
MdePkg/Include/Library/PeCoffGetEntryPointLib.h | 2 +-
MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 2 +-
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
--
2.9.3.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] PeCoffGetEntryPointLib: Fix spelling issue
2017-04-24 2:29 [PATCH] PeCoffGetEntryPointLib: Fix spelling issue Jeff Fan
@ 2017-04-24 2:29 ` Jeff Fan
2017-04-25 1:55 ` Gao, Liming
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Fan @ 2017-04-24 2:29 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao, Feng Tian, Michael Kinney
*Serach* should be *Search*
Cc: Liming Gao <liming.gao@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
---
MdePkg/Include/Library/PeCoffGetEntryPointLib.h | 2 +-
MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c | 2 +-
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 2 +-
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdePkg/Include/Library/PeCoffGetEntryPointLib.h b/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
index 647503b..f211cf5 100644
--- a/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
+++ b/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
@@ -115,7 +115,7 @@ PeCoffGetSizeOfHeaders (
**/
UINTN
EFIAPI
-PeCoffSerachImageBase (
+PeCoffSearchImageBase (
IN UINTN Address
);
diff --git a/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c b/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
index 00f6d7d..e1ddc8b 100644
--- a/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
+++ b/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
@@ -332,7 +332,7 @@ PeCoffGetSizeOfHeaders (
**/
UINTN
EFIAPI
-PeCoffSerachImageBase (
+PeCoffSearchImageBase (
IN UINTN Address
)
{
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
index 6f3c419..f156fe2 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
@@ -206,7 +206,7 @@ FindAndReportModuleImageInfo (
//
// Find Image Base
//
- Pe32Data = PeCoffSerachImageBase ((UINTN) mErrorMsgVersionAlert);
+ Pe32Data = PeCoffSearchImageBase ((UINTN) mErrorMsgVersionAlert);
if (Pe32Data != 0) {
ImageContext.ImageAddress = Pe32Data;
ImageContext.PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN) ImageContext.ImageAddress);
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
index 78ee182..dbfaae1 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
@@ -120,7 +120,7 @@ DumpModuleImageInfo (
VOID *PdbPointer;
VOID *EntryPoint;
- Pe32Data = PeCoffSerachImageBase (CurrentEip);
+ Pe32Data = PeCoffSearchImageBase (CurrentEip);
if (Pe32Data == 0) {
InternalPrintMessage ("!!!! Can't find image information. !!!!\n");
} else {
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
index 2cb0bbc..2d6b572 100755
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
@@ -178,7 +178,7 @@ DumpModuleInfoByIp (
//
// Find Image Base
//
- Pe32Data = PeCoffSerachImageBase (CallerIpAddress);
+ Pe32Data = PeCoffSearchImageBase (CallerIpAddress);
if (Pe32Data != 0) {
DEBUG ((DEBUG_ERROR, "It is invoked from the instruction before IP(0x%p)", (VOID *) CallerIpAddress));
PdbPointer = PeCoffLoaderGetPdbPointer ((VOID *) Pe32Data);
--
2.9.3.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PeCoffGetEntryPointLib: Fix spelling issue
2017-04-24 2:29 ` Jeff Fan
@ 2017-04-25 1:55 ` Gao, Liming
0 siblings, 0 replies; 3+ messages in thread
From: Gao, Liming @ 2017-04-25 1:55 UTC (permalink / raw)
To: Fan, Jeff, edk2-devel@lists.01.org; +Cc: Tian, Feng, Kinney, Michael D
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Fan, Jeff
>Sent: Monday, April 24, 2017 10:29 AM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>; Tian, Feng <feng.tian@intel.com>;
>Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: [PATCH] PeCoffGetEntryPointLib: Fix spelling issue
>
>*Serach* should be *Search*
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Feng Tian <feng.tian@intel.com>
>Cc: Michael Kinney <michael.d.kinney@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Jeff Fan <jeff.fan@intel.com>
>---
> MdePkg/Include/Library/PeCoffGetEntryPointLib.h | 2 +-
> MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c | 2
>+-
>
>SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAge
>nt.c | 2 +-
> UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2
>+-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>b/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>index 647503b..f211cf5 100644
>--- a/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>+++ b/MdePkg/Include/Library/PeCoffGetEntryPointLib.h
>@@ -115,7 +115,7 @@ PeCoffGetSizeOfHeaders (
> **/
> UINTN
> EFIAPI
>-PeCoffSerachImageBase (
>+PeCoffSearchImageBase (
> IN UINTN Address
> );
>
>diff --git
>a/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>b/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>index 00f6d7d..e1ddc8b 100644
>--- a/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>+++ b/MdePkg/Library/BasePeCoffGetEntryPointLib/PeCoffGetEntryPoint.c
>@@ -332,7 +332,7 @@ PeCoffGetSizeOfHeaders (
> **/
> UINTN
> EFIAPI
>-PeCoffSerachImageBase (
>+PeCoffSearchImageBase (
> IN UINTN Address
> )
> {
>diff --git
>a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>index 6f3c419..f156fe2 100644
>---
>a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>+++
>b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugA
>gent.c
>@@ -206,7 +206,7 @@ FindAndReportModuleImageInfo (
> //
> // Find Image Base
> //
>- Pe32Data = PeCoffSerachImageBase ((UINTN) mErrorMsgVersionAlert);
>+ Pe32Data = PeCoffSearchImageBase ((UINTN) mErrorMsgVersionAlert);
> if (Pe32Data != 0) {
> ImageContext.ImageAddress = Pe32Data;
> ImageContext.PdbPointer = PeCoffLoaderGetPdbPointer ((VOID*) (UINTN)
>ImageContext.ImageAddress);
>diff --git
>a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>index 78ee182..dbfaae1 100644
>--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
>@@ -120,7 +120,7 @@ DumpModuleImageInfo (
> VOID *PdbPointer;
> VOID *EntryPoint;
>
>- Pe32Data = PeCoffSerachImageBase (CurrentEip);
>+ Pe32Data = PeCoffSearchImageBase (CurrentEip);
> if (Pe32Data == 0) {
> InternalPrintMessage ("!!!! Can't find image information. !!!!\n");
> } else {
>diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>index 2cb0bbc..2d6b572 100755
>--- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c
>@@ -178,7 +178,7 @@ DumpModuleInfoByIp (
> //
> // Find Image Base
> //
>- Pe32Data = PeCoffSerachImageBase (CallerIpAddress);
>+ Pe32Data = PeCoffSearchImageBase (CallerIpAddress);
> if (Pe32Data != 0) {
> DEBUG ((DEBUG_ERROR, "It is invoked from the instruction before
>IP(0x%p)", (VOID *) CallerIpAddress));
> PdbPointer = PeCoffLoaderGetPdbPointer ((VOID *) Pe32Data);
>--
>2.9.3.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-25 1:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-24 2:29 [PATCH] PeCoffGetEntryPointLib: Fix spelling issue Jeff Fan
2017-04-24 2:29 ` Jeff Fan
2017-04-25 1:55 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox