public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: [PATCH 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart
Date: Mon, 24 Apr 2017 13:45:57 +0800	[thread overview]
Message-ID: <20170424054557.6992-3-hao.a.wu@intel.com> (raw)
In-Reply-To: <20170424054557.6992-1-hao.a.wu@intel.com>

In function UfsHcDriverBindingStart(), the return value 'Status' may be
overriden during the original PCI attributes restore process.

This commit refines the logics to avoid such override.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c
index 373e55b4c2..241d9bac9f 100644
--- a/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c
+++ b/MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.c
@@ -671,13 +671,12 @@ Done:
       //
       // Restore original PCI attributes
       //
-      Status = PciIo->Attributes (
-                        PciIo,
-                        EfiPciIoAttributeOperationSet,
-                        Private->PciAttributes,
-                        NULL
-                        );
-      ASSERT_EFI_ERROR (Status);
+      ASSERT_EFI_ERROR (PciIo->Attributes (
+                                 PciIo,
+                                 EfiPciIoAttributeOperationSet,
+                                 Private->PciAttributes,
+                                 NULL
+                                 ));
     }
     gBS->CloseProtocol (
           Controller,
-- 
2.12.0.windows.1



  parent reply	other threads:[~2017-04-24  5:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  5:45 [PATCH 0/2] MdeModulePkg/UfsPciHc: Code refinements Hao Wu
2017-04-24  5:45 ` [PATCH 1/2] MdeModulePkg/UfsPciHc: Remove unused field in UfsHc private struct Hao Wu
2017-04-24  5:51   ` Zeng, Star
2017-04-24  5:45 ` Hao Wu [this message]
2017-04-24  5:50   ` [PATCH 2/2] MdeModulePkg/UfsPciHc: Avoid overriding return value in BindingStart Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424054557.6992-3-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox