public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch][edk2-platforms/devel-MinnowBoard3] Clean up ACPI code.
@ 2017-05-09  6:12 zwei4
  0 siblings, 0 replies; only message in thread
From: zwei4 @ 2017-05-09  6:12 UTC (permalink / raw)
  To: edk2-devel

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: zwei4 <david.wei@intel.com>
---
 .../Common/Acpi/AcpiTablesPCAT/ScScc.asl           | 27 ++++------------------
 .../Common/Acpi/AcpiTablesPCAT/token.asl           |  3 +--
 2 files changed, 5 insertions(+), 25 deletions(-)

diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl
index 9432a2562..a7290f76a 100644
--- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl
+++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/ScScc.asl
@@ -1,5 +1,5 @@
 /** @file
-  Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2012 - 2017, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -532,12 +532,8 @@ scope (\_SB.PCI0) {
       //
       // GPIO 183: Set GPIOTXState = 0
       //
+      Store (0, \_SB.PCI0.SDC.GPOV)
 
-      If (LEqual(BDID,GRBM)) {
-        Store (1, \_SB.PCI0.SDC.GPOV)
-      } Else {
-        Store (0, \_SB.PCI0.SDC.GPOV)
-      }
 
       //
       // Save GPIO_177 DW0 and DW1
@@ -557,12 +553,8 @@ scope (\_SB.PCI0) {
       //
       // GPIO 183: Set GPIOTXState = 1
       //
+      Store (1, \_SB.PCI0.SDC.GPOV)
 
-      If (LEqual(BDID,GRBM)) {
-        Store (0, \_SB.PCI0.SDC.GPOV)
-      } Else {
-        Store (1, \_SB.PCI0.SDC.GPOV)
-      }
 
       //
       // Clear Normal Interrupt Status Enable Bit 6 & 7
@@ -667,13 +659,8 @@ scope (\_SB.PCI0) {
             //      Set gpiotxstate =1
             //
 
-            // GPIO 183: Set GPIOTXState = 1
-
-            If (LEqual(BDID,GRBM)) {
-            Store (0, \_SB.PCI0.SDC.GPOV)
-            } Else {
             Store (1, \_SB.PCI0.SDC.GPOV)
-            }
+
             // Sleep for 50ms Between Powering Off / Powering On
             Sleep (50)
 
@@ -681,13 +668,7 @@ scope (\_SB.PCI0) {
             //     GPIO 183:
             //       Set gpiotxstate = 0
 
-            // GPIO 183: Set GPIOTXState = 0
-
-            If (LEqual(BDID,GRBM)) {
-            Store (1, \_SB.PCI0.SDC.GPOV)
-            } Else {
             Store (0, \_SB.PCI0.SDC.GPOV)
-            }
 
             Return (Buffer(){0x00})
           }
diff --git a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl
index 3716dc28d..bdc98ea59 100644
--- a/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl
+++ b/Platform/BroxtonPlatformPkg/Common/Acpi/AcpiTablesPCAT/token.asl
@@ -1,5 +1,5 @@
 /** @file
-  Copyright (c) 2012 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2012 - 2017, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -50,6 +50,5 @@ Name(PEER, 0x1)         // _OSC: Pci Express Advanced Error Reporting control
 Name(PECS, 0x1)         // _OSC: Pci Express Capability Structure control
 Name(ITKE, 0x0)         // This will be overridden by the ITK module.
 Name(FTBL, 0x4)         // Platform Flavor - Tablet flavor for ASL code.
-Name(GRBM, 0xF)         // Board id for Gordon Ridge BMP MRB
 Name(MNHL, 0x5)         // Board id for Mineral Hill
 
-- 
2.11.0.windows.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-09  6:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-09  6:12 [Patch][edk2-platforms/devel-MinnowBoard3] Clean up ACPI code zwei4

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox