public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Gary Lin <glin@suse.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH 1/5] OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace
Date: Fri, 12 May 2017 17:07:13 +0800	[thread overview]
Message-ID: <20170512090713.sa24tcrcepuiblx4@GaryWorkstation> (raw)
In-Reply-To: <20170506193023.4767-2-lersek@redhat.com>

On Sat, May 06, 2017 at 09:30:19PM +0200, Laszlo Ersek wrote:
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Regression-tested-by: Gary Lin <glin@suse.com>

> ---
>  OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h | 16 +++----
>  OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 44 ++++++++++----------
>  2 files changed, 30 insertions(+), 30 deletions(-)
> 
> diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h
> index f34fad2cdd48..4247d21d72f8 100644
> --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h
> +++ b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h
> @@ -1,18 +1,18 @@
>  /*++
>  
>  Copyright (c) 2006, Intel Corporation. All rights reserved.<BR>
> -This program and the accompanying materials                          
> -are licensed and made available under the terms and conditions of the BSD License         
> -which accompanies this distribution.  The full text of the license may be found at        
> -http://opensource.org/licenses/bsd-license.php                                            
> -                                                                                          
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,                     
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.             
> +This program and the accompanying materials
> +are licensed and made available under the terms and conditions of the BSD License
> +which accompanies this distribution.  The full text of the license may be found at
> +http://opensource.org/licenses/bsd-license.php
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>  
>  Module Name:
>  
>    FwBlockService.h
> -  
> +
>  Abstract:
>  
>    Firmware volume block driver for Intel Firmware Hub (FWH) device
> diff --git a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c
> index 7a6d3153ec8c..2f89632e5d75 100644
> --- a/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c
> +++ b/OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c
> @@ -120,14 +120,14 @@ FvbVirtualAddressChangeEvent (
>    only for memory-mapped firmware volumes.
>  
>    @param This     Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance.
> -  
> +
>    @param Address  Pointer to a caller-allocated
>                    EFI_PHYSICAL_ADDRESS that, on successful
>                    return from GetPhysicalAddress(), contains the
>                    base address of the firmware volume.
> -  
> +
>    @retval EFI_SUCCESS       The firmware volume base address is returned.
> -  
> +
>    @retval EFI_NOT_SUPPORTED The firmware volume is not memory mapped.
>  
>  **/
> @@ -168,9 +168,9 @@ FvbProtocolGetPhysicalAddress (
>                          blocks in this range have a size of
>                          BlockSize.
>  
> -  
> +
>    @retval EFI_SUCCESS             The firmware volume base address is returned.
> -  
> +
>    @retval EFI_INVALID_PARAMETER   The requested LBA is out of range.
>  
>  **/
> @@ -246,7 +246,7 @@ FvbProtocolGetAttributes (
>                        settings of the firmware volume. Type
>                        EFI_FVB_ATTRIBUTES_2 is defined in
>                        EFI_FIRMWARE_VOLUME_HEADER.
> -  
> +
>    @retval EFI_SUCCESS           The firmware volume attributes were returned.
>  
>    @retval EFI_INVALID_PARAMETER The attributes requested are in
> @@ -302,7 +302,7 @@ FvbProtocolSetAttributes (
>  
>    @retval EFI_SUCCESS The erase request was successfully
>                        completed.
> -  
> +
>    @retval EFI_ACCESS_DENIED   The firmware volume is in the
>                                WriteDisabled state.
>    @retval EFI_DEVICE_ERROR  The block device is not functioning
> @@ -311,7 +311,7 @@ FvbProtocolSetAttributes (
>                              partially erased.
>    @retval EFI_INVALID_PARAMETER One or more of the LBAs listed
>                                  in the variable argument list do
> -                                not exist in the firmware volume.  
> +                                not exist in the firmware volume.
>  
>  **/
>  EFI_STATUS
> @@ -420,29 +420,29 @@ FvbProtocolEraseBlocks (
>    returns.
>  
>    @param This     Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance.
> -  
> +
>    @param Lba      The starting logical block index to write to.
> -  
> +
>    @param Offset   Offset into the block at which to begin writing.
> -  
> +
>    @param NumBytes Pointer to a UINTN. At entry, *NumBytes
>                    contains the total size of the buffer. At
>                    exit, *NumBytes contains the total number of
>                    bytes actually written.
> -  
> +
>    @param Buffer   Pointer to a caller-allocated buffer that
>                    contains the source for the write.
> -  
> +
>    @retval EFI_SUCCESS         The firmware volume was written successfully.
> -  
> +
>    @retval EFI_BAD_BUFFER_SIZE The write was attempted across an
>                                LBA boundary. On output, NumBytes
>                                contains the total number of bytes
>                                actually written.
> -  
> +
>    @retval EFI_ACCESS_DENIED   The firmware volume is in the
>                                WriteDisabled state.
> -  
> +
>    @retval EFI_DEVICE_ERROR    The block device is malfunctioning
>                                and could not be written.
>  
> @@ -503,7 +503,7 @@ FvbProtocolWrite (
>    aware that a read may be partially completed.
>  
>    @param This     Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance.
> -  
> +
>    @param Lba      The starting logical block index
>                    from which to read.
>  
> @@ -519,15 +519,15 @@ FvbProtocolWrite (
>  
>    @retval EFI_SUCCESS         The firmware volume was read successfully
>                                and contents are in Buffer.
> -  
> +
>    @retval EFI_BAD_BUFFER_SIZE Read attempted across an LBA
>                                boundary. On output, NumBytes
>                                contains the total number of bytes
>                                returned in Buffer.
> -  
> +
>    @retval EFI_ACCESS_DENIED   The firmware volume is in the
>                                ReadDisabled state.
> -  
> +
>    @retval EFI_DEVICE_ERROR    The block device is not
>                                functioning correctly and could
>                                not be read.
> @@ -715,9 +715,9 @@ InitializeFvAndVariableStoreHeaders (
>  /**
>    Main entry point.
>  
> -  @param[in] ImageHandle    The firmware allocated handle for the EFI image.  
> +  @param[in] ImageHandle    The firmware allocated handle for the EFI image.
>    @param[in] SystemTable    A pointer to the EFI System Table.
> -  
> +
>    @retval EFI_SUCCESS       Successfully initialized.
>  
>  **/
> -- 
> 2.9.3
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-05-12  9:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 19:30 [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables) Laszlo Ersek
2017-05-06 19:30 ` [PATCH 1/5] OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace Laszlo Ersek
2017-05-12  9:07   ` Gary Lin [this message]
2017-05-06 19:30 ` [PATCH 2/5] OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB Laszlo Ersek
2017-05-12  9:07   ` Gary Lin
2017-05-15 23:50   ` Jordan Justen
2017-05-06 19:30 ` [PATCH 3/5] OvmfPkg/PlatformPei: align EmuVariableNvStore at any page boundary Laszlo Ersek
2017-05-12  9:08   ` Gary Lin
2017-05-06 19:30 ` [PATCH 4/5] OvmfPkg/README: document 4MB flash layout Laszlo Ersek
2017-05-06 19:30 ` [PATCH 5/5] OvmfPkg: make the 4MB flash size the default (again) Laszlo Ersek
2017-05-08  4:27 ` [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables) Gary Lin
2017-05-12  2:02   ` Gary Lin
2017-05-12  8:40     ` Laszlo Ersek
2017-05-16  0:40       ` Jordan Justen
2017-05-16  4:20         ` Gary Lin
2017-05-18 12:36           ` Laszlo Ersek
2017-05-23 14:12             ` Is: Fix for 4MB BIOS payload in hvmloader. Was:Re: " Konrad Rzeszutek Wilk
     [not found]               ` <59246AD9020000780015C380@prv-mh.provo.novell.com>
2017-05-23 16:04                 ` Laszlo Ersek
     [not found]               ` <6af13bb5-0bfb-c9e3-e9fe-d1361d851e7d@arm.com>
2017-05-23 16:20                 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512090713.sa24tcrcepuiblx4@GaryWorkstation \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox