From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0CD0921A16E47 for ; Mon, 15 May 2017 21:21:01 -0700 (PDT) Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 16 May 2017 06:21:00 +0200 Received: from GaryWorkstation (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Tue, 16 May 2017 05:20:41 +0100 Date: Tue, 16 May 2017 12:20:34 +0800 From: Gary Lin To: Jordan Justen Cc: Laszlo Ersek , edk2-devel-01 Message-ID: <20170516042034.hpf3fllcarzkgomh@GaryWorkstation> References: <20170506193023.4767-1-lersek@redhat.com> <20170508042759.kuut2vueabxvimwk@GaryWorkstation> <20170512020215.jvnmgzvrgdv66ere@GaryWorkstation> <12b9e870-30e4-8b88-9851-771d94264552@redhat.com> <149489525952.434.10185839319642314352@jljusten-skl> MIME-Version: 1.0 In-Reply-To: <149489525952.434.10185839319642314352@jljusten-skl> User-Agent: Mutt/1.6.2 (2016-07-01) Subject: Re: [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 04:21:02 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 15, 2017 at 05:40:59PM -0700, Jordan Justen wrote: > On 2017-05-12 01:40:34, Laszlo Ersek wrote: > > On 05/12/17 04:02, Gary Lin wrote: > > > On Mon, May 08, 2017 at 12:27:59PM +0800, Gary Lin wrote: > > >> On Sat, May 06, 2017 at 09:30:18PM +0200, Laszlo Ersek wrote: > > >>> (All hail Saturday!) > > >>> > > >>> Gary, can you please fetch this from my repo (URL & branch name below) > > >>> and test it with Xen? Please test both the 4MB and the 2MB build. (I > > >>> also tested both, with qemu + "-bios".) > > >> Hi Laszlo, > > >> > > >> I have done some simples test with xen, and the 2MB build seems fine. > > >> It booted into grub2 menu successfully. However, the 4MB build never boots. > > >> The QEMU window showed less than 1 sec and then disappeared. > > >> > > >> Here is the snippet from 'xl dmesg' > > >> > > >> (d15) - CPU0 ... 39-bit phys ... fixed MTRRs ... var MTRRs [1/8] ... done. > > >> (d15) Testing HVM environment: > > >> (d15) - REP INSB across page boundaries ... passed > > >> (d15) - GS base MSRs and SWAPGS ... passed > > >> (d15) Passed 2 of 2 tests > > >> (d15) Writing SMBIOS tables ... > > >> (d15) Loading OVMF ... > > >> (d15) no BIOS ROM image found > > >> (d15) *** HVMLoader bug at hvmloader.c:381 > > >> (d15) *** HVMLoader crashed. > > >> > > >> I'm pretty sure that the ovmf path is right, so it seems Xen just rejected > > >> the 4MB build :-\ > > >> > > >> I'll try to dig more information. > > >> > > > There is a function in the xen hvmloader clearing the memory from > > > 0x400000 to 0x800000. Unfortunately, the hvm_start_info struct of the > > > 4MB OVMF was loaded to 0x588000, so the struct was cleared mistakenly > > > and hvmloader cannot find the firmware. Xen is not ready for the 4MB > > > build yet :-\ > > > > > > The discussion in xen-devel: > > > https://lists.xen.org/archives/html/xen-devel/2017-05/msg01053.html > > > > Thank you for the feedback! > > > > In this case, I think we should drop the last patch from this series. > > Can we come up with a plan for trying to fix this? Gary, would it be > okay if we opened a bug and assigned it to you? Or, do you have > another suggestion for a possible Xen owner? > Jan Beulich (also a SUSE employee) is working on the patch(*), and it works for me. Cheers, Gary Lin (*) https://lists.xen.org/archives/html/xen-devel/2017-05/msg01242.html > Thanks, > > -Jordan > > > > > However, your test results also confirm that the 2MB build continues to > > work with Xen, which means that the reworking of the > > EmuVariableFvbRuntimeDxe driver in this series, and the underlying > > tweaks+cleanups series, cause no regression. > > > > Can you please respond, with your "Regression-tested-by", to: > > > > (1) the full series > > > > [edk2] [PATCH 0/7] OvmfPkg: small cleanups and tweaks > > > > (2) and patches 1 through 3 in this series? (Patch #4 is just > > documentation, for which Tested-by would be strange.) > > > > Thank you! > > Laszlo > > > > > > >>> Note: this series depends on: > > >>> > > >>> [edk2] [PATCH 0/7] OvmfPkg: small cleanups and tweaks > > >>> https://lists.01.org/pipermail/edk2-devel/2017-May/010527.html > > >>> > > >>> and it has been pushed to my github repo as such. > > >>> > > >>> Repo: https://github.com/lersek/edk2.git > > >>> Branch: emu4k > > >>> > > >>> Cc: Gary Ching-Pang Lin > > >>> Cc: Jordan Justen > > >>> > > >>> Thanks, > > >>> Laszlo > > >>> > > >>> Laszlo Ersek (5): > > >>> OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace > > >>> OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB > > >>> OvmfPkg/PlatformPei: align EmuVariableNvStore at any page boundary > > >>> OvmfPkg/README: document 4MB flash layout > > >>> OvmfPkg: make the 4MB flash size the default (again) > > >>> > > >>> OvmfPkg/OvmfPkgIa32.dsc | 2 +- > > >>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > > >>> OvmfPkg/OvmfPkgX64.dsc | 2 +- > > >>> OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h | 26 ++- > > >>> OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 191 +++++++++----------- > > >>> OvmfPkg/PlatformPei/Platform.c | 20 +- > > >>> OvmfPkg/README | 39 +++- > > >>> 7 files changed, 143 insertions(+), 139 deletions(-) > > >>> > > >>> -- > > >>> 2.9.3 > > >>> > > >>> > > >> _______________________________________________ > > >> edk2-devel mailing list > > >> edk2-devel@lists.01.org > > >> https://lists.01.org/mailman/listinfo/edk2-devel > > >> > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel >