From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com [IPv6:2a00:1450:400c:c0c::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F6C021A16EFF for ; Fri, 19 May 2017 03:08:00 -0700 (PDT) Received: by mail-wr0-x236.google.com with SMTP id l9so13962136wre.1 for ; Fri, 19 May 2017 03:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Lo2+8XqkhJp1atH2cbAzJN2savAleefcy/iTfnGP4Yw=; b=ShkHNgwCCpHwAdH4doYJV4/2+Z+7zqzdbKs1bHZqNzOoJlz0Yz7Phos4ZZ5UAOZ8OO G4Oy1j2asT8hu3yzxq0c4KZHGDqLTkmBSjp2Lvvx1+dBOEbcrI4n122AlFh9qrBXtvZT BGZ5HBrzY6JHZclTekew++lR494N/GAr+xMQE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Lo2+8XqkhJp1atH2cbAzJN2savAleefcy/iTfnGP4Yw=; b=Dz7rmiLsqraW1yFRo/LwSQZ+JwA4pxWoAUR5p805gjkGtnpsRz5zJUWHUFWwStgTAJ 0m1H3Wr518rK+6i7oKIkFWB2tdtP5IxnsyZGFtfZI+rG3vgxaAyu63HNWlBff3NFPWGi cPhXX+0UYztFO4Zktqv7gBdyoTrOBjWvU8IgHSGKVFbd4q8uYtkVH0jOZic7NZgVrKXW boZ45W57T2pMQPvpoxiUUYTIfKoX07dfS6GKavvf0VJfTdoE/TKWvdL/BmzhzCx18AJG PswFp/rRZWvxjYIZiT59DkCbY+LbYMH9buCBPOJv4jSwd+WsMMerh9u8PZ16TSbBOm6C I2LQ== X-Gm-Message-State: AODbwcBbI97fevYL1VHT4Uq0gBGc0/escIGkFYb0Pr4dbHcoi91pnO1f +w0ZgnJu8/kX2y4D X-Received: by 10.223.135.50 with SMTP id a47mr2479468wra.138.1495188478632; Fri, 19 May 2017 03:07:58 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f70sm14094780wmd.25.2017.05.19.03.07.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 03:07:57 -0700 (PDT) Date: Fri, 19 May 2017 11:07:56 +0100 From: Leif Lindholm To: Jordan Justen Cc: Laszlo Ersek , edk2-devel-01 , Ard Biesheuvel Message-ID: <20170519100756.GB1657@bivouac.eciton.net> References: <20170518150427.16435-1-lersek@redhat.com> <20170518150427.16435-2-lersek@redhat.com> <149512810792.14216.11044391728020039744@jljusten-skl> <149514029896.16116.5092031537929111173@jljusten-skl.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <149514029896.16116.5092031537929111173@jljusten-skl.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 1/8] ArmPlatformPkg/NorFlashDxe: correct NumOfLba vararg type in EraseBlocks() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 10:08:00 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 18, 2017 at 01:44:58PM -0700, Jordan Justen wrote: > On 2017-05-18 12:29:09, Laszlo Ersek wrote: > > On 05/18/17 19:21, Jordan Justen wrote: > > > On 2017-05-18 08:04:20, Laszlo Ersek wrote: > > >> // All blocks must be within range > > >> - DEBUG ((DEBUG_BLKIO, "FvbEraseBlocks: Check if: ( StartingLba=%ld + NumOfLba=%d - 1 ) > LastBlock=%ld.\n", Instance->StartLba + StartingLba, NumOfLba, Instance->Media.LastBlock)); > > >> + DEBUG (( > > >> + DEBUG_BLKIO, > > >> + "FvbEraseBlocks: Check if: ( StartingLba=%ld + NumOfLba=%Lu - 1 ) > LastBlock=%ld.\n", > > > > > > Notably this is still > 80 columns. Maybe? > > > > > > "FvbEraseBlocks: Check if: ( StartingLba=%ld + NumOfLba=%Lu - 1 ) " > > > "> LastBlock=%ld.\n", > > > > This file ("ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c") has > > extremely long lines, the longest one (line 774) has 172 columns. I > > broke up the above DEBUG so that it would at least fit in 120 chars per > > line (which is the "second level" recommendation in the coding spec). > > Personally, I don't agree with that secondary 120 char rule. If we > ever get the style guide into an 'open source' process, I'd like to > suggest removing it. (But, it'll probably get shot down. :\ ) Oh, I'm all for that one. And the style guide is definitely in need of a shake-up. But I consider violating line length restrictions less bad than making user-(or in this case developer)-visible strings harder to search for. > Ah. I guess it is fine for a package maintainer to occasionally decide > to bend the rules for their package. For this to be bending, it would require the 120-character rule to not exist. / Leif