From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x235.google.com (mail-wr0-x235.google.com [IPv6:2a00:1450:400c:c0c::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D6AF521A134BB for ; Mon, 22 May 2017 07:55:37 -0700 (PDT) Received: by mail-wr0-x235.google.com with SMTP id z52so40271628wrc.2 for ; Mon, 22 May 2017 07:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OZJVar/BSzROM+l/6Vdj+9GbBB06TA+2tx+B5M74gK4=; b=Jv2w9A3DOFEytFK/XGAhbyJnm6rumxbdV2ZpH2X7gKOO0R2tLMVXlshzXA1jfrdepB PH4NcgVu/wEgQMcw0Q6cW8fxMkKrxbVFHLkg7WPPt30nrzsHID8j36fbhrPn9anzpFgQ x0sEiEufDp/8oK5XIjGGxCHpceSRp0oVGWIjM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OZJVar/BSzROM+l/6Vdj+9GbBB06TA+2tx+B5M74gK4=; b=pqQjjtMulBwCav5jVe51qgsv8vEDVzHmebXnT3dCcX1M/BxOyT5DJAW6mc/P2I4s5F 9VB8XgVQKpbsbk1y39keoUdPDcqwzNuSgwhXm2KPK9YPXFTtISfC6fi3uHMxKayO8IVT mG0cd/bov63UocsH7YlmGCVLkh/29K0gNno2ziQ1OpE7tmhF5l+Fy+F38v3HNhqlyfqT PvDWLvewfnkXzx4s/cyJA5qAY3kVEmOIBVxCs2LAi7t8nHnmyXTkpYKN63uIM/bePji/ 6ahQxe1cs5N3akTgAv3zUshZM3G0MQqsdb7sVU+H1Ip9vJ9UGd7/cTy3G+HhrGUGbz3I iAwQ== X-Gm-Message-State: AODbwcAs7VPkcSeZyHJxYYnJrNdf3xcqLFG5k/KZnVGXLHxbUcY8bev2 UlemxuFzKeMgX4wl X-Received: by 10.223.173.212 with SMTP id w78mr10755462wrc.144.1495464936122; Mon, 22 May 2017 07:55:36 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u76sm11472731wrb.27.2017.05.22.07.55.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 07:55:35 -0700 (PDT) Date: Mon, 22 May 2017 15:55:33 +0100 From: Leif Lindholm To: evan.lloyd@arm.com Cc: edk2-devel@ml01.01.org, Ard Biesheuvel , Ryan Harkin , Matteo Carlini Message-ID: <20170522145533.GH1657@bivouac.eciton.net> References: <20170516101045.14288-1-evan.lloyd@arm.com> MIME-Version: 1.0 In-Reply-To: <20170516101045.14288-1-evan.lloyd@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/2] Initialize CNTHCTL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 14:55:38 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Evan, Apologies for delay, was off sick last week. On Tue, May 16, 2017 at 11:10:43AM +0100, evan.lloyd@arm.com wrote: > From: Evan > > A pair of minor patches to correct an omission. > This patch set enables timer access as required by the UEFI > specification. > The first patch adds accessors for the register to ArmPkg, > the second fixes the error in ArmPlatofrmPkg. > They are in different packages, but dependent. > As the responsible adults involved are the same, I hope that is > acceptable. More than acceptable, it's preferable (and means we don't break bisect). This looks like a clear fix - thanks. Reviewed-by: Leif Lindholm Pushed as 7320b8e..0e07733. > The code can be examined at: > https://github.com/EvanLloyd/tianocore/tree/initialize_cnthctl_v1 > > > Sami Mujawar (2): > ArmPkg: Add CNTHCTL_EL2 support functions > ArmPlatformPkg: Timer access for non-secure EL1/0 > > ArmPkg/Include/Chipset/AArch64.h | 12 +++++++++++- > ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c | 9 ++++++++- > ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 10 ++++++++++ > ArmPlatformPkg/PrePeiCore/AArch64/Helper.S | 9 ++++++++- > 4 files changed, 37 insertions(+), 3 deletions(-) > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >