From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x241.google.com (mail-qk0-x241.google.com [IPv6:2607:f8b0:400d:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2CB6B21A0BA9C for ; Tue, 23 May 2017 07:12:04 -0700 (PDT) Received: by mail-qk0-x241.google.com with SMTP id o85so22945794qkh.0 for ; Tue, 23 May 2017 07:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jEBB9ZH8UxLju7kATQ9TXGPSCTvfoIx86m1vVhXojxg=; b=V22/MpP1zwYRmYnvFSzD57lSW9uev4z89gXel2c3nRejbi3Be3pZifaHku+H6Dp7xK DP6cbbvqLxdvulDRnLnX5sGNCEMqcxe9llJSHopPNmYXhsjO83mT5DbuVLI8w+1qp89H a/l+FYbo34UQz4lfEFuyie1xo4ZuG/YLU1wfn2OoczEjKO1s1q8tq5E/4V1B2ixThlmr FBGcxp7XoFFoo8pDVkNGbqoqLQ3mB35N2R6DUhB2qQKTCtooTxKHMlLe3xH2vSUrVB0M DhyM7/tvkpgOzhSzPr1ymVZ/HD0fH4wnC20DtwbwWDCWxdMXDQocuS4q8K3+Pd9pOYz2 EztA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jEBB9ZH8UxLju7kATQ9TXGPSCTvfoIx86m1vVhXojxg=; b=sFjiB5r4tNFoPauzZg2PD/+Zcd2cMAgMpVbQOtHIL+Mu4aKl29ovowc35tCOCSGXwx JutZUFl0bOVy7uQtwFSofl123z6BIXJrg4Ei7SoKG/wnQDXjfohh/acRDBB2uZgX+qWq e7vagsXKs+QVmmGmjhkPz1ytTxSfFI291g1nWMY5Yr3WS/lkwBtj17ucvthRcAXOZkGq OlB+bjqIax7C0xCwIjkhAFDFcyfWtpSm8KzwigNPuJ3zM12RLLIm4dcOc1JZL6agzK0W ulwqXq3C2qr+2DOp1KLDeuGLFU2yBOQ7mrjapRgdvR5M8vJK+MkADACwuBeWCsDkeWxh q43Q== X-Gm-Message-State: AODbwcDHwRke9dTzuKmt90La51majYZfC9khSeJVVPozEZ+llgB/2ajO sEdNLlG/qA7r6Q== X-Received: by 10.55.52.13 with SMTP id b13mr29801632qka.28.1495548723227; Tue, 23 May 2017 07:12:03 -0700 (PDT) Received: from localhost.localdomain (209-6-200-48.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.200.48]) by smtp.gmail.com with ESMTPSA id d200sm483207qkg.50.2017.05.23.07.12.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 May 2017 07:12:03 -0700 (PDT) Sender: Konrad Rzeszutek Date: Tue, 23 May 2017 10:12:00 -0400 From: Konrad Rzeszutek Wilk To: Laszlo Ersek , xen-devel@lists.xenproject.org, julien.grall@arm.com, jbeulich@suse.com Cc: Gary Lin , Jordan Justen , edk2-devel-01 Message-ID: <20170523141200.GB29008@localhost.localdomain> References: <20170506193023.4767-1-lersek@redhat.com> <20170508042759.kuut2vueabxvimwk@GaryWorkstation> <20170512020215.jvnmgzvrgdv66ere@GaryWorkstation> <12b9e870-30e4-8b88-9851-771d94264552@redhat.com> <149489525952.434.10185839319642314352@jljusten-skl> <20170516042034.hpf3fllcarzkgomh@GaryWorkstation> <5abcc684-72e4-990b-0682-7c163a7fc9cf@redhat.com> MIME-Version: 1.0 In-Reply-To: <5abcc684-72e4-990b-0682-7c163a7fc9cf@redhat.com> User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Is: Fix for 4MB BIOS payload in hvmloader. Was:Re: [PATCH 0/5] OvmfPkg: complete the 4MB flash image support ("-bios" / emulated variables) X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 May 2017 14:12:04 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Adding Jan (autor of patch) and Julien (Xen release manager); Pls see below. On Thu, May 18, 2017 at 02:36:33PM +0200, Laszlo Ersek wrote: > On 05/16/17 06:20, Gary Lin wrote: > > On Mon, May 15, 2017 at 05:40:59PM -0700, Jordan Justen wrote: > >> On 2017-05-12 01:40:34, Laszlo Ersek wrote: > >>> On 05/12/17 04:02, Gary Lin wrote: > >>>> On Mon, May 08, 2017 at 12:27:59PM +0800, Gary Lin wrote: > >>>>> On Sat, May 06, 2017 at 09:30:18PM +0200, Laszlo Ersek wrote: > >>>>>> (All hail Saturday!) > >>>>>> > >>>>>> Gary, can you please fetch this from my repo (URL & branch name below) > >>>>>> and test it with Xen? Please test both the 4MB and the 2MB build. (I > >>>>>> also tested both, with qemu + "-bios".) > >>>>> Hi Laszlo, > >>>>> > >>>>> I have done some simples test with xen, and the 2MB build seems fine. > >>>>> It booted into grub2 menu successfully. However, the 4MB build never boots. > >>>>> The QEMU window showed less than 1 sec and then disappeared. > >>>>> > >>>>> Here is the snippet from 'xl dmesg' > >>>>> > >>>>> (d15) - CPU0 ... 39-bit phys ... fixed MTRRs ... var MTRRs [1/8] ... done. > >>>>> (d15) Testing HVM environment: > >>>>> (d15) - REP INSB across page boundaries ... passed > >>>>> (d15) - GS base MSRs and SWAPGS ... passed > >>>>> (d15) Passed 2 of 2 tests > >>>>> (d15) Writing SMBIOS tables ... > >>>>> (d15) Loading OVMF ... > >>>>> (d15) no BIOS ROM image found > >>>>> (d15) *** HVMLoader bug at hvmloader.c:381 > >>>>> (d15) *** HVMLoader crashed. > >>>>> > >>>>> I'm pretty sure that the ovmf path is right, so it seems Xen just rejected > >>>>> the 4MB build :-\ > >>>>> > >>>>> I'll try to dig more information. > >>>>> > >>>> There is a function in the xen hvmloader clearing the memory from > >>>> 0x400000 to 0x800000. Unfortunately, the hvm_start_info struct of the > >>>> 4MB OVMF was loaded to 0x588000, so the struct was cleared mistakenly > >>>> and hvmloader cannot find the firmware. Xen is not ready for the 4MB > >>>> build yet :-\ > >>>> > >>>> The discussion in xen-devel: > >>>> https://lists.xen.org/archives/html/xen-devel/2017-05/msg01053.html > >>> > >>> Thank you for the feedback! > >>> > >>> In this case, I think we should drop the last patch from this series. > >> > >> Can we come up with a plan for trying to fix this? Gary, would it be > >> okay if we opened a bug and assigned it to you? Or, do you have > >> another suggestion for a possible Xen owner? > >> > > Jan Beulich (also a SUSE employee) is working on the patch(*), and it > > works for me. > > We should distinguish a TianoCore BZ entry for this, from a Xen bug > report for this. The former would depend on the latter. > > The TianoCore BZ assignee's job would be to monitor the upstream Xen > fix, and to submit the last patch of this series -- separated out -- to > edk2-devel once upstream Xen commits the fix. > > Upstream Xen does not have a bug tracker that is widely used in their > community: > > https://wiki.xen.org/wiki/Reporting_Bugs_against_Xen_Project > > > The primary location for reporting bugs against the hypervisor and > > associated bundled tools [...] is by posting to the xen-devel mailing > > list (list info). Please tag your subject line with a '[BUG]' prefix. > > Note that you do not need to be subscribed to the list to post > > (although non-subscribers are moderated this usually happens pretty > > quickly) and that list policy is to CC people so you shouldn't miss > > any replies. > > > > [...] > > > > Although a bugzilla instance does exist it is not well maintained or > > widely used by developers. If you really want to file a bug in > > bugzilla you are strongly recommended to also post to the mailing > > list. > > This does not make things easier for us, because rather than recurrently > check a simple bug status field in the Xen tracker, we'd have to be > tapped into Xen development, and follow the email thread & any relevant > commits closely. In reality I'm not even subscribed to xen-devel. > > The situation is further hampered by the fact that Xen is (apparently) > right at 4.9.0-rc5, so they likely won't commit Jan's hvmloader patch > until Xen 4.9 is out. This is a problem for a potential TianoCore-side > BZ because the delay will make us forget about the issue. > > Thanks, > Laszlo > > > > > Cheers, > > > > Gary Lin > > > > (*) https://lists.xen.org/archives/html/xen-devel/2017-05/msg01242.html > >> Thanks, > >> > >> -Jordan > >> > >>> > >>> However, your test results also confirm that the 2MB build continues to > >>> work with Xen, which means that the reworking of the > >>> EmuVariableFvbRuntimeDxe driver in this series, and the underlying > >>> tweaks+cleanups series, cause no regression. > >>> > >>> Can you please respond, with your "Regression-tested-by", to: > >>> > >>> (1) the full series > >>> > >>> [edk2] [PATCH 0/7] OvmfPkg: small cleanups and tweaks > >>> > >>> (2) and patches 1 through 3 in this series? (Patch #4 is just > >>> documentation, for which Tested-by would be strange.) > >>> > >>> Thank you! > >>> Laszlo > >>> > >>> > >>>>>> Note: this series depends on: > >>>>>> > >>>>>> [edk2] [PATCH 0/7] OvmfPkg: small cleanups and tweaks > >>>>>> https://lists.01.org/pipermail/edk2-devel/2017-May/010527.html > >>>>>> > >>>>>> and it has been pushed to my github repo as such. > >>>>>> > >>>>>> Repo: https://github.com/lersek/edk2.git > >>>>>> Branch: emu4k > >>>>>> > >>>>>> Cc: Gary Ching-Pang Lin > >>>>>> Cc: Jordan Justen > >>>>>> > >>>>>> Thanks, > >>>>>> Laszlo > >>>>>> > >>>>>> Laszlo Ersek (5): > >>>>>> OvmfPkg/EmuVariableFvbRuntimeDxe: strip trailing whitespace > >>>>>> OvmfPkg/EmuVariableFvbRuntimeDxe: change block size to 4KB > >>>>>> OvmfPkg/PlatformPei: align EmuVariableNvStore at any page boundary > >>>>>> OvmfPkg/README: document 4MB flash layout > >>>>>> OvmfPkg: make the 4MB flash size the default (again) > >>>>>> > >>>>>> OvmfPkg/OvmfPkgIa32.dsc | 2 +- > >>>>>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > >>>>>> OvmfPkg/OvmfPkgX64.dsc | 2 +- > >>>>>> OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.h | 26 ++- > >>>>>> OvmfPkg/EmuVariableFvbRuntimeDxe/Fvb.c | 191 +++++++++----------- > >>>>>> OvmfPkg/PlatformPei/Platform.c | 20 +- > >>>>>> OvmfPkg/README | 39 +++- > >>>>>> 7 files changed, 143 insertions(+), 139 deletions(-) > >>>>>> > >>>>>> -- > >>>>>> 2.9.3 > >>>>>> > >>>>>> > >>>>> _______________________________________________ > >>>>> edk2-devel mailing list > >>>>> edk2-devel@lists.01.org > >>>>> https://lists.01.org/mailman/listinfo/edk2-devel > >>>>> > >>> > >>> _______________________________________________ > >>> edk2-devel mailing list > >>> edk2-devel@lists.01.org > >>> https://lists.01.org/mailman/listinfo/edk2-devel > >> > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel