From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48A5421BB2523 for ; Mon, 12 Jun 2017 08:52:06 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id v111so102335206wrc.3 for ; Mon, 12 Jun 2017 08:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+YHKBc5OlwJ9sD6xD9DdDYVdo6F9g+BmioQ+DhtNoxc=; b=kU6xYXSzZndoT1O7DJ+HGC9lDg/9Vr+VUnUrbx1Gp786lCeL0rFleGAGCyuTXuqHTf t84z5vfeUnB0jVI6ZtNqCEKf2MWlPSL9QSrW7Co/28LdQvNYWxq1vASjz0ZWNBIZ/CRT j5P1ru/2hxXEMZ32VqdxNMcVxugKUnAjGDlOw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+YHKBc5OlwJ9sD6xD9DdDYVdo6F9g+BmioQ+DhtNoxc=; b=SqVshyzJ4LmbHq2hjh77bAHkq47woecjVRscHi76TjFkLpcyo0EfLw71yqPh/5tF8W WVXFFeuHUHWWqCg2230Ea2830Me1lEJyvis2k7PVvqUnUJLiwqTHlCFlPxq3B67dSQPm Vuy8Z+o4hmf6KrBaFOqyYsmKLQx5mWkxi+vt2gxJLEba5Mz0cDX3UWLLp0tDQ340Gq5Q LXDKGUA9oIwodxObv9IKJr+QsavtWAIJk1e7lGcsWR5lpCzvsDbZj9TjF2wapCh7VL+J lPnbfvnRlVC6T3ceQDWeZJYJ5oEGu5GIQhTTxXr50GMjB8RCneBBtgWNeHy6ccO8ymK3 kZrQ== X-Gm-Message-State: AODbwcAHMv6vfkovr6I0GJ4km6nYk7K3Tcc14Z6nCoXcaoiMvQmj/0aQ p5XEMhZySkzh2SN3 X-Received: by 10.223.145.195 with SMTP id 61mr8292704wri.43.1497282798350; Mon, 12 Jun 2017 08:53:18 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s140sm164186wmd.1.2017.06.12.08.53.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jun 2017 08:53:17 -0700 (PDT) Date: Mon, 12 Jun 2017 16:53:15 +0100 From: Leif Lindholm To: Jun Nie Cc: ard.biesheuvel@linaro.org, haojian.zhuang@linaro.org, edk2-devel@lists.01.org, shawn.guo@linaro.org, jason.liu@linaro.org Message-ID: <20170612155315.GK26676@bivouac.eciton.net> References: <1497232768-8993-1-git-send-email-jun.nie@linaro.org> MIME-Version: 1.0 In-Reply-To: <1497232768-8993-1-git-send-email-jun.nie@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v2] EmbeddedPkg/MmcDxe: Add alignment for ECSD data X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 15:52:06 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 12, 2017 at 09:59:28AM +0800, Jun Nie wrote: > Add alignment for ECSD data for DMA access. Otherwise > the data is corrupted on Sanechips platform. I never did see a reply to my proposed solution, and the below is not it. Can you explain why you prefer this one? / Leif > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie > --- > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.h b/EmbeddedPkg/Universal/MmcDxe/Mmc.h > index 8a7d5a3..6e3ab17 100644 > --- a/EmbeddedPkg/Universal/MmcDxe/Mmc.h > +++ b/EmbeddedPkg/Universal/MmcDxe/Mmc.h > @@ -319,6 +319,7 @@ typedef struct { > OCR OCRData; > CID CIDData; > CSD CSDData; > + UINT64 Pad; // For 8 bytes alignment of ECSDData > ECSD ECSDData; // MMC V4 extended card specific > } CARD_INFO; > > -- > 1.9.1 >