[PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7

[PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7

[Hao Wu]

This commit updates the Firmware Error Record related definitions
according to UEFI 2.7 spec Section N.2.10 Table 281:

a. Adds definitions for 2 Firmware Error Record types
b. Update the structure EFI_FIRMWARE_ERROR_DATA

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdePkg/Include/Guid/Cper.h | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
index 88e3a5874f..5ddd4c715e 100644
--- a/MdePkg/Include/Guid/Cper.h
+++ b/MdePkg/Include/Guid/Cper.h
@@ -1,7 +1,7 @@
 /** @file
   GUIDs and definitions used for Common Platform Error Record.
 
-  Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -12,7 +12,7 @@
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
   @par Revision Reference:
-  GUIDs defined in UEFI 2.6 Specification.
+  GUIDs defined in UEFI 2.7 Specification.
 
 **/
 
@@ -1088,16 +1088,21 @@ typedef struct {
 
 ///
 /// Identifies the type of firmware error record
-///
+///@{
 #define EFI_FIRMWARE_ERROR_TYPE_IPF_SAL              0x00
+#define EFI_FIRMWARE_ERROR_TYPE_SOC_TYPE1            0x01
+#define EFI_FIRMWARE_ERROR_TYPE_SOC_TYPE2            0x02
+///@}
 
 ///
 /// Firmware Error Record Section
 ///
 typedef struct {
   UINT8       ErrorType;
-  UINT8       Resv1[7];
+  UINT8       Revision;
+  UINT8       Resv1[6];
   UINT64      RecordId;
+  EFI_GUID    RecordIdGuid;
 } EFI_FIRMWARE_ERROR_DATA;
 
 ///
-- 
2.12.0.windows.1

Re: [PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Wu, Hao A
>Sent: Thursday, June 15, 2017 9:06 AM
>To: edk2-devel@lists.01.org
>Cc: Wu, Hao A <hao.a.wu@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
>Subject: [PATCH] MdePkg/Cper.h: Update Firmware Error Record per UEFI 2.7
>
>This commit updates the Firmware Error Record related definitions
>according to UEFI 2.7 spec Section N.2.10 Table 281:
>
>a. Adds definitions for 2 Firmware Error Record types
>b. Update the structure EFI_FIRMWARE_ERROR_DATA
>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Hao Wu <hao.a.wu@intel.com>
>---
> MdePkg/Include/Guid/Cper.h | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
>diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
>index 88e3a5874f..5ddd4c715e 100644
>--- a/MdePkg/Include/Guid/Cper.h
>+++ b/MdePkg/Include/Guid/Cper.h
>@@ -1,7 +1,7 @@
> /** @file
>   GUIDs and definitions used for Common Platform Error Record.
>
>-  Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
>+  Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
>   (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>   This program and the accompanying materials
>   are licensed and made available under the terms and conditions of the BSD
>License
>@@ -12,7 +12,7 @@
>   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
>EXPRESS OR IMPLIED.
>
>   @par Revision Reference:
>-  GUIDs defined in UEFI 2.6 Specification.
>+  GUIDs defined in UEFI 2.7 Specification.
>
> **/
>
>@@ -1088,16 +1088,21 @@ typedef struct {
>
> ///
> /// Identifies the type of firmware error record
>-///
>+///@{
> #define EFI_FIRMWARE_ERROR_TYPE_IPF_SAL              0x00
>+#define EFI_FIRMWARE_ERROR_TYPE_SOC_TYPE1            0x01
>+#define EFI_FIRMWARE_ERROR_TYPE_SOC_TYPE2            0x02
>+///@}
>
> ///
> /// Firmware Error Record Section
> ///
> typedef struct {
>   UINT8       ErrorType;
>-  UINT8       Resv1[7];
>+  UINT8       Revision;
>+  UINT8       Resv1[6];
>   UINT64      RecordId;
>+  EFI_GUID    RecordIdGuid;
> } EFI_FIRMWARE_ERROR_DATA;
>
> ///
>--
>2.12.0.windows.1