From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x235.google.com (mail-wr0-x235.google.com [IPv6:2a00:1450:400c:c0c::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4C99E2095D205 for ; Wed, 21 Jun 2017 05:41:11 -0700 (PDT) Received: by mail-wr0-x235.google.com with SMTP id c11so78035181wrc.3 for ; Wed, 21 Jun 2017 05:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B1ACkjIpgrtsolKS+vzM/MoGBBDGoL4X2jyM1LWKAb4=; b=gcuMDUXwarrR9+QXq5X90hVXeI4KszW78yxlCr2XoQ0qxppWoZqCuYG13ZDHOOEs/J AmjnmBvmhA3Slv/AsFRAW9ETavICL/UYkU9/0pgsiFbLvNDPDeHseO1PtXh/Gkc3T+Y1 gqd/7MCi1c2nmxpyPu20jQi8eDNQXlQm6A4xE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B1ACkjIpgrtsolKS+vzM/MoGBBDGoL4X2jyM1LWKAb4=; b=jUBc692qMwlqTYZIqdHT6bvL2yDf3OLWC+uAXpi+pAPOlrmfrj7qiJ78IMCQ2ZQ6L1 KjJt62ct7bIM0pip86IWPOfjlb2wABj7YWr0uaB/CwHyNNQ54pMc7TFdbXfxJWbRQpVP 2HCMQnLBzx0eB+K9WPYDGYchw+IYjjBL3joogdf1HIMS8xUcYUT/wJjTIJIADP8Mvhy8 CouC0y9SGeh5VifP8gRqQhuvTZ+3KKmJRYVpaHFwnfiJgu271XohIrBHPCSe93DRpzdV Sf48rLlaw2hyrAzrhZ8egMkCxDmXieXZnsKNVDcgBhvMAnHOkNwB3uf1xDGIeBSnpyjv hC9Q== X-Gm-Message-State: AKS2vOzQW1lpXOcg7RsEsj4CNm31XGuKTqXvEbKmqXmGpVUYEejgOR/B Vhi34t3ERcpvk+H1 X-Received: by 10.28.6.77 with SMTP id 74mr6348461wmg.96.1498048953791; Wed, 21 Jun 2017 05:42:33 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f15sm12411869wmf.22.2017.06.21.05.42.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2017 05:42:33 -0700 (PDT) Date: Wed, 21 Jun 2017 13:42:31 +0100 From: Leif Lindholm To: Ard Biesheuvel Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Message-ID: <20170621124231.GF26676@bivouac.eciton.net> References: <1497984234-19871-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 1/2] BaseTools/tools_def GCC: ARM/AARCH64: replace -save-temps with -pipe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 12:41:11 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 21, 2017 at 01:31:15PM +0200, Ard Biesheuvel wrote: > > "-pipe" isn't used anywhere else in "tools_def.template". Can we imagine > > a platform where cross-compiling to aarch64 with gcc works otherwise, > > but "-pipe" might break that? Cygwin perhaps? (No clue, honestly.) > > > > For consistency with the rest of "tools_def.template", I'd suggest > > simply dropping "-save-temps", and thinking about "-pipe" separately > > (and then for all the GCC toolchains and for all arches). But, I don't > > feel particularly strongly about this. > > > > Yeah, that's a fair point. The fact that -save-temps is specific to > ARM does not mean we should perpetuate that with -pipe. > > Leif, if you agree, I will drop the addition of -pipe from this patch, > and we can revisit it later for all GCC flavors. Much as I would like to find out if there really are any platforms that still have issues with -pipe (in which case, why wouldn't GCC just use temp files anyway?), I guess that is a sensible approach. Reviewed-by: Leif Lindholm for the dropping of -save-temps. / Leif