From: Leif Lindholm <leif.lindholm@linaro.org>
To: Jun Nie <jun.nie@linaro.org>
Cc: ard.biesheuvel@linaro.org, haojian.zhuang@linaro.org,
edk2-devel@lists.01.org, shawn.guo@linaro.org,
jason.liu@linaro.org
Subject: Re: [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read
Date: Thu, 29 Jun 2017 13:09:36 +0100 [thread overview]
Message-ID: <20170629120935.GS26676@bivouac.eciton.net> (raw)
In-Reply-To: <1498726925-25860-1-git-send-email-jun.nie@linaro.org>
On Thu, Jun 29, 2017 at 05:02:05PM +0800, Jun Nie wrote:
> The argument of CMD8 should be stuff bits according to standard
> JESD84-A44.
OK, I realise that "stuff bits" is a term used by the spec, so that is
probably sufficient explanation even though the term was known to me.
And the MdeModulePkg driver seems to agree on the technical point.
My question is why zeroes is the correct "stuff bits" value?
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
> EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> index 4ce0ddd..c28207e 100644
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> @@ -210,7 +210,7 @@ EmmcIdentificationMode (
> }
>
> // Fetch ECSD
> - Status = Host->SendCommand (Host, MMC_CMD8, RCA);
> + Status = Host->SendCommand (Host, MMC_CMD8, 0);
> if (EFI_ERROR (Status)) {
> DEBUG ((EFI_D_ERROR, "EmmcIdentificationMode(): ECSD fetch error, Status=%r.\n", Status));
> }
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-06-29 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:02 [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read Jun Nie
2017-06-29 12:09 ` Leif Lindholm [this message]
2017-06-29 14:29 ` Jun Nie
2017-06-29 15:57 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629120935.GS26676@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox