From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C61421B02B8C for ; Thu, 29 Jun 2017 05:08:07 -0700 (PDT) Received: by mail-wr0-x231.google.com with SMTP id 77so188481292wrb.1 for ; Thu, 29 Jun 2017 05:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=t7QZLLGC/2hhpYSUloos42j0zAsRinlqH91DOK4aato=; b=PVup/mcsrhMM39RvUve7tFCA0DVZwW0E5QdlYMaYQzklBlxshYe6CqHTJRG0e1skyg HoW3CP5RwfDf6EeTicPKSTP34iGiki4/eiet+R3Vl3JiIfJ9KAqmJnkGdWN0uXlXA0GP FTnjHkae5DOipJsYYAv5Xm+ZPRqOFMdWTbngE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=t7QZLLGC/2hhpYSUloos42j0zAsRinlqH91DOK4aato=; b=NHM1sks5w70x0TaQPT+b1aNDtCUJPINUhvGJbUixvqckEvlS5h9gH1gzjvFQk5YnUI 2ZrOxqs88Pn1ZKA8BdM0UF8fpJE7pYcYoh5TkZDVLL5iO1FpcGYZPKtCVYIVRYLDQMtP YySBlWemL6fEFlUUv9fy9YGDUlvPOq+qK5qvd4lhwIq9YrXnAPDPLGo2y0uKP9f+R2bT zmSW25WEBlOG6LWHR3o3O43Ee4EelAJ4ADKjRr9Rr3akphlDSNSp8XDG1IZltA/t3mSo N9vbG0m/uL8xZUTtuFYmKcUBLx/yu4bFfLgTs22ibPxxCfJTuDAKVNkEZi887HPBq9dS mNYQ== X-Gm-Message-State: AKS2vOx20szJ/ZpQwZNc2bDoZrPMK4VPm818Jpjfn/aF7Flrq6dYxila mK3UBXCRWQNOROnw X-Received: by 10.223.165.10 with SMTP id i10mr24374937wrb.59.1498738178239; Thu, 29 Jun 2017 05:09:38 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w197sm9217266wme.20.2017.06.29.05.09.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jun 2017 05:09:37 -0700 (PDT) Date: Thu, 29 Jun 2017 13:09:36 +0100 From: Leif Lindholm To: Jun Nie Cc: ard.biesheuvel@linaro.org, haojian.zhuang@linaro.org, edk2-devel@lists.01.org, shawn.guo@linaro.org, jason.liu@linaro.org Message-ID: <20170629120935.GS26676@bivouac.eciton.net> References: <1498726925-25860-1-git-send-email-jun.nie@linaro.org> MIME-Version: 1.0 In-Reply-To: <1498726925-25860-1-git-send-email-jun.nie@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] EmbeddedPkg/MmcDxe: Correct argument of ECSD read X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 12:08:07 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 29, 2017 at 05:02:05PM +0800, Jun Nie wrote: > The argument of CMD8 should be stuff bits according to standard > JESD84-A44. OK, I realise that "stuff bits" is a term used by the spec, so that is probably sufficient explanation even though the term was known to me. And the MdeModulePkg driver seems to agree on the technical point. My question is why zeroes is the correct "stuff bits" value? > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie > --- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > index 4ce0ddd..c28207e 100644 > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > @@ -210,7 +210,7 @@ EmmcIdentificationMode ( > } > > // Fetch ECSD > - Status = Host->SendCommand (Host, MMC_CMD8, RCA); > + Status = Host->SendCommand (Host, MMC_CMD8, 0); > if (EFI_ERROR (Status)) { > DEBUG ((EFI_D_ERROR, "EmmcIdentificationMode(): ECSD fetch error, Status=%r.\n", Status)); > } > -- > 1.9.1 >