From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3758121CF3B70 for ; Mon, 3 Jul 2017 05:08:10 -0700 (PDT) Received: by mail-wr0-x22a.google.com with SMTP id 77so233327211wrb.1 for ; Mon, 03 Jul 2017 05:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=diM9UiCQUgZnqdObBUrIBU3xdWzD0Yt4ucTB8vJULgo=; b=eArOvSBH2rIlnpqR/k4Ht5InNjZa3onga/5mcrcP+x4+Jvdgc/ujw2NaLThcSXd4G9 3GmmcsryN6w+HxOOP6/BGrR//B5/jxdlXCCCzLN+PQ77tnLPUu93fsjdAbom8nPqG8cb rHI2YnHGPhdJBqyBhrqmzAe95iZW2NkrgPa/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=diM9UiCQUgZnqdObBUrIBU3xdWzD0Yt4ucTB8vJULgo=; b=Hl5axwFzxDAwCyC3RdcrOBgqcSZcKbdh/SfKC9srOl1M0dIIgel7lG1RrNFxhtdw7d jIUJo/SfVTGQmT2U+BeGnuaR0ITWgWDIaIKl260GsD+Tkn2vJFufmz2jvpH8mWM9jzpe nH5Bpj0v43jXxylg9hSTn+FSCtAnHcP+LTylFHHHmGEyU+krx/V/RpqfpC0mh8RL3L6f BDiZMKRUmYYeN9oinOYlQkHQTNtIOTElSHAW9hIgY0hABy9oI7xy8a1Youz7UGTGBdhy kJCi9217WnGlH62r4GIEH56OsQpCS9VwzywG2/rDJddtCCr9INPeNPZc42lTeXQybdxn +IEQ== X-Gm-Message-State: AKS2vOxxIsgjlEU5rA8BvFCcWMKjZ3ttR8YPX8zjSeqvTQyXdedkry1C iHtWhnsK4FVk474j X-Received: by 10.223.139.87 with SMTP id v23mr31487451wra.145.1499083785579; Mon, 03 Jul 2017 05:09:45 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s65sm6788524wmb.7.2017.07.03.05.09.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2017 05:09:44 -0700 (PDT) Date: Mon, 3 Jul 2017 13:09:43 +0100 From: Leif Lindholm To: Laszlo Ersek Cc: Ard Biesheuvel , Ruiyu Ni , edk2-devel@lists.01.org, Hao Wu , "Jordan Justen (Intel address)" , Andrew Fish Message-ID: <20170703120943.GD26676@bivouac.eciton.net> References: <20170629083221.485184-1-ruiyu.ni@intel.com> <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> MIME-Version: 1.0 In-Reply-To: <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 12:08:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote: > Ard, Leif, > > On 06/29/17 10:32, Ruiyu Ni wrote: > > Ruiyu Ni (3): > > MdePkg: Add ResetNotification protocol definition > > MdeModulePkg/ResetSystem: Remove unnecessary global variable > > MdeModulePkg/ResetSystem: Implement ResetNotification protocol > > > > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 +++++++++++++++++++-- > > .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 ++- > > .../ResetSystemRuntimeDxe.inf | 5 +- > > MdePkg/Include/Protocol/ResetNotification.h | 86 ++++++++++++ > > MdePkg/MdePkg.dec | 3 + > > 5 files changed, 247 insertions(+), 14 deletions(-) > > create mode 100644 MdePkg/Include/Protocol/ResetNotification.h > > > > I think we should > - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe, > - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe > to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete > EmbeddedPkg/ResetRuntimeDxe from the tree. > > What do you guys think? I think deleting the EmbeddedPkg one, and making the current consumers implement ResetSystemLib instead of EfiResetSystemLib would be an improvement. At a quick skim, the only functionality I can see added in EmbeddedPkg/ResetRuntimeDxe is the LibInitializeResetSystem function. The only (ARM) platform I can see doing anything useful there is the Armada ... and that code could move. / Leif > Other producers of gEfiResetArchProtocolGuid could be affected as well > (just from a quick grep): > - DuetPkg/AcpiResetDxe > - EmulatorPkg/ResetRuntimeDxe > - Nt32Pkg/ResetRuntimeDxe > > Thanks > Laszlo