From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F9AB209455E7 for ; Tue, 4 Jul 2017 04:39:52 -0700 (PDT) Received: by mail-wm0-x234.google.com with SMTP id f67so81851188wmh.1 for ; Tue, 04 Jul 2017 04:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Zga3AzXEdERLvQa8qF0OYKWprUa54yKEa/Qn6sBAg8o=; b=aND/jSk/CrQ5fqZltJKL6FevrNvuzkh1UB1FIB2ftQkWxamP8e1nR1kWiFPeRXUB/g acUnnufq/C1dtdEQE5tY9C054f0RIicsj99eKokB5kA6vT/9k7AKjEqeeQrJ5Yo+0J16 yz86diowopSmi3FiNTDqQPfL6309XUSwGsv7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Zga3AzXEdERLvQa8qF0OYKWprUa54yKEa/Qn6sBAg8o=; b=AzcuG5PRXjLTue0Tb7yYl6YIAIhLWbOg39ndW1CeuQuAnCbmJszk2aSd5JeAZ8s6x3 Sjz5Y/W+PqnbKb0s3o9wP5mLLddYRdx3BFhjjkTf44SUpKqdEKrJaDn0q5h2RtvScmk+ u0h35ApGar5jQhxxttDaG9Llv35f0gdmv30fUbXcziiNnU5rEj+4OoJWjr2P1NxA44ZC xNS24/cOYzxNemS0IGKBQfgrZL2+Xtvsis9UqTo0k5yFfvnhEg7EHU/5ZtD2pqA8nYXn O1KYcR379jcNr3tgmWE2eeqJqJuhiz5v6gIGu4xHI1bGxeiGlS0kMuTPjsbgW5LIy4he mIQg== X-Gm-Message-State: AKS2vOzVmIJsbDrNKXWAYn4SNu1uUjOD1cmjwAMMXmkYsu4UzhzjUrTO T2qJh0socvN8FdNB X-Received: by 10.28.135.79 with SMTP id j76mr25345616wmd.27.1499168488947; Tue, 04 Jul 2017 04:41:28 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d69sm10523351wmd.23.2017.07.04.04.41.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 04:41:28 -0700 (PDT) Date: Tue, 4 Jul 2017 12:41:26 +0100 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel Message-ID: <20170704114126.GN26676@bivouac.eciton.net> References: <20170704110017.32042-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:39:52 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 04, 2017 at 01:19:10PM +0200, Marcin Wojtas wrote: > 2017-07-04 13:10 GMT+02:00 Ard Biesheuvel : > > On 4 July 2017 at 12:04, Marcin Wojtas wrote: > >> Hi, > >> > >> 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel : > >>> Switch to the generic implementation of the ResetSystem() runtime > >>> service call, which is preferred over the one in EmbeddedPkg. This > >>> involves selecting another DXE runtime driver, and morphing the > >>> existing EfiResetSystemLib implementation into a ResetSystemLib one > >>> (which is what the generic driver depends on for platform glue) > >>> > >>> Contributed-under: TianoCore Contribution Agreement 1.0 > >>> Signed-off-by: Ard Biesheuvel > >>> --- > >>> Platforms/Marvell/Armada/Armada.dsc.inc | 4 +- > >>> Platforms/Marvell/Armada/Armada70x0.fdf | 2 +- > >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c | 110 ++++++++++++++------ > >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf | 7 +- > >>> 4 files changed, 87 insertions(+), 36 deletions(-) > >>> > >>> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc > >>> index 475fc6d05379..32eaa2942564 100644 > >>> --- a/Platforms/Marvell/Armada/Armada.dsc.inc > >>> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc > >>> @@ -94,7 +94,7 @@ > >>> # Reset and Time libraries > >>> EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf > >>> RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf > >>> - EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf > >>> + ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf > >> > >> Isn't it better to switch to generic PSCI: > >> EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf > >> and remove MvResetSystemLib whatsoever? > >> > > > > Yes. But Leif tells me that 7040 does not support PSCI? > > Leif, where do you have this information from? >>From the source code in OpenPlatformPkg, which does not use it and the documentation that does not mention it. If this is incorrect, please submit patches to make the code in the tree reflect reality. / Leif