From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x236.google.com (mail-wr0-x236.google.com [IPv6:2a00:1450:400c:c0c::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6BBAE21CB030D for ; Tue, 18 Jul 2017 09:04:10 -0700 (PDT) Received: by mail-wr0-x236.google.com with SMTP id y43so35673679wrd.3 for ; Tue, 18 Jul 2017 09:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rgUBy3lQWX15YOVq6CyRS9n+hp3Kp/+LfoR2VFYnh98=; b=hVlC5Tv2weTB3geWYOMpqcyNv7A/qiWJYS0WKTIRftQ7CVkKqmm1odR8b0vLF48KV+ jPRenm44M+CKxm7iBZniEjvi2Ibk4OVsMj+xynfyDdF0Hec6ZdvMHLveJ+QkeacPHQR2 +Ty0HPt1BFnnoyJhR6+cODi5fd0H+zXmjWLQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rgUBy3lQWX15YOVq6CyRS9n+hp3Kp/+LfoR2VFYnh98=; b=egPblICx5v6LktOkfJob0wahfGcSAueXE0S5ha2QEDzptAOUeGGz4MUO8h6xs22A43 h1VZED6XWAYNUv+3BrdCOe8SuCshoKxj9JTjo0xRkJ4DRJcPALErnnUUhspmrLLQkd3s 5sE/rvENmYOxpMsQqaZO8qs7ucN5Fs9MBla4wWWZuzt1v2rIlZSNPXX/I8wW0lVA7nxn g8CMyoXj3mTsaETQ6YK30AVmUElb0Z+xMkXxQLpU3Z6/xDoPSr/VpbBH9nyauPqDR85f kKsQw67Bii1eiolGVc21V/nTiynyahYhqt05bjvTbM57dQ24f//fZO1wxzwDhIuuvvRH V/Iw== X-Gm-Message-State: AIVw113P98j2Hx+Q9UwWx2ftYIrCMtmhU22K6c9QZos9vAEeBKrCb7Au ZpQFkqyJcZRVZHby X-Received: by 10.28.128.215 with SMTP id b206mr2450144wmd.88.1500393962781; Tue, 18 Jul 2017 09:06:02 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 33sm1817682wrr.58.2017.07.18.09.06.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2017 09:06:02 -0700 (PDT) Date: Tue, 18 Jul 2017 17:06:00 +0100 From: Leif Lindholm To: Jun Nie Cc: haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, shawn.guo@linaro.org, jason.liu@linaro.org Message-ID: <20170718160600.GS26676@bivouac.eciton.net> References: <1499347746-16786-1-git-send-email-jun.nie@linaro.org> <1499347746-16786-2-git-send-email-jun.nie@linaro.org> MIME-Version: 1.0 In-Reply-To: <1499347746-16786-2-git-send-email-jun.nie@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v2 2/2] EmbeddedPkg: add Android boot device path and guid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 16:04:10 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 06, 2017 at 09:29:06PM +0800, Jun Nie wrote: > The device path specifies where to load android boot image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie No objections to this one, once you fix the token issue you identified yourself. Reviewed-by: Leif Lindholm > --- > EmbeddedPkg/EmbeddedPkg.dec | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > index 4cd528a..cf89af2 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dec > +++ b/EmbeddedPkg/EmbeddedPkg.dec > @@ -80,6 +80,7 @@ > gAndroidFastbootPlatformProtocolGuid = { 0x524685a0, 0x89a0, 0x11e3, {0x9d, 0x4d, 0xbf, 0xa9, 0xf6, 0xa4, 0x03, 0x08}} > gUsbDeviceProtocolGuid = { 0x021bd2ca, 0x51d2, 0x11e3, {0x8e, 0x56, 0xb7, 0x54, 0x17, 0xc7, 0x0b, 0x44 }} > gPlatformGpioProtocolGuid = { 0x52ce9845, 0x5af4, 0x43e2, {0xba, 0xfd, 0x23, 0x08, 0x12, 0x54, 0x7a, 0xc2 }} > + gAbootimgProtocolGuid = { 0x9859bb19, 0x407c, 0x4f8b, {0xbc, 0xe1, 0xf8, 0xda, 0x65, 0x65, 0xf4, 0xa5 }} > > [PcdsFeatureFlag.common] > gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|FALSE|BOOLEAN|0x00000001 > @@ -181,6 +182,7 @@ > gEmbeddedTokenSpaceGuid.PcdAndroidFastbootUsbProductId|0xbeef|UINT32|0x00000023 > gEmbeddedTokenSpaceGuid.PcdAndroidFastbootTcpPort|1234|UINT32|0x00000024 > > + gEmbeddedTokenSpaceGuid.PcdAndroidBootDevicePath|L""|VOID*|0x00000025 > > [PcdsFixedAtBuild.ARM] > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|32|UINT8|0x00000010 > -- > 1.9.1 >