* [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify
@ 2017-07-19 9:14 Ruiyu Ni
2017-07-26 4:54 ` Gao, Liming
0 siblings, 1 reply; 2+ messages in thread
From: Ruiyu Ni @ 2017-07-19 9:14 UTC (permalink / raw)
To: edk2-devel; +Cc: Liming Gao
UEFI Spec uses UnRegisterResetNotify in protocol structure
definition but uses UnregisterResetNotify in the function
prototype definition.
By searching the entire spec, Unregister* is used for
SIMPLE_TEXT_INPUT_EX_PROTOCOL.UnregisterKeyNotify(). So choose
to use UnregisterResetNotify for consistency.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
MdePkg/Include/Protocol/ResetNotification.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/Protocol/ResetNotification.h b/MdePkg/Include/Protocol/ResetNotification.h
index ade0eee34a..f2834f9ee1 100644
--- a/MdePkg/Include/Protocol/ResetNotification.h
+++ b/MdePkg/Include/Protocol/ResetNotification.h
@@ -76,7 +76,7 @@ EFI_STATUS
typedef struct _EFI_RESET_NOTIFICATION_PROTOCOL {
EFI_REGISTER_RESET_NOTIFY RegisterResetNotify;
- EFI_UNREGISTER_RESET_NOTIFY UnRegisterResetNotify;
+ EFI_UNREGISTER_RESET_NOTIFY UnregisterResetNotify;
} EFI_RESET_NOTIFICATION_PROTOCOL;
--
2.12.2.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify
2017-07-19 9:14 [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify Ruiyu Ni
@ 2017-07-26 4:54 ` Gao, Liming
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2017-07-26 4:54 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Ni, Ruiyu
>Sent: Wednesday, July 19, 2017 5:15 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [PATCH] MdePkg/ResetNotification: Rename to
>UnregisterResetNotify
>
>UEFI Spec uses UnRegisterResetNotify in protocol structure
>definition but uses UnregisterResetNotify in the function
>prototype definition.
>
>By searching the entire spec, Unregister* is used for
>SIMPLE_TEXT_INPUT_EX_PROTOCOL.UnregisterKeyNotify(). So choose
>to use UnregisterResetNotify for consistency.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> MdePkg/Include/Protocol/ResetNotification.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdePkg/Include/Protocol/ResetNotification.h
>b/MdePkg/Include/Protocol/ResetNotification.h
>index ade0eee34a..f2834f9ee1 100644
>--- a/MdePkg/Include/Protocol/ResetNotification.h
>+++ b/MdePkg/Include/Protocol/ResetNotification.h
>@@ -76,7 +76,7 @@ EFI_STATUS
>
> typedef struct _EFI_RESET_NOTIFICATION_PROTOCOL {
> EFI_REGISTER_RESET_NOTIFY RegisterResetNotify;
>- EFI_UNREGISTER_RESET_NOTIFY UnRegisterResetNotify;
>+ EFI_UNREGISTER_RESET_NOTIFY UnregisterResetNotify;
> } EFI_RESET_NOTIFICATION_PROTOCOL;
>
>
>--
>2.12.2.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-26 4:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-19 9:14 [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify Ruiyu Ni
2017-07-26 4:54 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox