From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DF9EC21D09192 for ; Mon, 31 Jul 2017 22:45:37 -0700 (PDT) Received: from hegdenag.asiapacific.hpqcorp.net (unknown [15.146.47.50]) by g2t2352.austin.hpe.com (Postfix) with ESMTP id 590EA6D; Tue, 1 Aug 2017 05:47:44 +0000 (UTC) From: hegdenag To: edk2-devel@lists.01.org Cc: jaben.carsey@intel.com, sriram-s@hpe.com, ruiyu.ni@intel.com, jiaxin.wu@intel.com Date: Tue, 1 Aug 2017 11:17:42 +0530 Message-Id: <20170801054742.23300-1-nagaraj-p.hegde@hpe.com> X-Mailer: git-send-email 2.13.0.windows.1 Subject: [PATCH v1 1/1] ShellPkg/Ifconfig6: Update error message and add a new line X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 05:45:38 -0000 If DAD failed, we print "It failed to set", print the IPv6 address and exit. We need a better error string and also, after printing the IPv6 address, we need a new line else the Shell> prompt will overwrite the IPv6 address. Fixed these issues in this patch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hegde Nagaraj P --- ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 2 ++ ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c index 6d8df8031b..a25d4e5d00 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c @@ -2,6 +2,7 @@ The implementation for Shell command IfConfig6. Copyright (c) 2016, Intel Corporation. All rights reserved.
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -1490,6 +1491,7 @@ IfConfig6SetInterfaceInfo ( &CfgManAddr[Index].Address, &CfgManAddr[Index].PrefixLength ); + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_IFCONFIG6_INFO_NEWLINE), gShellNetwork2HiiHandle); } } diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni index 5c0fef0ff7..ee2f28717f 100644 --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.uni @@ -2,6 +2,7 @@ String definitions for UEFI Shell network 2 commands Copyright (c) 2016, Intel Corporation. All rights reserved.
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP
This program and the accompanying materials are licensed and made available under the terms and conditions @@ -92,7 +93,7 @@ "Hint: Please type 'IfConfig6 -?' for help info.\r\n" #string STR_IFCONFIG6_ERR_UNKNOWN_COMMAND #language en-US "Unknown commands. Bad command %H%s%N is skipped.\r\n" "Hint: Please type 'IfConfig6 -?' for help info.\r\n" -#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "It failed to set .\r\n" +#string STR_IFCONFIG6_ERR_ADDRESS_FAILED #language en-US "Failed to configure IPv6 address: " #string STR_GET_HELP_PING6 #language en-US "" -- 2.13.0.windows.1