From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E9F421E1DAFC for ; Tue, 1 Aug 2017 07:57:31 -0700 (PDT) Received: by mail-wm0-x229.google.com with SMTP id k20so23543381wmg.0 for ; Tue, 01 Aug 2017 07:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2hnyuXrorI5NZa/C2E4hA3SJOw166BWVugD0LlwHE78=; b=GMlLW3U5qI502qGULh/sC0nsf4OkRMmdImox0cnLUd9z0GquNgxSFlotrPOmO9E+PQ OOZJjP0egDojr/uFNxHQJ2gGJfXQ2NGBIeAwCgIXT7UbXpBW04+kZ2Nju9tVaUx1/2yy e8v1SF1iwJeO2ynDmKLiAVUZFmBNax14tflEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2hnyuXrorI5NZa/C2E4hA3SJOw166BWVugD0LlwHE78=; b=cUuMhaU7xJ/oz/fQHoIGMB2toV4gHxOU4/WdrcqVJobp4D3e/0S4y+HSkJ8K+wm+dZ rhH0cm9PlLUK35KtuMXwhuLVFFGpa5VqPgiCiPeOmGcPJBmL0mypIGFjBNU6CfEPC34w 1IvE8Ije0b0VV08NF8Z+4jEjwp+DoFdGJ3GQ6a2af3FD+OoMjF6Q1bsOs+vHHzxufFh7 sgFGsyJIEDqF9Rg0q4W7o1gf/TBfisDlJTL1/+guANEOaV1IEQBGjxgabAhFM+w4HzNB 4Q7R28shjo2ucc7dnNKrSYhuK+tjK1DRsE+820VRznMDYwMoqNOSwAMmy3KqUsmlJ/t7 YqLQ== X-Gm-Message-State: AIVw113BZup3BZVoYmtRJbdNYpnGs6/3GaCkIYDPFKpVfG0pDPFZEdxk Dqo49zvW/sKR80KC X-Received: by 10.28.232.141 with SMTP id f13mr1608017wmi.59.1501599579087; Tue, 01 Aug 2017 07:59:39 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j29sm14191903wrb.9.2017.08.01.07.59.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 07:59:38 -0700 (PDT) Date: Tue, 1 Aug 2017 15:59:36 +0100 From: Leif Lindholm To: Jun Nie Cc: haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, shawn.guo@linaro.org, jason.liu@linaro.org Message-ID: <20170801145936.GB26462@bivouac.eciton.net> References: <1501579741-28866-1-git-send-email-jun.nie@linaro.org> MIME-Version: 1.0 In-Reply-To: <1501579741-28866-1-git-send-email-jun.nie@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v4 1/4] ArmPkg: Move IS_DEVICE_PATH_NODE for sharing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 14:57:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 01, 2017 at 05:28:58PM +0800, Jun Nie wrote: > Move IS_DEVICE_PATH_NODE into header to share it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie Reviewed-by: Leif Lindholm Pushed as edc65fc4d8. > --- > ArmPkg/Include/Library/BdsLib.h | 3 +++ > ArmPkg/Library/BdsLib/BdsFilePath.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ArmPkg/Include/Library/BdsLib.h b/ArmPkg/Include/Library/BdsLib.h > index c58f47e..4528c2e 100644 > --- a/ArmPkg/Include/Library/BdsLib.h > +++ b/ArmPkg/Include/Library/BdsLib.h > @@ -15,6 +15,9 @@ > #ifndef __BDS_ENTRY_H__ > #define __BDS_ENTRY_H__ > > +#define IS_DEVICE_PATH_NODE(node,type,subtype) \ > + (((node)->Type == (type)) && ((node)->SubType == (subtype))) > + > /** > This is defined by the UEFI specs, don't change it > **/ > diff --git a/ArmPkg/Library/BdsLib/BdsFilePath.c b/ArmPkg/Library/BdsLib/BdsFilePath.c > index f9d8c4c..41557bb 100644 > --- a/ArmPkg/Library/BdsLib/BdsFilePath.c > +++ b/ArmPkg/Library/BdsLib/BdsFilePath.c > @@ -24,9 +24,6 @@ > #include > #include > > - > -#define IS_DEVICE_PATH_NODE(node,type,subtype) (((node)->Type == (type)) && ((node)->SubType == (subtype))) > - > /* Type and defines to set up the DHCP4 options */ > > typedef struct { > -- > 1.9.1 >