From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x229.google.com (mail-wr0-x229.google.com [IPv6:2a00:1450:400c:c0c::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 888022095DB8D for ; Tue, 1 Aug 2017 09:17:46 -0700 (PDT) Received: by mail-wr0-x229.google.com with SMTP id f21so8821413wrf.5 for ; Tue, 01 Aug 2017 09:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/2t0ybMsC+bp4wB69zKhzB1P3laG1AVoM2rvof1QopI=; b=aaAZhahlcBmYtzeto5FLiMZ/uK+wPTc4/JGemaB2OPBmvirYOFeLMSa+0AZ3TRsPQU eGVwH1B9zG9GrrpdosvNyuDYXeMQaNomhIIeA32u55IrPMuRj3zt4AVkuA+7FgFRemEL lLgVL+g8SgEn/QNx7xY6EkC0IvAyNZEbVmP6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/2t0ybMsC+bp4wB69zKhzB1P3laG1AVoM2rvof1QopI=; b=Fic4PvfEhOjXEilGKX5CidxnKAnK89rbYpVbW7se9VjiOLRmAQjG6kv7QzFL8tq1uh Z5o1Ox0zaQhR2X13xJfPC2sH2nS9qsp9aD3kAFLGF8aVqRST3esLThyFI3Ru+SsVHmqN Zl0OTHxXqv2TaWF/W6NhZYiyfCRw8jUPaxQ1Mw6nuJw7e0gP7d6DskNtRv4iQSvUvysz aPVpgn/DJxLcPjhwAsCEW3VrCxFBHd8NTfFjstmXCoAnf/vZGBrOp+i31Ol9In7HbPfb 3KGNaeR8okXtODan+eqNXefwgELx3/J/CHSHry9wsDqmIu/h+wjjBNYejyDFtAejflmZ D7ew== X-Gm-Message-State: AIVw1118zxAEcuGIG4gD7ep77hmSbLeEM7CId6DwW2tS/7u6j0Rjmf7Y jSJBRZEJ15qsbdxu X-Received: by 10.223.160.68 with SMTP id l4mr14612869wrl.162.1501604394670; Tue, 01 Aug 2017 09:19:54 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d19sm32660750wrb.93.2017.08.01.09.19.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 09:19:53 -0700 (PDT) Date: Tue, 1 Aug 2017 17:19:52 +0100 From: Leif Lindholm To: Jun Nie Cc: haojian.zhuang@linaro.org, ard.biesheuvel@linaro.org, edk2-devel@lists.01.org, linaro-uefi@lists.linaro.org, shawn.guo@linaro.org, jason.liu@linaro.org Message-ID: <20170801161952.GE26462@bivouac.eciton.net> References: <1501579741-28866-1-git-send-email-jun.nie@linaro.org> <1501579741-28866-4-git-send-email-jun.nie@linaro.org> MIME-Version: 1.0 In-Reply-To: <1501579741-28866-4-git-send-email-jun.nie@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [PATCH v4 4/4] EmbeddedPkg: add Android boot device path and guid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 16:17:47 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Right, so this one confused me a bit, since it looked like it was breaking bisect again. It does, which caused me to take a closer look. First of all, you need to add EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.inf to EmbeddedPkg/EmbeddedPkg.dsc [Components.common]. Once done, you should be able to build the application standalone with build -a AARCH64 -t GCC5 -p EmbeddedPkg/EmbeddedPkg.dsc -m EmbeddedPkg/Application/AndroidBoot/AndroidBootApp.inf For this to work, you also need to add a AndroidBootImgLib mapping to [LibraryClasses.common]. Once that is done, the modifications here need to be squashed into 3/4. / Leif On Tue, Aug 01, 2017 at 05:29:01PM +0800, Jun Nie wrote: > The device path specifies where to load android boot image. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jun Nie > --- > EmbeddedPkg/EmbeddedPkg.dec | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec > index 4cd528a..8ad2a84 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dec > +++ b/EmbeddedPkg/EmbeddedPkg.dec > @@ -80,6 +80,7 @@ > gAndroidFastbootPlatformProtocolGuid = { 0x524685a0, 0x89a0, 0x11e3, {0x9d, 0x4d, 0xbf, 0xa9, 0xf6, 0xa4, 0x03, 0x08}} > gUsbDeviceProtocolGuid = { 0x021bd2ca, 0x51d2, 0x11e3, {0x8e, 0x56, 0xb7, 0x54, 0x17, 0xc7, 0x0b, 0x44 }} > gPlatformGpioProtocolGuid = { 0x52ce9845, 0x5af4, 0x43e2, {0xba, 0xfd, 0x23, 0x08, 0x12, 0x54, 0x7a, 0xc2 }} > + gAndroidBootImgProtocolGuid = { 0x9859bb19, 0x407c, 0x4f8b, {0xbc, 0xe1, 0xf8, 0xda, 0x65, 0x65, 0xf4, 0xa5 }} > > [PcdsFeatureFlag.common] > gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|FALSE|BOOLEAN|0x00000001 > @@ -181,6 +182,7 @@ > gEmbeddedTokenSpaceGuid.PcdAndroidFastbootUsbProductId|0xbeef|UINT32|0x00000023 > gEmbeddedTokenSpaceGuid.PcdAndroidFastbootTcpPort|1234|UINT32|0x00000024 > > + gEmbeddedTokenSpaceGuid.PcdAndroidBootDevicePath|L""|VOID*|0x00000057 > > [PcdsFixedAtBuild.ARM] > gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize|32|UINT8|0x00000010 > -- > 1.9.1 >